fix lint failing on first commit to branch

We now lint ALL files in the repository, not just those detected as changed in the commit (the procedure to do this failed when HEAD was exactly 1 commit ahead of the base branch). Also we now only lint pull requests, not in-progress pushes to any branch.

.clang-tidy

@@ -1,2 +1,2 @@
-Checks: '-*,clang-analyzer-core.*,clang-analyzer-deadcode.*,readability-*,-readability-magic-numbers,-readability-else-after-return,-readability-named-parameter,-readability-braces-around-statements,-readability-isolate-declaration,-readability-uppercase-literal-suffix,-readability-function-size,-readability-non-const-parameter,-clang-diagnostic-error'
+Checks: '-*,clang-analyzer-core.*,clang-analyzer-deadcode.*,readability-*,-readability-magic-numbers,-readability-else-after-return,-readability-named-parameter,-readability-braces-around-statements,-readability-isolate-declaration,-readability-uppercase-literal-suffix,-readability-function-size,-readability-non-const-parameter'
 HeaderFilterRegex: '(src|include)\/.*\.h'

.github/workflows/lint.yaml

@@ -1,13 +1,11 @@
 name: Lint
 on:
-  push:
-    paths:
-      - 'src/*'
-      - 'include/*'
   pull_request:
     paths:
       - 'src/*'
       - 'include/*'
+      - 'format.sh'
+      - '.clang-tidy'
 
 jobs:
   build:
@@ -18,18 +16,9 @@ jobs:
 
       - run: sudo apt-get install -y astyle clang-tidy
 
-      # lint files changed by the push/pr
-      - id: files
-        uses: trilom/file-changes-action@v1.2.4
-        with:
-          output: ' '
-        continue-on-error: true
-      - run: ./format.sh ${{ steps.files.outputs.files}}
-        if: ${{ steps.files.outcome == 'success' }}
       - run: ./format.sh
-        if: ${{ steps.files.outcome == 'failure' }}
 
-      # fail if any files were changed by ./format.sh
+      # Detect any files changed by ./format.sh
       - id: files_formatted
         uses: jackton1/find-changed-files@v1.1
         with: