From 746a42af64866d34311bfac7a5752ef3c45ef7ab Mon Sep 17 00:00:00 2001 From: Ethan Roseman Date: Mon, 4 Dec 2023 18:22:06 +0900 Subject: [PATCH] Debugging PR warning silliness (#1132) * Debugging PR warning silliness * by gorsh I think I've nabbed it --- .vscode/settings.json | 2 +- tools/warnings_count/check_new_warnings.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 8ed6ebd102..290eec4db1 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -61,7 +61,7 @@ }, "[python]": { "editor.formatOnType": true, - "editor.wordBasedSuggestions": false, + "editor.wordBasedSuggestions": "off", "editor.formatOnSave": true, "editor.formatOnSaveMode": "modifications", "editor.defaultFormatter": "ms-python.black-formatter", diff --git a/tools/warnings_count/check_new_warnings.sh b/tools/warnings_count/check_new_warnings.sh index 24072a7ebb..4406bedb13 100755 --- a/tools/warnings_count/check_new_warnings.sh +++ b/tools/warnings_count/check_new_warnings.sh @@ -22,7 +22,7 @@ then ninja | grep warning | sort > tools/warnings_count/warnings_new.txt else touch tools/warnings_count/warnings_new.txt - cat build_log.txt | grep warning || [[ $? == 1 ]] | sort > tools/warnings_count/warnings_new.txt + cat build_log.txt | grep warning | sort > tools/warnings_count/warnings_new.txt fi curl -L https://papermar.io/reports/warnings.txt > tools/warnings_count/warnings.txt