Mirrors/SubtitleEdit
1
0
Fork 0
mirror of https://github.com/SubtitleEdit/subtitleedit.git synced 2024-11-22 03:02:35 +01:00
Code Issues Projects Releases Wiki Activity

Fix crash in "Fix common errors" - thx Hardstylest :)

Browse Source 
Fix #8651
This commit is contained in:
Nikolaj Olsson 2024-07-20 17:24:06 +02:00
parent 97e3e47b50
commit dfdb2aa2ab
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Changelog.txt
View File

@ -17,7 +17,8 @@
* Fix Romanian translation version number - thx MediaExpres
* Fix UI burn-in window spacing/width/height - thx Hafran420
* Fix crash in "Whisper Audio to text" if no audio - thx morrellaberdeen
* Fix running "Faster-Whisper-XXL" without "Faster-Whisper" - thx shanedk
* Fix running "Faster-Whisper-XXL" without "Faster-Whisper" - thx shanedk
* Fix crash in "Fix common errors" - thx Hardstylest
4.0.7 (8th July 2024)

8
src/Test/Logic/ContinuationUtilitiesTest.cs
View File

@ -1622,6 +1622,14 @@ namespace Test.Logic
Assert.IsTrue(line1Actual);
}
[TestMethod]
public void IsItalic14()
{
var line1 = "liebe</i> ♫ ♫ <i>Bevor es zu spät ist</i> ♫ ♫ <i>Das, was";
var line1Actual = ContinuationUtilities.IsItalic(line1);
Assert.IsFalse(line1Actual);
}
[TestMethod]
public void HasPrefix1()
{

2
src/libse/Common/ContinuationUtilities.cs
View File

@ -839,7 +839,7 @@ namespace Nikse.SubtitleEdit.Core.Common
while (input.IndexOf("<i>", StringComparison.Ordinal) >= 0)
{
var startIndex = input.IndexOf("<i>", StringComparison.Ordinal);
var endIndex = input.IndexOf("</i>", StringComparison.Ordinal);
var endIndex = input.IndexOf("</i>", startIndex, StringComparison.Ordinal);
var textToRemove = endIndex >= 0 ? input.Substring(startIndex, (endIndex + 4) - startIndex) : input.Substring(startIndex);
input = input.Replace(textToRemove, string.Empty);
}