1
0
mirror of https://github.com/adobe/brackets.git synced 2024-11-20 09:53:00 +01:00
Commit Graph

17734 Commits

Author SHA1 Message Date
walfgithub
1b13b49a6b ALF Automation (#14727)
* Updated by ALF automation.

* Fixing the LANGUAGE_TOOLS_PREFERENCES key in strings.js

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.
2019-04-25 19:13:05 +05:30
walfgithub
6b6b597b7b ALF Automation (#14723)
* Updated by ALF automation.

* Fixing the LANGUAGE_TOOLS_PREFERENCES key in strings.js

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.
2019-04-25 11:27:38 +05:30
Shubham Yadav
6db26a250c Reinitiate tooling service on Node process crash (#14724)
* Fix for node process failing

* Modification #1

* Code cleanup

* Code cleanup #1

* Code cleanup #2: Removing timeout and adding comments

* Fixing Logging issue
2019-04-25 09:49:11 +05:30
Nitesh Kumar
16ed866fc5 Changed Health Data Pop Up String to point to new wiki URL (#14709) 2019-04-24 19:04:10 +05:30
walfgithub
b5e8b5d595 ALF Automation (#14721)
* Updated by ALF automation.

* Fixing the LANGUAGE_TOOLS_PREFERENCES key in strings.js

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.
2019-04-24 15:54:15 +05:30
walfgithub
6c927491d7 ALF Automation (#14702)
* Updated by ALF automation.

* Fixing the LANGUAGE_TOOLS_PREFERENCES key in strings.js

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.
2019-04-23 20:46:49 +05:30
Nitesh Kumar
396a3b8f15 Fixed Blank Error Dialog Issue (#14719) 2019-04-23 18:46:17 +05:30
Nitesh Kumar
9f50db1f7f Fixed UriToPath Utill Function (#14706)
* Fixed UriToPath Utill Function

* fixed for new file and network file
2019-04-22 14:13:28 +05:30
Nitesh Kumar
469f4e1c36 Fixed Find References Issue in release build (#14705)
* Fixed Find References Issue in release build

* disabling menu for non php file

* Added code to disable Find All References Menu for non php file

* corrected indentation
2019-04-22 14:12:08 +05:30
Nitesh Kumar
317992fa67 LSP Find References Feature (#14693)
* LSP Find References Feature

* Addressed bugs

* Addressed review comments

* Addressed review comments

* Changes to send data only once per 24 hours

* Adding Unit Test cases and supporting files

* changed string

* fixed review comments

* Addressed review comments

* Changed Shortcut to Ctrl-M

* Changed the Shortcut to Shift-F12
2019-04-15 16:12:35 +05:30
Shubham Yadav
dc8d9307ba Capability to Support Document & Project Symbols provided by a Language Server (#14697)
* Symbols Provider First Cut

* Linting the Symbols Provider

* Symbols Provider Second Cut

* Document Symbol and Project Symbol support in Brackets

* Minor Fixes

* Removing Typo, and adding null checks

* Addressing review comments

* Handle menu toggling in case of language change

* Remove active document check

* Add unittests for QuickOpen Symbols Provider
2019-04-14 19:57:54 +05:30
Shubham Yadav
4e55d2a150 Adding Code Hints Description Box for handling additional hint information in LSP (#14696)
* Code Hint Desc first cut

* Remove extra code

* Fixing Lint Issues

* Undo ESLINT Fixes

* Fix CSS Reflow issue

* Moving styles to brackets core
2019-04-14 19:56:21 +05:30
walfgithub
f1a5f23967 ALF Automation (#14701)
* Updated by ALF automation.

* Fixing the LANGUAGE_TOOLS_PREFERENCES key in strings.js

* Updated by ALF automation.
2019-04-12 23:49:56 +05:30
Nitesh Kumar
aa085a16e0 Sending New File Save/Open Analytics Data (#14700) 2019-04-12 23:49:00 +05:30
Snchit Grover
6f80d3c8c2 Changes to send data only once per 24 hours (#14695)
* Changes to send data only once per 24 hours

* Update HealthLogger.js
2019-04-12 23:48:12 +05:30
Shubham Yadav
379a26b649
Fix QuickOpen Bug where an Error occur on dismissing the Modal when no Document is opene (#14698) 2019-04-12 21:38:36 +05:30
Shubham Yadav
228ac28067 PHPCodeHints : Select initial element in the hint list (#14694)
* Select initial hint while showing hints

* Only selecting initial hint if token is not blank
2019-04-12 20:00:10 +05:30
walfgithub
69a162747c ALF Automation (#14699)
* Updated by ALF automation.

* Fixing the LANGUAGE_TOOLS_PREFERENCES key in strings.js
2019-04-12 17:53:33 +05:30
Shubham Yadav
b9c89f21cb CodeHint Related Bug Fixes (#14692) 2019-04-10 20:58:55 +05:30
Nitesh Kumar
5658e3d380 Sending Analytics Data for file Operation and LSP features (#14683)
* Sending Analytics Data for file Operation and LSP features

* Addressed review comments

* Addressed review comments

* Addressed review comments
2019-04-10 00:05:39 +05:30
Swagatam Mitra
a408323d4a Fix for "GetItNow" action behaviour (#14691)
* Fix for "GetItNow" action behaviour

Fix for "GetItNow" action behaviour

* Change variable success to initSuccess 

Make the variable name more explicit to depict it's to track update process initialisation success and not the success status of update process itself.
2019-04-09 23:42:12 +05:30
Nitesh Kumar
dcb9186909 Php Tooling Strings changes (#14688)
* Php Tooling Strings changes

* Addressed review comments
2019-04-08 15:32:38 +05:30
Nitesh Kumar
d602c87cab Fixed LSP Linting Synchronization Issues (#14685)
* Fixed LSP Linting Synchrnization Issues

* Addressed review comments

* Removing Linter Name as it is not required
2019-04-05 15:31:22 +05:30
Shubham Yadav
8b8e3382d1 Removing the old Brackets CLA check (#14684)
* Commenting the test script command

* Adding the new command

* Removing the old command
2019-04-05 15:25:16 +05:30
Sorab Bisht
f4e1853e0e
Merge pull request #14687 from niteskum/anonymousStringChanges
switching from anonymous to pseudonymous to align with the definition…
2019-04-05 14:48:47 +05:30
niteskum
c5f1960b00 switching from anonymous to pseudonymous to align with the definitions used in the GDPR 2019-04-05 11:49:22 +05:30
Nitesh Kumar
9516c8de26 Php Tooling Extensions Using LSP Framework (#14671)
* Php Tooling Extensions Using LSP Framework

* Corrected Indentation space

* Corrected ESLint Error

* addressed review comments

* Addressed review comments

* addressed review comments

* Added Preferences description string

* Addressed review comments

* Addressed review comments

* addressed review comments

* Addresed review comments

* Addresed review comments

* Addressed some bug

* Adding Unit test Files

* Corrected the strings

* Fixed Eslint Errors

* Added some unit test Cases

* using restart function

* Switch to php7 in travis before dependency installation

php-Tooling npm package requires felixfbecker/language-server php
package, which can only be installed on php7. this should fix the break
in brackets travis build
2019-04-03 14:12:03 +05:30
Shubham Yadav
b977dff1d7
Revert "Language Server Protocol Support for Brackets - Fix Author" (#14680) 2019-04-03 11:46:26 +05:30
Swagatam Mitra
c51d01fdfa
Merge pull request #14678 from adobe/shubham/CoAuthorFix
Language Server Protocol Support for Brackets - Fix Author
2019-04-03 11:23:05 +05:30
Subhash Jha
e7eccb82a1 Language Server Protocol Support for Brackets (#14606)
* LSP Initial set of changes

* Adding comments and a bit of cleanup

* Adding php client for lsp

* further cleanup

* removing dependency on HintUtils

* removing phpClient extension from this branch

* Cleanup

* fixing eslint errors

* Refactoring code- Removing dependency on JSUtils ANd adding basic structure for client capabilities

* Bug Fix: too many listeners were getting attached to node process + code cleanup

* putting null check and settign capabilities to default values

* reinitializing server on workspace change and moving out capabilities from client code

* cleanup

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Added error checks to the auto update mechanism. So in case the auto update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605)

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Removing custom comments

* Removing custom comments

* Fixing Typo

* Fixing Typo

* Add missing Params in function call

* Add missing Params in function call

* Correcting message type, handlers

* Correcting message type, handlers

* Minor correction on active project change

* Minor correction on active project change

* Correcting the message format for didChange

* Correcting the message format for didChange

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Stop Creation of Multiple Language Servers

* Stop Creation of Multiple Language Servers

* Make Language Client Generic, address review comments

* Make Language Client Generic, address review comments

* Correcting param descriptions

* Correcting param descriptions

* Modifying events handling logic for Language Client, add formatting option for communication params

* Modifying events handling logic for Language Client, add formatting option for communication params

* Add handlers for node side

* Add handlers for node side

* Removing explicit param creation, substituting with appropriate checks

* Removing explicit param creation, substituting with appropriate checks

* Fixing lint errors in MessageHandler.js

* Fixing lint errors in MessageHandler.js

* Messaging related cleanup

* Messaging related cleanup

* Adding default providers and feature managers

* Adding default providers and feature managers

* Adding banner and fixing lint error

* Adding banner and fixing lint error

* fix spacing issue

* fix spacing issue

* Fix spacing issues

* Fix spacing issues

* Add filetype checks for all events, minor server info corrections

* Add filetype checks for all events, minor server info corrections

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Correcting Typo

* Correcting Typo

* Adding bug fixes

* Adding bug fixes

* Adding bug fixes 2

* Adding bug fixes 2

* Addressing Review: Fixing minor typo

* Addressing Review: Fixing minor typo

* Minor bug fixes, functionality enhancements

* Minor bug fixes, functionality enhancements

* Adding tests for Language Server Support: first cut

* Adding tests for Language Server Support: first cut

* Adding banner, fixing lint errors

* Adding banner, fixing lint errors

* Adding dependency related tasks

* Adding dependency related tasks

* Fixing npm environment string

* Fixing npm environment string

* Changing handler name

* Changing handler name

* Changing file name to ClientLoader

* Changing file name to ClientLoader

* Changing variable name appropriately

* Changing variable name appropriately

* Grunt related changes for build

* Grunt related changes for build

* Adding additional requests and notifications for handling various scenarios

* Adding additional requests and notifications for handling various scenarios

* Adding Path Converter Utilities

* Adding Path Converter Utilities

* Changing Ternary operator to OR operater

* Changing Ternary operator to OR operater

* Addressing review comments

* Addressing review comments

* Removing the handler for editor change, will be handled explicitely

* Removing the handler for editor change, will be handled explicitely

* Patching JavaScriptCodeHints

* Patching JavaScriptCodeHints

* Preferences infra for LanguageTools

* Preferences infra for LanguageTools

* Fixing JS ParameterHints

* Fixing JS ParameterHints

* Fixing Default Parameter Hints Provider

* Fixing Default Parameter Hints Provider

* Fixing Path Converters

* Fixing Path Converters

* Fixing Lint in PathConverters

* Fixing Lint in PathConverters

* Retaining Posix Path on Win

* Retaining Posix Path on Win

* Fixing lint errors

* Fixing lint errors

* Fixing Node side Utils

* Fixing Node side Utils

* Fixing Promise related Issues

* Fixing Promise related Issues

* Set Server Capability in Start call

* Set Server Capability in Start call

* Review Comments & Bug Fixes

* Review Comments & Bug Fixes

* Addressing Review Comments

* Addressing Review Comments

* Fixing Lint

* Fixing Lint

Co-authored-by: Shubham Yadav <shubyada@adobe.com>
2019-04-02 16:59:52 +05:30
Subhash Jha
df7aea423a Language Server Protocol Support for Brackets (#14606)
* LSP Initial set of changes

* Adding comments and a bit of cleanup

* Adding php client for lsp

* further cleanup

* removing dependency on HintUtils

* removing phpClient extension from this branch

* Cleanup

* fixing eslint errors

* Refactoring code- Removing dependency on JSUtils ANd adding basic structure for client capabilities

* Bug Fix: too many listeners were getting attached to node process + code cleanup

* putting null check and settign capabilities to default values

* reinitializing server on workspace change and moving out capabilities from client code

* cleanup

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Added error checks to the auto update mechanism. So in case the auto update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605)

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Removing custom comments

* Removing custom comments

* Fixing Typo

* Fixing Typo

* Add missing Params in function call

* Add missing Params in function call

* Correcting message type, handlers

* Correcting message type, handlers

* Minor correction on active project change

* Minor correction on active project change

* Correcting the message format for didChange

* Correcting the message format for didChange

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Stop Creation of Multiple Language Servers

* Stop Creation of Multiple Language Servers

* Make Language Client Generic, address review comments

* Make Language Client Generic, address review comments

* Correcting param descriptions

* Correcting param descriptions

* Modifying events handling logic for Language Client, add formatting option for communication params

* Modifying events handling logic for Language Client, add formatting option for communication params

* Add handlers for node side

* Add handlers for node side

* Removing explicit param creation, substituting with appropriate checks

* Removing explicit param creation, substituting with appropriate checks

* Fixing lint errors in MessageHandler.js

* Fixing lint errors in MessageHandler.js

* Messaging related cleanup

* Messaging related cleanup

* Adding default providers and feature managers

* Adding default providers and feature managers

* Adding banner and fixing lint error

* Adding banner and fixing lint error

* fix spacing issue

* fix spacing issue

* Fix spacing issues

* Fix spacing issues

* Add filetype checks for all events, minor server info corrections

* Add filetype checks for all events, minor server info corrections

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Correcting Typo

* Correcting Typo

* Adding bug fixes

* Adding bug fixes

* Adding bug fixes 2

* Adding bug fixes 2

* Addressing Review: Fixing minor typo

* Addressing Review: Fixing minor typo

* Minor bug fixes, functionality enhancements

* Minor bug fixes, functionality enhancements

* Adding tests for Language Server Support: first cut

* Adding tests for Language Server Support: first cut

* Adding banner, fixing lint errors

* Adding banner, fixing lint errors

* Adding dependency related tasks

* Adding dependency related tasks

* Fixing npm environment string

* Fixing npm environment string

* Changing handler name

* Changing handler name

* Changing file name to ClientLoader

* Changing file name to ClientLoader

* Changing variable name appropriately

* Changing variable name appropriately

* Grunt related changes for build

* Grunt related changes for build

* Adding additional requests and notifications for handling various scenarios

* Adding additional requests and notifications for handling various scenarios

* Adding Path Converter Utilities

* Adding Path Converter Utilities

* Changing Ternary operator to OR operater

* Changing Ternary operator to OR operater

* Addressing review comments

* Addressing review comments

* Removing the handler for editor change, will be handled explicitely

* Removing the handler for editor change, will be handled explicitely

* Patching JavaScriptCodeHints

* Patching JavaScriptCodeHints

* Preferences infra for LanguageTools

* Preferences infra for LanguageTools

* Fixing JS ParameterHints

* Fixing JS ParameterHints

* Fixing Default Parameter Hints Provider

* Fixing Default Parameter Hints Provider

* Fixing Path Converters

* Fixing Path Converters

* Fixing Lint in PathConverters

* Fixing Lint in PathConverters

* Retaining Posix Path on Win

* Retaining Posix Path on Win

* Fixing lint errors

* Fixing lint errors

* Fixing Node side Utils

* Fixing Node side Utils

* Fixing Promise related Issues

* Fixing Promise related Issues

* Set Server Capability in Start call

* Set Server Capability in Start call

* Review Comments & Bug Fixes

* Review Comments & Bug Fixes

* Addressing Review Comments

* Addressing Review Comments

* Fixing Lint

* Fixing Lint
2019-04-02 15:05:43 +05:30
Swagatam Mitra
6cd2092ace Update notification - based on current platform (#14655)
* Update notification - based on current platform

* Fix lint error in Global.js

* Restructure validity check and remove duplicate function definition
2019-03-05 13:58:39 +05:30
Prashanth Nethi
7479c0356f Added error checks to the auto update mechanism. So in case the auto update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605) 2018-12-03 11:34:51 +05:30
Narayani
488edaffa0 Update CSSProperties.json for text-align and text-justify (#14563)
* Adding css3 new values start, end, match-parent, justify-all to text-align property and adding the property text-justify with its values.

* Update CSSProperties.json

* Adding "inherit" value for text-justify
2018-10-16 13:16:16 +05:30
Nitesh Kumar
8f5be981be jsRefactor Rename Relative Path issue fixed (#14520)
* jsRefactor Rename Realtice Path issue fixed

* Addressed review comments
2018-08-27 19:08:11 +05:30
Nitesh Kumar
fa00beb5f9 Fixed Getter Setter Redo Issue (#14508)
* Fixed Getter Setter Redo Issue

* Addressed Review Comments
2018-08-10 18:06:34 +05:30
Nitesh Kumar
0cee7d4575 Fixed ExtractToVariable Menu Close Issue due to scrolling (#14492)
* Fixed ExtractToVariable Menu Close Issue due to scrolling

* Addressed Review Comments

* Addessed review comments

* Addressed Review Comments

* Addressed Review Comments
2018-08-02 18:54:10 +05:30
Nitesh Kumar
afcbff03bb JSRefactoring Bugs Fix (#14455)
* JSRefactoring Bugs Fix

* Added Fix For TRY-CATCH Wraaper

* Corrected the typo

* Addressed Review Comments

* Addressed Review Comments

* Addressed Review Comments
2018-08-02 15:20:15 +05:30
Nitesh Kumar
7c29cc57f1 Auto Update Error Handlng Fix (#14412)
* Auto Update Error Handlng Fix

* Addressed Review comments
2018-07-24 13:29:15 +05:30
Sorab Bisht
93cfeacca6 Version bump to 1.14 (#14396) 2018-06-15 11:25:08 +05:30
Sorab Bisht
10b651b18a Fix for Title bar text and Save button issue for empty active pane (#14421)
* Adding null checks to fix title change issue

* Change the menu items visibility when file is present in active pane

* Enable Menu options when no file is present in active pane
2018-06-14 11:21:15 +05:30
Sorab Bisht
defded0caf Fix for FindInFiles UI not opening when no file is open (#14416)
* Add null check for editor

* Cleanup: Use tertiary operator
2018-06-13 11:34:42 +05:30
walfgithub
db9583f4bf ALF Automation (#14333)
Merging strings for 1.13 release.
2018-06-04 14:58:57 +05:30
Vickramaditya Dhawal
c25562013c
Merge pull request #14381 from niteskum/NewAutoUpdateBugs
Corrected extra % when user try to attempt the download for the second time
2018-06-04 14:56:24 +05:30
niteskum
e5018f74f6 Fix for Bug #14379 2018-06-01 12:50:41 +05:30
Vickramaditya Dhawal
04c4bb33e2 Introducing a buildtype to config (#14369)
* adding a buildtype as prerelease and switching back the environemnt to production as the analytics server expects that

* switching the environment actually to production
2018-05-29 17:05:55 +05:30
Vickramaditya Dhawal
4300f5a234
Merge pull request #14364 from niteskum/AutoUpdateLocalizationBug
Fix for Localization Bug and Retaining the Installer Log
2018-05-28 17:25:58 +05:30
Vickramaditya Dhawal
288449bc3a Adding a pre release build step (#14360)
* adding a new grunt task to generate pre-release builds with the proper auto update url

* fixing eslint issues

* further changes to pre release builds

* fixing the access of config obj
2018-05-28 16:05:36 +05:30
Bhavika Miglani
6022b48a60 Fixing multiple windows issues in AutoUpdate (#14320)
* Fixing multiple windows issues in AutoUpdate

* Addressing review comments, fixing unit testing issues

* Added Fix for Multiple Window Issue

* Addressed Review Comments

* Addressed Review Comments

* Addressed Review Comments
2018-05-28 14:53:13 +05:30
niteskum
7326f0b193 Fix for Localization Bug and Retaining the Installer Log 2018-05-28 14:16:45 +05:30