1
0
mirror of https://github.com/adobe/brackets.git synced 2024-11-20 18:02:54 +01:00
Commit Graph

17712 Commits

Author SHA1 Message Date
Nitesh Kumar
d602c87cab Fixed LSP Linting Synchronization Issues (#14685)
* Fixed LSP Linting Synchrnization Issues

* Addressed review comments

* Removing Linter Name as it is not required
2019-04-05 15:31:22 +05:30
Shubham Yadav
8b8e3382d1 Removing the old Brackets CLA check (#14684)
* Commenting the test script command

* Adding the new command

* Removing the old command
2019-04-05 15:25:16 +05:30
Sorab Bisht
f4e1853e0e
Merge pull request #14687 from niteskum/anonymousStringChanges
switching from anonymous to pseudonymous to align with the definition…
2019-04-05 14:48:47 +05:30
niteskum
c5f1960b00 switching from anonymous to pseudonymous to align with the definitions used in the GDPR 2019-04-05 11:49:22 +05:30
Nitesh Kumar
9516c8de26 Php Tooling Extensions Using LSP Framework (#14671)
* Php Tooling Extensions Using LSP Framework

* Corrected Indentation space

* Corrected ESLint Error

* addressed review comments

* Addressed review comments

* addressed review comments

* Added Preferences description string

* Addressed review comments

* Addressed review comments

* addressed review comments

* Addresed review comments

* Addresed review comments

* Addressed some bug

* Adding Unit test Files

* Corrected the strings

* Fixed Eslint Errors

* Added some unit test Cases

* using restart function

* Switch to php7 in travis before dependency installation

php-Tooling npm package requires felixfbecker/language-server php
package, which can only be installed on php7. this should fix the break
in brackets travis build
2019-04-03 14:12:03 +05:30
Shubham Yadav
b977dff1d7
Revert "Language Server Protocol Support for Brackets - Fix Author" (#14680) 2019-04-03 11:46:26 +05:30
Swagatam Mitra
c51d01fdfa
Merge pull request #14678 from adobe/shubham/CoAuthorFix
Language Server Protocol Support for Brackets - Fix Author
2019-04-03 11:23:05 +05:30
Subhash Jha
e7eccb82a1 Language Server Protocol Support for Brackets (#14606)
* LSP Initial set of changes

* Adding comments and a bit of cleanup

* Adding php client for lsp

* further cleanup

* removing dependency on HintUtils

* removing phpClient extension from this branch

* Cleanup

* fixing eslint errors

* Refactoring code- Removing dependency on JSUtils ANd adding basic structure for client capabilities

* Bug Fix: too many listeners were getting attached to node process + code cleanup

* putting null check and settign capabilities to default values

* reinitializing server on workspace change and moving out capabilities from client code

* cleanup

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Added error checks to the auto update mechanism. So in case the auto update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605)

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Removing custom comments

* Removing custom comments

* Fixing Typo

* Fixing Typo

* Add missing Params in function call

* Add missing Params in function call

* Correcting message type, handlers

* Correcting message type, handlers

* Minor correction on active project change

* Minor correction on active project change

* Correcting the message format for didChange

* Correcting the message format for didChange

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Stop Creation of Multiple Language Servers

* Stop Creation of Multiple Language Servers

* Make Language Client Generic, address review comments

* Make Language Client Generic, address review comments

* Correcting param descriptions

* Correcting param descriptions

* Modifying events handling logic for Language Client, add formatting option for communication params

* Modifying events handling logic for Language Client, add formatting option for communication params

* Add handlers for node side

* Add handlers for node side

* Removing explicit param creation, substituting with appropriate checks

* Removing explicit param creation, substituting with appropriate checks

* Fixing lint errors in MessageHandler.js

* Fixing lint errors in MessageHandler.js

* Messaging related cleanup

* Messaging related cleanup

* Adding default providers and feature managers

* Adding default providers and feature managers

* Adding banner and fixing lint error

* Adding banner and fixing lint error

* fix spacing issue

* fix spacing issue

* Fix spacing issues

* Fix spacing issues

* Add filetype checks for all events, minor server info corrections

* Add filetype checks for all events, minor server info corrections

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Correcting Typo

* Correcting Typo

* Adding bug fixes

* Adding bug fixes

* Adding bug fixes 2

* Adding bug fixes 2

* Addressing Review: Fixing minor typo

* Addressing Review: Fixing minor typo

* Minor bug fixes, functionality enhancements

* Minor bug fixes, functionality enhancements

* Adding tests for Language Server Support: first cut

* Adding tests for Language Server Support: first cut

* Adding banner, fixing lint errors

* Adding banner, fixing lint errors

* Adding dependency related tasks

* Adding dependency related tasks

* Fixing npm environment string

* Fixing npm environment string

* Changing handler name

* Changing handler name

* Changing file name to ClientLoader

* Changing file name to ClientLoader

* Changing variable name appropriately

* Changing variable name appropriately

* Grunt related changes for build

* Grunt related changes for build

* Adding additional requests and notifications for handling various scenarios

* Adding additional requests and notifications for handling various scenarios

* Adding Path Converter Utilities

* Adding Path Converter Utilities

* Changing Ternary operator to OR operater

* Changing Ternary operator to OR operater

* Addressing review comments

* Addressing review comments

* Removing the handler for editor change, will be handled explicitely

* Removing the handler for editor change, will be handled explicitely

* Patching JavaScriptCodeHints

* Patching JavaScriptCodeHints

* Preferences infra for LanguageTools

* Preferences infra for LanguageTools

* Fixing JS ParameterHints

* Fixing JS ParameterHints

* Fixing Default Parameter Hints Provider

* Fixing Default Parameter Hints Provider

* Fixing Path Converters

* Fixing Path Converters

* Fixing Lint in PathConverters

* Fixing Lint in PathConverters

* Retaining Posix Path on Win

* Retaining Posix Path on Win

* Fixing lint errors

* Fixing lint errors

* Fixing Node side Utils

* Fixing Node side Utils

* Fixing Promise related Issues

* Fixing Promise related Issues

* Set Server Capability in Start call

* Set Server Capability in Start call

* Review Comments & Bug Fixes

* Review Comments & Bug Fixes

* Addressing Review Comments

* Addressing Review Comments

* Fixing Lint

* Fixing Lint

Co-authored-by: Shubham Yadav <shubyada@adobe.com>
2019-04-02 16:59:52 +05:30
Subhash Jha
df7aea423a Language Server Protocol Support for Brackets (#14606)
* LSP Initial set of changes

* Adding comments and a bit of cleanup

* Adding php client for lsp

* further cleanup

* removing dependency on HintUtils

* removing phpClient extension from this branch

* Cleanup

* fixing eslint errors

* Refactoring code- Removing dependency on JSUtils ANd adding basic structure for client capabilities

* Bug Fix: too many listeners were getting attached to node process + code cleanup

* putting null check and settign capabilities to default values

* reinitializing server on workspace change and moving out capabilities from client code

* cleanup

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Added error checks to the auto update mechanism. So in case the auto update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605)

* First cut for LSP support in Brackets

* First cut for LSP support in Brackets

* Adding client infrastructure

* Adding client infrastructure

* Adding handlers on Language Client Proxy, fixing eslint errors

* Adding handlers on Language Client Proxy, fixing eslint errors

* Fixing protocol adapter

* Fixing protocol adapter

* Fix typo

* Fix typo

* Removing older implementation

* Removing older implementation

* Removing custom comments

* Removing custom comments

* Fixing Typo

* Fixing Typo

* Add missing Params in function call

* Add missing Params in function call

* Correcting message type, handlers

* Correcting message type, handlers

* Minor correction on active project change

* Minor correction on active project change

* Correcting the message format for didChange

* Correcting the message format for didChange

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Changing custom notification and request handlers, correcting typo, adding catch block for Connection

* Stop Creation of Multiple Language Servers

* Stop Creation of Multiple Language Servers

* Make Language Client Generic, address review comments

* Make Language Client Generic, address review comments

* Correcting param descriptions

* Correcting param descriptions

* Modifying events handling logic for Language Client, add formatting option for communication params

* Modifying events handling logic for Language Client, add formatting option for communication params

* Add handlers for node side

* Add handlers for node side

* Removing explicit param creation, substituting with appropriate checks

* Removing explicit param creation, substituting with appropriate checks

* Fixing lint errors in MessageHandler.js

* Fixing lint errors in MessageHandler.js

* Messaging related cleanup

* Messaging related cleanup

* Adding default providers and feature managers

* Adding default providers and feature managers

* Adding banner and fixing lint error

* Adding banner and fixing lint error

* fix spacing issue

* fix spacing issue

* Fix spacing issues

* Fix spacing issues

* Add filetype checks for all events, minor server info corrections

* Add filetype checks for all events, minor server info corrections

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Handling Reload with Extension Scenario, minor JumpToDef provider fix

* Correcting Typo

* Correcting Typo

* Adding bug fixes

* Adding bug fixes

* Adding bug fixes 2

* Adding bug fixes 2

* Addressing Review: Fixing minor typo

* Addressing Review: Fixing minor typo

* Minor bug fixes, functionality enhancements

* Minor bug fixes, functionality enhancements

* Adding tests for Language Server Support: first cut

* Adding tests for Language Server Support: first cut

* Adding banner, fixing lint errors

* Adding banner, fixing lint errors

* Adding dependency related tasks

* Adding dependency related tasks

* Fixing npm environment string

* Fixing npm environment string

* Changing handler name

* Changing handler name

* Changing file name to ClientLoader

* Changing file name to ClientLoader

* Changing variable name appropriately

* Changing variable name appropriately

* Grunt related changes for build

* Grunt related changes for build

* Adding additional requests and notifications for handling various scenarios

* Adding additional requests and notifications for handling various scenarios

* Adding Path Converter Utilities

* Adding Path Converter Utilities

* Changing Ternary operator to OR operater

* Changing Ternary operator to OR operater

* Addressing review comments

* Addressing review comments

* Removing the handler for editor change, will be handled explicitely

* Removing the handler for editor change, will be handled explicitely

* Patching JavaScriptCodeHints

* Patching JavaScriptCodeHints

* Preferences infra for LanguageTools

* Preferences infra for LanguageTools

* Fixing JS ParameterHints

* Fixing JS ParameterHints

* Fixing Default Parameter Hints Provider

* Fixing Default Parameter Hints Provider

* Fixing Path Converters

* Fixing Path Converters

* Fixing Lint in PathConverters

* Fixing Lint in PathConverters

* Retaining Posix Path on Win

* Retaining Posix Path on Win

* Fixing lint errors

* Fixing lint errors

* Fixing Node side Utils

* Fixing Node side Utils

* Fixing Promise related Issues

* Fixing Promise related Issues

* Set Server Capability in Start call

* Set Server Capability in Start call

* Review Comments & Bug Fixes

* Review Comments & Bug Fixes

* Addressing Review Comments

* Addressing Review Comments

* Fixing Lint

* Fixing Lint
2019-04-02 15:05:43 +05:30
Swagatam Mitra
6cd2092ace Update notification - based on current platform (#14655)
* Update notification - based on current platform

* Fix lint error in Global.js

* Restructure validity check and remove duplicate function definition
2019-03-05 13:58:39 +05:30
Prashanth Nethi
7479c0356f Added error checks to the auto update mechanism. So in case the auto update mechansim fails, we will now give chance to the default update process Handler to handle the update mechanism (Which is essentially taking the user to brackets.io). (#14605) 2018-12-03 11:34:51 +05:30
Narayani
488edaffa0 Update CSSProperties.json for text-align and text-justify (#14563)
* Adding css3 new values start, end, match-parent, justify-all to text-align property and adding the property text-justify with its values.

* Update CSSProperties.json

* Adding "inherit" value for text-justify
2018-10-16 13:16:16 +05:30
Nitesh Kumar
8f5be981be jsRefactor Rename Relative Path issue fixed (#14520)
* jsRefactor Rename Realtice Path issue fixed

* Addressed review comments
2018-08-27 19:08:11 +05:30
Nitesh Kumar
fa00beb5f9 Fixed Getter Setter Redo Issue (#14508)
* Fixed Getter Setter Redo Issue

* Addressed Review Comments
2018-08-10 18:06:34 +05:30
Nitesh Kumar
0cee7d4575 Fixed ExtractToVariable Menu Close Issue due to scrolling (#14492)
* Fixed ExtractToVariable Menu Close Issue due to scrolling

* Addressed Review Comments

* Addessed review comments

* Addressed Review Comments

* Addressed Review Comments
2018-08-02 18:54:10 +05:30
Nitesh Kumar
afcbff03bb JSRefactoring Bugs Fix (#14455)
* JSRefactoring Bugs Fix

* Added Fix For TRY-CATCH Wraaper

* Corrected the typo

* Addressed Review Comments

* Addressed Review Comments

* Addressed Review Comments
2018-08-02 15:20:15 +05:30
Nitesh Kumar
7c29cc57f1 Auto Update Error Handlng Fix (#14412)
* Auto Update Error Handlng Fix

* Addressed Review comments
2018-07-24 13:29:15 +05:30
Sorab Bisht
93cfeacca6 Version bump to 1.14 (#14396) 2018-06-15 11:25:08 +05:30
Sorab Bisht
10b651b18a Fix for Title bar text and Save button issue for empty active pane (#14421)
* Adding null checks to fix title change issue

* Change the menu items visibility when file is present in active pane

* Enable Menu options when no file is present in active pane
2018-06-14 11:21:15 +05:30
Sorab Bisht
defded0caf Fix for FindInFiles UI not opening when no file is open (#14416)
* Add null check for editor

* Cleanup: Use tertiary operator
2018-06-13 11:34:42 +05:30
walfgithub
db9583f4bf ALF Automation (#14333)
Merging strings for 1.13 release.
2018-06-04 14:58:57 +05:30
Vickramaditya Dhawal
c25562013c
Merge pull request #14381 from niteskum/NewAutoUpdateBugs
Corrected extra % when user try to attempt the download for the second time
2018-06-04 14:56:24 +05:30
niteskum
e5018f74f6 Fix for Bug #14379 2018-06-01 12:50:41 +05:30
Vickramaditya Dhawal
04c4bb33e2 Introducing a buildtype to config (#14369)
* adding a buildtype as prerelease and switching back the environemnt to production as the analytics server expects that

* switching the environment actually to production
2018-05-29 17:05:55 +05:30
Vickramaditya Dhawal
4300f5a234
Merge pull request #14364 from niteskum/AutoUpdateLocalizationBug
Fix for Localization Bug and Retaining the Installer Log
2018-05-28 17:25:58 +05:30
Vickramaditya Dhawal
288449bc3a Adding a pre release build step (#14360)
* adding a new grunt task to generate pre-release builds with the proper auto update url

* fixing eslint issues

* further changes to pre release builds

* fixing the access of config obj
2018-05-28 16:05:36 +05:30
Bhavika Miglani
6022b48a60 Fixing multiple windows issues in AutoUpdate (#14320)
* Fixing multiple windows issues in AutoUpdate

* Addressing review comments, fixing unit testing issues

* Added Fix for Multiple Window Issue

* Addressed Review Comments

* Addressed Review Comments

* Addressed Review Comments
2018-05-28 14:53:13 +05:30
niteskum
7326f0b193 Fix for Localization Bug and Retaining the Installer Log 2018-05-28 14:16:45 +05:30
Boopesh Mahendran
37793e7e13 Fix Issue 14346 - Disable commands on File Change (#14352)
* Disable menu items on file change

* Refactor the enable/disable logic
2018-05-23 18:55:37 +05:30
Nitesh Kumar
0d4247473b Adding AutoUpdate Analytics Data (#14348)
* Adding AutoUpdate Analytics Data

* Removed Localization of Strings sent as part of Analytics Data

* Addressed Review Comments
2018-05-22 14:56:57 +05:30
Nitesh Kumar
7cb6b2c56e Auto Update Bug Fixes (#14329)
* Auto Update Bug Fix

* Added Fix for Bug #14234

* Added Fix for #14234

* Changed the timeout Value to 3 mins

* Addressed Review Comments

* Removed Analytics Change

* Addressed Review Comments

* Addressed Review Comments
2018-05-21 18:31:26 +05:30
Naveen Choudhary
8d951655f3 Fixing issue 14163, find and replace replaces all content of file when replacing new line (#14175) 2018-05-18 16:25:20 +05:30
Boopesh Mahendran
dcfe5792f6 Set the context entry on context menu event (#14336)
* Set the context entry on context menu event

* Remove unwanted constant
2018-05-17 16:04:06 +05:30
walfgithub
551b801736 ALF Automation (#14325)
* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.
2018-05-16 11:58:07 +05:30
Swagatam Mitra
79b7a7837a Make remote files read only (#14332) 2018-05-15 18:22:04 +05:30
Shubham Yadav
a813265d14 Adding protocol badge to remote files (#14330)
* Using as class provider to add protocol badges to files in Working set view and recent files list

* Fixing UI issues

* Removing explicit removal of classes, as it causes valid classes to be removed. jquery addClass already has this check

* Show badge even if file extension not present
2018-05-15 18:05:59 +05:30
Naveen Choudhary
64ffb198f5 Disabling certain working set context menu items for remote files (#14326)
* Disabeling working set context menu for remote files

* Address review comments

* Expose a get context method in workingSetView and use it

* Remove MainViewManager require
2018-05-15 17:04:00 +05:30
Bhavika Miglani
27c7053821 AutoUpdate : Changing callbacks to promises (#14285)
* AutoUpdate : Changing callbacks to promises

* Addressing review comments
2018-05-15 16:14:22 +05:30
Naveen Choudhary
ca5d2ae060 Correcting file name if file path ends with forward slash (#14323) 2018-05-12 09:31:06 +05:30
walfgithub
c4d4684bfe ALF Automation (#14283)
* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.
2018-05-11 13:30:48 +05:30
Boopesh Mahendran
19ccd5d5ad Fix Issue 14313 (#14317) 2018-05-09 19:05:48 +05:30
Nitesh Kumar
68aa861681 Auto Update Feature CSS Style Issue Fix (#14295)
* Auto Update Feature Css Bug Fix

* Adding Missed Files

* Changed the caluclation of content Container Size

* Added Fix for Issue #14219 and #14223

* Added missed changes

* Addressed Update Status Style Issue

* Addressed Review Comments

* Addressed Review Comments
2018-05-09 19:04:58 +05:30
Boopesh Mahendran
a383712e29 Fix issue 14298 (#14312) 2018-05-08 23:03:38 +05:30
Sorab Bisht
e0b6620f38 Adding Analytics logging for JSRefactor, Live Preview, Quick Edit and more features (#14253)
* Adding Analytics logging for JSRefactor, Live Preview, Quick Edit and more features

* Addressing review comments
2018-05-07 14:07:33 +05:30
Swagatam Mitra
421ed1a206 Enable opening of remote(http|https) files in Brackets (#14153)
* Enable opening of remote(http|https) files in Brackets

* Adding jasmine tests

* Hooking to QuickOpen for remote file open

* Remove console statements

* Address code review comments

* Providing additional checks

* Unifying file existense check in MRU

* Include Remote file entries in MROF display list by stubbing existence check

* Handle image viewer and pixel mapping
2018-05-04 14:13:51 +05:30
Boopesh Mahendran
1d3f8135e7 Change ERROR_MOVING_NOT_IN_PROJECT string (#14297) 2018-05-03 15:23:21 +05:30
Boopesh Mahendran
5671a2868d Add background color for the drag image (#14292)
* Add background color for the drag image

* Change styles of the drag Image
2018-05-03 12:26:24 +05:30
Boopesh Mahendran
ac6b9df1a4 Store drag and drop data as a global variable (#14287) 2018-05-02 15:27:33 +05:30
walfgithub
2869fee6bd ALF Automation (#14198)
* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.

* Updated by ALF automation.
2018-04-27 19:09:00 +05:30
Bhavika Miglani
42f6f75065 Support for Auto-update in Prereleases (#14251)
* Support for Auto-update in Prereleases

* Correcting comments

* Addressing review comments
2018-04-27 18:36:02 +05:30