1
0
mirror of https://github.com/gorhill/uBlock.git synced 2024-09-15 15:32:28 +02:00

code review re. #1735

This commit is contained in:
gorhill 2016-09-13 11:56:13 -04:00
parent 08dd67b854
commit 0870aea2eb

View File

@ -392,15 +392,14 @@ housekeep itself.
}; };
// https://github.com/gorhill/uBlock/issues/1735 // https://github.com/gorhill/uBlock/issues/1735
// Always push before committing, to allow popup detector code to do its // Filter for popups if actually committing.
// job.
var commit = function(tabId, url) { var commit = function(tabId, url) {
var entry = tabContexts[tabId]; var entry = tabContexts[tabId];
if ( entry === undefined ) { if ( entry === undefined ) {
entry = push(tabId, url); entry = push(tabId, url);
} else { } else {
entry.push(url);
entry.commit(url); entry.commit(url);
popupCandidateTest(tabId);
} }
return entry; return entry;
}; };