[InstCombine] Fold overflow bit of [u|s]mul.with.overflow in a poison-safe way
As discussed in D101191, this patch adds a poison-safe folding of overflow bit check:
```
%Op0 = icmp ne i4 %X, 0
%Agg = call { i4, i1 } @llvm.[us]mul.with.overflow.i4(i4 %X, i4 %Y)
%Op1 = extractvalue { i4, i1 } %Agg, 1
%ret = select i1 %Op0, i1 %Op1, i1 false
=>
%Y.fr = freeze %Y
%Agg = call { i4, i1 } @llvm.[us]mul.with.overflow.i4(i4 %X, i4 %Y.fr)
%Op1 = extractvalue { i4, i1 } %Agg, 1
%ret = %Op1
```
https://alive2.llvm.org/ce/z/zgPUGT
https://alive2.llvm.org/ce/z/h2gZ_6
Note that there are cases where inserting freeze is not necessary: e.g. %Y is `noundef`.
In this case, LLVM is already good because `%ret` is already successfully folded into `and`,
triggering the pre-existing optimization in InstSimplify: https://godbolt.org/z/v6qena15K
Differential Revision: https://reviews.llvm.org/D101423
2021-04-28 04:34:45 +02:00
|
|
|
//==-- OverflowInstAnalysis.cpp - Utils to fold overflow insts ----*- C++ -*-=//
|
|
|
|
//
|
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This file holds routines to help analyse overflow instructions
|
|
|
|
// and fold them into constants or other overflow instructions
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "llvm/Analysis/OverflowInstAnalysis.h"
|
|
|
|
#include "llvm/IR/Constants.h"
|
|
|
|
#include "llvm/IR/Instructions.h"
|
|
|
|
#include "llvm/IR/PatternMatch.h"
|
|
|
|
|
|
|
|
using namespace llvm;
|
|
|
|
using namespace llvm::PatternMatch;
|
|
|
|
|
|
|
|
bool llvm::isCheckForZeroAndMulWithOverflow(Value *Op0, Value *Op1, bool IsAnd,
|
|
|
|
Use *&Y) {
|
|
|
|
ICmpInst::Predicate Pred;
|
|
|
|
Value *X, *NotOp1;
|
|
|
|
int XIdx;
|
|
|
|
IntrinsicInst *II;
|
|
|
|
|
|
|
|
if (!match(Op0, m_ICmp(Pred, m_Value(X), m_Zero())))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/// %Agg = call { i4, i1 } @llvm.[us]mul.with.overflow.i4(i4 %X, i4 %???)
|
|
|
|
/// %V = extractvalue { i4, i1 } %Agg, 1
|
|
|
|
auto matchMulOverflowCheck = [X, &II, &XIdx](Value *V) {
|
|
|
|
auto *Extract = dyn_cast<ExtractValueInst>(V);
|
|
|
|
// We should only be extracting the overflow bit.
|
|
|
|
if (!Extract || !Extract->getIndices().equals(1))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
II = dyn_cast<IntrinsicInst>(Extract->getAggregateOperand());
|
2021-05-02 06:44:43 +02:00
|
|
|
if (!II ||
|
|
|
|
!match(II, m_CombineOr(m_Intrinsic<Intrinsic::umul_with_overflow>(),
|
[InstCombine] Fold overflow bit of [u|s]mul.with.overflow in a poison-safe way
As discussed in D101191, this patch adds a poison-safe folding of overflow bit check:
```
%Op0 = icmp ne i4 %X, 0
%Agg = call { i4, i1 } @llvm.[us]mul.with.overflow.i4(i4 %X, i4 %Y)
%Op1 = extractvalue { i4, i1 } %Agg, 1
%ret = select i1 %Op0, i1 %Op1, i1 false
=>
%Y.fr = freeze %Y
%Agg = call { i4, i1 } @llvm.[us]mul.with.overflow.i4(i4 %X, i4 %Y.fr)
%Op1 = extractvalue { i4, i1 } %Agg, 1
%ret = %Op1
```
https://alive2.llvm.org/ce/z/zgPUGT
https://alive2.llvm.org/ce/z/h2gZ_6
Note that there are cases where inserting freeze is not necessary: e.g. %Y is `noundef`.
In this case, LLVM is already good because `%ret` is already successfully folded into `and`,
triggering the pre-existing optimization in InstSimplify: https://godbolt.org/z/v6qena15K
Differential Revision: https://reviews.llvm.org/D101423
2021-04-28 04:34:45 +02:00
|
|
|
m_Intrinsic<Intrinsic::smul_with_overflow>())))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (II->getArgOperand(0) == X)
|
|
|
|
XIdx = 0;
|
|
|
|
else if (II->getArgOperand(1) == X)
|
|
|
|
XIdx = 1;
|
|
|
|
else
|
|
|
|
return false;
|
|
|
|
return true;
|
|
|
|
};
|
|
|
|
|
|
|
|
bool Matched =
|
|
|
|
(IsAnd && Pred == ICmpInst::Predicate::ICMP_NE &&
|
|
|
|
matchMulOverflowCheck(Op1)) ||
|
|
|
|
(!IsAnd && Pred == ICmpInst::Predicate::ICMP_EQ &&
|
|
|
|
match(Op1, m_Not(m_Value(NotOp1))) && matchMulOverflowCheck(NotOp1));
|
|
|
|
|
|
|
|
if (!Matched)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
Y = &II->getArgOperandUse(!XIdx);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool llvm::isCheckForZeroAndMulWithOverflow(Value *Op0, Value *Op1,
|
|
|
|
bool IsAnd) {
|
|
|
|
Use *Y;
|
|
|
|
return isCheckForZeroAndMulWithOverflow(Op0, Op1, IsAnd, Y);
|
|
|
|
}
|