RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-11-22 18:54:02 +01:00
Code Issues Projects Releases Wiki Activity

[ThinLTO] Don't import functions with noinline attribute

Browse Source 
Differential revision: https://reviews.llvm.org/D41489

llvm-svn: 321443
This commit is contained in:
Eugene Leviant 2017-12-25 13:57:24 +00:00
parent 6481dde696
commit bdcf8debc4
3 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Analysis/ModuleSummaryAnalysis.cpp
View File

@ -306,7 +306,9 @@ computeFunctionSummary(ModuleSummaryIndex &Index, const Module &M,
NonRenamableLocal || HasInlineAsmMaybeReferencingInternal ||
// Inliner doesn't handle variadic functions.
// FIXME: refactor this to use the same code that inliner is using.
F.isVarArg();
F.isVarArg() ||
// Don't try to import functions with noinline attribute.
F.getAttributes().hasFnAttribute(Attribute::NoInline);
GlobalValueSummary::GVFlags Flags(F.getLinkage(), NotEligibleForImport,
/* Live = */ false, F.isDSOLocal());
FunctionSummary::FFlags FunFlags{

8
test/ThinLTO/X86/Inputs/noinline.ll Normal file
View File

@ -0,0 +1,8 @@
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-linux-gnu"
define i32 @foo(i32) local_unnamed_addr #0 {
ret i32 10
}
attributes #0 = { noinline }

26
test/ThinLTO/X86/noinline.ll Normal file
View File

@ -0,0 +1,26 @@
; This test checks that ThinLTO doesn't try to import noinline function
; which, when takes place, causes promotion of its callee.
; RUN: opt -module-summary %s -o %t1.bc
; RUN: opt -module-summary %p/Inputs/noinline.ll -o %t2.bc
; RUN: llvm-lto2 run %t1.bc %t2.bc -o %t3.o \
; RUN: -save-temps \
; RUN: -r=%t1.bc,main,px \
; RUN: -r=%t1.bc,foo, \
; RUN: -r=%t2.bc,foo,p
; RUN: llvm-dis %t3.o.1.3.import.bc -o - | FileCheck %s
; CHECK-NOT: define available_externally i32 @foo
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-linux-gnu"
; Function Attrs: nounwind ssp uwtable
define i32 @main(i32, i8** nocapture readnone) local_unnamed_addr #0 {
%3 = tail call i32 @foo(i32 %0) #0
ret i32 %3
}
declare i32 @foo(i32) local_unnamed_addr
attributes #0 = { nounwind }