RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-22 04:22:57 +02:00
Code Issues Projects Releases Wiki Activity
103,543 Commits 4 Branches 5 Tags 704 MiB
883f9833f0
Commit Graph

179 Commits

Author SHA1 Message Date
Evgeniy Stepanov
309a0238f8 [asan] Set debug location in ASan function prologue. 
Most importantly, it gives debug location info to the coverage callback.

This change also removes 2 cases of unnecessary setDebugLoc when IRBuilder
is created with the same debug location.

llvm-svn: 208767
 2014-05-14 10:30:15 +00:00
Evgeniy Stepanov
196ad52640 [asan] Preserve flags in asm instrumentation. 
Patch by Yuri Gorshenin.

llvm-svn: 208296
 2014-05-08 09:55:24 +00:00
Evgeniy Stepanov
c02f1a9f96 [msan] Fix -fsanitize=memory -fno-integrated-as. 
llvm-svn: 208211
 2014-05-07 14:10:51 +00:00
Evgeniy Stepanov
4a872de9c5 [asan] Add a flag to control asm instrumentation. 
With this change, asm instrumentation is disabled by default.

llvm-svn: 208167
 2014-05-07 07:54:11 +00:00
Evgeniy Stepanov
6eb633223c [asan] Fix instrumentation of x86 intel syntax inline assembly. 
Patch by Yuri Gorshenin.

llvm-svn: 207092
 2014-04-24 09:56:15 +00:00
Evgeniy Stepanov
c242bd4b23 Create MCTargetOptions. 
For now it contains a single flag, SanitizeAddress, which enables
AddressSanitizer instrumentation of inline assembly.

Patch by Yuri Gorshenin.

llvm-svn: 206971
 2014-04-23 11:16:03 +00:00
Kostya Serebryany
291de5fd50 [asan] Support outline instrumentation for wide types and delete dead code, patch by Yuri Gribov 
llvm-svn: 206883
 2014-04-22 11:19:45 +00:00
Kostya Serebryany
d8c4c53242 [asan] add llvm-ish test for memset/etc instrumentation 
llvm-svn: 206747
 2014-04-21 11:57:43 +00:00
Evgeniy Stepanov
de38078fd6 [msan] Add -msan-instrumentation-with-call-threshold. 
This flag replaces inline instrumentation for checks and origin stores with
calls into MSan runtime library. This is a workaround for PR17409.

Disabled by default.

llvm-svn: 206585
 2014-04-18 12:17:20 +00:00
Kostya Serebryany
2b02920109 [asan] one more workaround for PR17409: don't do BB-level coverage instrumentation if there are more than N (=1500) basic blocks. This makes ASanCoverage work on libjpeg_turbo/jchuff.c used by Chrome, which has 1824 BBs 
llvm-svn: 206564
 2014-04-18 08:02:42 +00:00
Kostya Serebryany
9bec638044 [asan] add two new hidden compile-time flags for asan: asan-instrumentation-with-call-threshold and asan-memory-access-callback-prefix. This is part of the workaround for PR17409 (instrument huge functions with callbacks instead of inlined code). These flags will also help us experiment with kasan (kernel-asan) and clang 
llvm-svn: 206383
 2014-04-16 12:12:19 +00:00
Evgeniy Stepanov
c4006bcb3e [msan] Relax the test some more. 
This may or may not fix the bots. R204720 did not.

llvm-svn: 204721
 2014-03-25 14:32:05 +00:00
Evgeniy Stepanov
fc4fe22b40 [msan] Make some tests less strict. 
This may or may not fix the bots.

llvm-svn: 204720
 2014-03-25 14:15:14 +00:00
Evgeniy Stepanov
ad64faed33 [msan] More precise instrumentation of select IR. 
Some bits of select result may be initialized even if select condition
is not.

https://code.google.com/p/memory-sanitizer/issues/detail?id=50

llvm-svn: 204716
 2014-03-25 13:08:34 +00:00
Alexander Potapenko
7f1c389c71 [ASan] Add -asan-module to the ASan .ll tests. 
After the -asan pass had been split into -asan (function-level) and -asan-module (module-level) some of the
tests have silently stopped working, because they didn't instrument the globals anymore.
We've decided to have every test using both passes, irrespective of the presence of globals in it.

llvm-svn: 204335
 2014-03-20 11:16:34 +00:00
Alexander Potapenko
0eb130e34f [ASan] Do not instrument globals from the llvm.metadata section. 
Fixes https://code.google.com/p/address-sanitizer/issues/detail?id=279.

llvm-svn: 204331
 2014-03-20 10:48:34 +00:00
Evgeniy Stepanov
17d50b69f6 Set debug info for instructions inserted in SplitBlockAndInsertIfThen. 
llvm-svn: 204230
 2014-03-19 12:56:38 +00:00
Evgeniy Stepanov
4e42dcfe00 [msan] Origin tracking with history. 
LLVM part of MSan implementation of advanced origin tracking,
when we record not only creation point, but all locations where
an uninitialized value was stored to memory, too.

llvm-svn: 204151
 2014-03-18 13:30:56 +00:00
Evgeniy Stepanov
a7476058e1 AddressSanitizer instrumentation for MOV and MOVAPS. 
This is an initial version of *Sanitizer instrumentation of assembly code.

Patch by Yuri Gorshenin.

llvm-svn: 203908
 2014-03-14 08:58:04 +00:00
Evgeniy Stepanov
04442bc559 [msan] Fix handling of byval arguments in VarArg calls. 
llvm-svn: 203794
 2014-03-13 13:17:11 +00:00
Tim Northover
68c567a38a IR: add a second ordering operand to cmpxhg for failure 
The syntax for "cmpxchg" should now look something like:

	cmpxchg i32* %addr, i32 42, i32 3 acquire monotonic

where the second ordering argument gives the required semantics in the case
that no exchange takes place. It should be no stronger than the first ordering
constraint and cannot be either "release" or "acq_rel" (since no store will
have taken place).

rdar://problem/15996804

llvm-svn: 203559
 2014-03-11 10:48:52 +00:00
Evgeniy Stepanov
218cb7e60b [msan] Handle X86 SIMD bitshift intrinsics. 
llvm-svn: 202712
 2014-03-03 13:47:42 +00:00
Kostya Serebryany
c250e807b8 [asan] remove test that should have been removed in r202033 
llvm-svn: 202034
 2014-02-24 13:44:24 +00:00
Rafael Espindola
aea6192f20 Add back r201608, r201622, r201624 and r201625 
r201608 made llvm corretly handle private globals with MachO. r201622 fixed
a bug in it and r201624 and r201625 were changes for using private linkage,
assuming that llvm would do the right thing.

They all got reverted because r201608 introduced a crash in LTO. This patch
includes a fix for that. The issue was that TargetLoweringObjectFile now has
to be initialized before we can mangle names of private globals. This is
trivially true during the normal codegen pipeline (the asm printer does it),
but LTO has to do it manually.

llvm-svn: 201700
 2014-02-19 17:23:20 +00:00
Rafael Espindola
5bdf119d0c This reverts commit r201625 and r201624. 
Since r201608 got reverted, it is not safe to use private linkage in these cases
until it is committed back.

llvm-svn: 201688
 2014-02-19 15:49:46 +00:00
Rafael Espindola
e5f011f1b1 Now that llvm always does the right thing with private, use it. 
llvm-svn: 201625
 2014-02-19 02:08:39 +00:00
Kostya Serebryany
668ea393ac [asan] support for FreeBSD, LLVM part. patch by Viktor Kutuzov 
llvm-svn: 201067
 2014-02-10 07:37:04 +00:00
Kostya Serebryany
cbec3e2767 [asan] simplify a test 
llvm-svn: 200378
 2014-01-29 07:35:43 +00:00
Kostya Serebryany
88b5111b60 [asan] extend asan-coverage (still experimental). 
- add a mode for collecting per-block coverage (-asan-coverage=2).
   So far the implementation is naive (all blocks are instrumented),
   the performance overhead on top of asan could be as high as 30%.
 - Make sure the one-time calls to __sanitizer_cov are moved to function buttom,
   which in turn required to copy the original debug info into the call insn.

Here is the performance data on SPEC 2006
(train data, comparing asan with asan-coverage={0,1,2}):

                             asan+cov0     asan+cov1      diff 0-1    asan+cov2       diff 0-2      diff 1-2
       400.perlbench,        65.60,        65.80,         1.00,        76.20,         1.16,         1.16
           401.bzip2,        65.10,        65.50,         1.01,        75.90,         1.17,         1.16
             403.gcc,         1.64,         1.69,         1.03,         2.04,         1.24,         1.21
             429.mcf,        21.90,        22.60,         1.03,        23.20,         1.06,         1.03
           445.gobmk,       166.00,       169.00,         1.02,       205.00,         1.23,         1.21
           456.hmmer,        88.30,        87.90,         1.00,        91.00,         1.03,         1.04
           458.sjeng,       210.00,       222.00,         1.06,       258.00,         1.23,         1.16
      462.libquantum,         1.73,         1.75,         1.01,         2.11,         1.22,         1.21
         464.h264ref,       147.00,       152.00,         1.03,       160.00,         1.09,         1.05
         471.omnetpp,       115.00,       116.00,         1.01,       140.00,         1.22,         1.21
           473.astar,       133.00,       131.00,         0.98,       142.00,         1.07,         1.08
       483.xalancbmk,       118.00,       120.00,         1.02,       154.00,         1.31,         1.28
            433.milc,        19.80,        20.00,         1.01,        20.10,         1.02,         1.01
            444.namd,        16.20,        16.20,         1.00,        17.60,         1.09,         1.09
          447.dealII,        41.80,        42.20,         1.01,        43.50,         1.04,         1.03
          450.soplex,         7.51,         7.82,         1.04,         8.25,         1.10,         1.05
          453.povray,        14.00,        14.40,         1.03,        15.80,         1.13,         1.10
             470.lbm,        33.30,        34.10,         1.02,        34.10,         1.02,         1.00
         482.sphinx3,        12.40,        12.30,         0.99,        13.00,         1.05,         1.06

llvm-svn: 199488
 2014-01-17 11:00:30 +00:00
Alexander Potapenko
7096c20ede [ASan] Fix the tests broken by r198018 to check for private linkage of ASan-generated globals. 
llvm-svn: 198020
 2013-12-25 17:06:04 +00:00
Kostya Serebryany
a148c8c9ed [asan] don't unpoison redzones on function exit in use-after-return mode. 
Summary:
Before this change the instrumented code before Ret instructions looked like:
  <Unpoison Frame Redzones>
  if (Frame != OriginalFrame) // I.e. Frame is fake
     <Poison Complete Frame>

Now the instrumented code looks like:
  if (Frame != OriginalFrame) // I.e. Frame is fake
     <Poison Complete Frame>
  else
     <Unpoison Frame Redzones>

Reviewers: eugenis

Reviewed By: eugenis

CC: llvm-commits

Differential Revision: http://llvm-reviews.chandlerc.com/D2458

llvm-svn: 197907
 2013-12-23 14:15:08 +00:00
Evgeniy Stepanov
0cd4eea1b6 Add an explicit insert point argument to SplitBlockAndInsertIfThen. 
Currently SplitBlockAndInsertIfThen requires that branch condition is an
Instruction itself, which is very inconvenient, because it is sometimes an
Operator, or even a Constant.

llvm-svn: 197677
 2013-12-19 13:29:56 +00:00
Matt Arsenault
640386deb6 Teach MemoryBuiltins about address spaces 
llvm-svn: 197292
 2013-12-14 00:27:48 +00:00
Kostya Serebryany
fc32a3e5d2 [asan] rewrite asan's stack frame layout 
Summary:
Rewrite asan's stack frame layout.
First, most of the stack layout logic is moved into a separte file
to make it more testable and (potentially) useful for other projects.
Second, make the frames more compact by using adaptive redzones
(smaller for small objects, larger for large objects).
Third, try to minimized gaps due to large alignments (this is hypothetical since
today we don't see many stack vars aligned by more than 32).

The frames indeed become more compact, but I'll still need to run more benchmarks
before committing, but I am sking for review now to get early feedback.

This change will be accompanied by a trivial change in compiler-rt tests
to match the new frame sizes.

Reviewers: samsonov, dvyukov

Reviewed By: samsonov

CC: llvm-commits

Differential Revision: http://llvm-reviews.chandlerc.com/D2324

llvm-svn: 196568
 2013-12-06 09:00:17 +00:00
Kostya Serebryany
eb57b3e248 [tsan] fix PR18146: sometimes a variable written into vptr could have an integer type (after other optimizations) 
llvm-svn: 196507
 2013-12-05 15:03:02 +00:00
Kostya Serebryany
e71e08d007 [tsan] fix instrumentation of vector vptr updates (https://code.google.com/p/thread-sanitizer/issues/detail?id=43) 
llvm-svn: 196079
 2013-12-02 08:07:15 +00:00
Manman Ren
f0d5143ea6 Debug Info: update testing cases to specify the debug info version number. 
We are going to drop debug info without a version number or with a different
version number, to make sure we don't crash when we see bitcode files with
different debug info metadata format.

llvm-svn: 195504
 2013-11-22 21:49:45 +00:00
Peter Collingbourne
89b5505b6b Introduce two command-line flags for the instrumentation pass to control whether the labels of pointers should be ignored in load and store instructions 
The new command line flags are -dfsan-ignore-pointer-label-on-store and -dfsan-ignore-pointer-label-on-load. Their default value matches the current labelling scheme.

Additionally, the function __dfsan_union_load is marked as readonly.

Patch by Lorenzo Martignoni!

Differential Revision: http://llvm-reviews.chandlerc.com/D2187

llvm-svn: 195382
 2013-11-21 23:20:54 +00:00
Evgeniy Stepanov
405470ce24 [msan] Propagate condition origin in select instruction. 
llvm-svn: 195349
 2013-11-21 12:00:24 +00:00
Evgeniy Stepanov
0ee8c16502 Use multiple filecheck prefixes in msan instrumentation tests. 
llvm-svn: 195342
 2013-11-21 11:37:16 +00:00
Alexey Samsonov
cbf7462c74 [ASan] Fix PR17867 - make sure ASan doesn't crash if use-after-scope and use-after-return are combined. 
llvm-svn: 195014
 2013-11-18 14:53:55 +00:00
Bob Wilson
5f54393e59 Reapply "[asan] Poor man's coverage that works with ASan" 
I was able to successfully run a bootstrapped LTO build of clang with
r194701, so this change does not seem to be the cause of our failing
buildbots.

llvm-svn: 194789
 2013-11-15 07:16:09 +00:00
Bob Wilson
1eb0da26bc Revert "[asan] Poor man's coverage that works with ASan" 
This reverts commit 194701. Apple's bootstrapped LTO builds have been failing,
and this change (along with compiler-rt 194702-194704) is the only thing on
the blamelist.  I will either reappy these changes or help debug the problem,
depending on whether this fixes the buildbots.

llvm-svn: 194780
 2013-11-15 03:28:22 +00:00
Kostya Serebryany
8bd4b917a6 [asan] Poor man's coverage that works with ASan 
llvm-svn: 194701
 2013-11-14 13:27:41 +00:00
Evgeniy Stepanov
fec309eeb3 [msan] Use CHECK-DAG instead of CHECK where order of instructions does not matter. 
This may fix hexagon-elf bots.

llvm-svn: 194700
 2013-11-14 12:46:12 +00:00
Evgeniy Stepanov
01ee97e26c [msan] Fast path optimization for wrap-indirect-calls feature of MemorySanitizer. 
Indirect call wrapping helps MSanDR (dynamic instrumentation companion tool
for MSan) to catch all cases where execution leaves a compiler-instrumented
module by allowing the tool to rewrite targets of indirect calls.

This change is an optimization that skips wrapping for calls when target is
inside the current module. This relies on the linker providing symbols at the
begin and end of the module code (or code + data, does not really matter).
Gold linker provides such symbols by default. GNU (BFD) linker needs a link
flag: -Wl,--defsym=__executable_start=0.

More info:
https://code.google.com/p/memory-sanitizer/wiki/MSanDR#Native_exec

llvm-svn: 194697
 2013-11-14 12:29:04 +00:00
Evgeniy Stepanov
32b834b198 [msan] Propagate origin for insertvalue, extractvalue. 
llvm-svn: 194374
 2013-11-11 13:37:10 +00:00
Nuno Lopes
09c3fc8dac fix PR17635: false positive with packed structures 
LLVM optimizers may widen accesses to packed structures that overflow the structure itself, but should be in bounds up to the alignment of the object

llvm-svn: 193317
 2013-10-24 09:17:24 +00:00
Dmitry Vyukov
012cdf1364 tsan: implement no_sanitize_thread attribute 
If a function has no_sanitize_thread attribute,
do not instrument memory accesses in it.

llvm-svn: 192871
 2013-10-17 07:20:06 +00:00
Kostya Serebryany
2ae1ed1c8f [asan] Optimize accesses to global arrays with constant index 
Summary:
Given a global array G[N], which is declared in this CU and has static initializer
avoid instrumenting accesses like G[i], where 'i' is a constant and 0<=i<N.
Also add a bit of stats.

This eliminates ~1% of instrumentations on SPEC2006
and also partially helps when asan is being run together with coverage.

Reviewers: samsonov

Reviewed By: samsonov

CC: llvm-commits

Differential Revision: http://llvm-reviews.chandlerc.com/D1947

llvm-svn: 192794
 2013-10-16 14:06:14 +00:00