mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-19 02:52:53 +02:00
5538ea11d7
[Reapplying r284580 and r285917 with fix and testing to ensure emitted jump tables for Thumb-1 have 4-byte alignment] The TBB and TBH instructions in Thumb-2 allow jump tables to be compressed into sequences of bytes or shorts respectively. These instructions do not exist in Thumb-1, however it is possible to synthesize them out of a sequence of other instructions. It turns out this sequence is so short that it's almost never a lose for performance and is ALWAYS a significant win for code size. TBB example: Before: lsls r0, r0, #2 After: add r0, pc adr r1, .LJTI0_0 ldrb r0, [r0, #6] ldr r0, [r0, r1] lsls r0, r0, #1 mov pc, r0 add pc, r0 => No change in prologue code size or dynamic instruction count. Jump table shrunk by a factor of 4. The only case that can increase dynamic instruction count is the TBH case: Before: lsls r0, r4, #2 After: lsls r4, r4, #1 adr r1, .LJTI0_0 add r4, pc ldr r0, [r0, r1] ldrh r4, [r4, #6] mov pc, r0 lsls r4, r4, #1 add pc, r4 => 1 more instruction in prologue. Jump table shrunk by a factor of 2. So there is an argument that this should be disabled when optimizing for performance (and a TBH needs to be generated). I'm not so sure about that in practice, because on small cores with Thumb-1 performance is often tied to code size. But I'm willing to turn it off when optimizing for performance if people want (also note that TBHs are fairly rare in practice!) llvm-svn: 285690
44 lines
1.3 KiB
LLVM
44 lines
1.3 KiB
LLVM
; RUN: llc < %s
|
|
; No FileCheck - testing for crash.
|
|
|
|
target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
|
|
target triple = "thumbv5e-none-linux-gnueabi"
|
|
|
|
%struct.blam = type { [4 x %struct.eggs], [6 x [15 x i16]], [6 x i32], i32, i32, i32, i32, i32, i32, %struct.eggs, [4 x %struct.eggs], [4 x %struct.eggs], [4 x i32], i32, i32, i32, [4 x %struct.eggs], [4 x %struct.eggs], i32, %struct.eggs, i32 }
|
|
%struct.eggs = type { i32, i32 }
|
|
|
|
define void @spam(%struct.blam* %arg, i32 %arg1) {
|
|
bb:
|
|
%tmp = getelementptr inbounds %struct.blam, %struct.blam* %arg, i32 undef, i32 2, i32 %arg1
|
|
switch i32 %arg1, label %bb8 [
|
|
i32 0, label %bb2
|
|
i32 1, label %bb3
|
|
i32 2, label %bb4
|
|
i32 3, label %bb5
|
|
i32 4, label %bb6
|
|
i32 5, label %bb7
|
|
]
|
|
|
|
bb2: ; preds = %bb
|
|
unreachable
|
|
|
|
bb3: ; preds = %bb
|
|
unreachable
|
|
|
|
bb4: ; preds = %bb
|
|
unreachable
|
|
|
|
bb5: ; preds = %bb
|
|
unreachable
|
|
|
|
bb6: ; preds = %bb
|
|
unreachable
|
|
|
|
bb7: ; preds = %bb
|
|
unreachable
|
|
|
|
bb8: ; preds = %bb
|
|
store i32 1, i32* %tmp, align 4
|
|
unreachable
|
|
}
|