mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-21 03:53:04 +02:00
13c5bb4a2e
Presently, CodeGenPrepare deletes all nearly empty (only phi and branch) basic blocks. This pass can delete loop preheaders which frequently creates critical edges. A preheader can be a convenient place to spill registers to the stack. If the entrance to a loop body is a critical edge, then spills may occur in the loop body rather than immediately before it. This patch protects loop preheaders from deletion in CodeGenPrepare even if they are nearly empty. Since the patch alters the CFG, it affects a large number of test cases. In most cases, the changes are merely cosmetic (basic blocks have different names or instruction orders change slightly). I am somewhat concerned about the test/CodeGen/Mips/brdelayslot.ll test case. If the loop preheader is not deleted, then the MIPS backend does not take advantage of a branch delay slot. Consequently, I would like some close review by a MIPS expert. The patch also partially subsumes D16893 from George Burgess IV. George correctly notes that CodeGenPrepare does not actually preserve the dominator tree. I think the dominator tree was usually not valid when CodeGenPrepare ran, but I am using LoopInfo to mark preheaders, so the dominator tree is now always valid before CodeGenPrepare. Author: Tom Jablin (tjablin) Reviewers: hfinkel george.burgess.iv vkalintiris dsanders kbarton cycheng http://reviews.llvm.org/D16984 llvm-svn: 265397
46 lines
1.5 KiB
LLVM
46 lines
1.5 KiB
LLVM
; RUN: llc -disable-preheader-prot=true -disable-machine-licm -machine-sink-bfi=true -mtriple=x86_64-apple-darwin < %s | FileCheck %s -check-prefix=MSINK_BFI
|
|
; RUN: llc -disable-preheader-prot=true -disable-machine-licm -machine-sink-bfi=false -mtriple=x86_64-apple-darwin < %s | FileCheck %s -check-prefix=MSINK_NOBFI
|
|
|
|
; Test that by changing BlockFrequencyInfo we change the order in which
|
|
; machine-sink looks for sucessor blocks. By not using BFI, both G and B
|
|
; have the same loop depth and no instructions is sinked - B is selected but
|
|
; can't be used as to avoid breaking a non profitable critical edge. By using
|
|
; BFI, "mul" is sinked into the less frequent block G.
|
|
define i32 @sink_freqinfo(i32 %a, i32 %b) nounwind uwtable ssp {
|
|
; MSINK_BFI-LABEL: sink_freqinfo
|
|
; MSINK_BFI: jl
|
|
; MSINK_BFI-NEXT: ## BB#
|
|
; MSINK_BFI-NEXT: imull
|
|
|
|
; MSINK_NOBFI-LABEL: sink_freqinfo
|
|
; MSINK_NOBFI: imull
|
|
; MSINK_NOBFI: jl
|
|
entry:
|
|
br label %B
|
|
|
|
B:
|
|
%ee = phi i32 [ 0, %entry ], [ %inc, %F ]
|
|
%xx = sub i32 %a, %ee
|
|
%cond0 = icmp slt i32 %xx, 0
|
|
br i1 %cond0, label %F, label %exit, !prof !0
|
|
|
|
F:
|
|
%inc = add nsw i32 %xx, 2
|
|
%aa = mul nsw i32 %b, %inc
|
|
%exitcond = icmp slt i32 %inc, %a
|
|
br i1 %exitcond, label %B, label %G, !prof !1
|
|
|
|
G:
|
|
%ii = add nsw i32 %aa, %a
|
|
%ll = add i32 %b, 45
|
|
%exitcond2 = icmp sge i32 %ii, %b
|
|
br i1 %exitcond2, label %G, label %exit, !prof !2
|
|
|
|
exit:
|
|
ret i32 0
|
|
}
|
|
|
|
!0 = !{!"branch_weights", i32 4, i32 1}
|
|
!1 = !{!"branch_weights", i32 128, i32 1}
|
|
!2 = !{!"branch_weights", i32 1, i32 1}
|