mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
5794a3620e
This is a followup to D98145: As far as I know, tracking of kill flags in FastISel is just a compile-time optimization. However, I'm not actually seeing any compile-time regression when removing the tracking. This probably used to be more important in the past, before FastRA was switched to allocate instructions in reverse order, which means that it discovers kills as a matter of course. As such, the kill tracking doesn't really seem to serve a purpose anymore, and just adds additional complexity and potential for errors. This patch removes it entirely. The primary changes are dropping the hasTrivialKill() method and removing the kill arguments from the emitFast methods. The rest is mechanical fixup. Differential Revision: https://reviews.llvm.org/D98294
44 lines
1.1 KiB
LLVM
44 lines
1.1 KiB
LLVM
; RUN: llc -O0 -fast-isel -fast-isel-abort=1 -verify-machineinstrs -mtriple=arm64-apple-darwin < %s | FileCheck %s
|
|
; RUN: llc %s -O0 -fast-isel -fast-isel-abort=1 -mtriple=arm64-apple-darwin -print-after=finalize-isel -o /dev/null 2> %t
|
|
; RUN: FileCheck %s < %t --check-prefix=CHECK-SSA
|
|
|
|
; CHECK-SSA-LABEL: Machine code for function t1
|
|
|
|
; CHECK-SSA: [[QUOTREG:%[0-9]+]]:gpr32 = SDIVWr
|
|
; CHECK-SSA-NOT: [[QUOTREG]] =
|
|
; CHECK-SSA: {{%[0-9]+}}:gpr32 = MSUBWrrr [[QUOTREG]]
|
|
|
|
; CHECK-SSA-LABEL: Machine code for function t2
|
|
|
|
define i32 @t1(i32 %a, i32 %b) {
|
|
; CHECK: @t1
|
|
; CHECK: sdiv [[TMP:w[0-9]+]], w0, w1
|
|
; CHECK: msub w0, [[TMP]], w1, w0
|
|
%1 = srem i32 %a, %b
|
|
ret i32 %1
|
|
}
|
|
|
|
define i64 @t2(i64 %a, i64 %b) {
|
|
; CHECK: @t2
|
|
; CHECK: sdiv [[TMP:x[0-9]+]], x0, x1
|
|
; CHECK: msub x0, [[TMP]], x1, x0
|
|
%1 = srem i64 %a, %b
|
|
ret i64 %1
|
|
}
|
|
|
|
define i32 @t3(i32 %a, i32 %b) {
|
|
; CHECK: @t3
|
|
; CHECK: udiv [[TMP:w[0-9]+]], w0, w1
|
|
; CHECK: msub w0, [[TMP]], w1, w0
|
|
%1 = urem i32 %a, %b
|
|
ret i32 %1
|
|
}
|
|
|
|
define i64 @t4(i64 %a, i64 %b) {
|
|
; CHECK: @t4
|
|
; CHECK: udiv [[TMP:x[0-9]+]], x0, x1
|
|
; CHECK: msub x0, [[TMP]], x1, x0
|
|
%1 = urem i64 %a, %b
|
|
ret i64 %1
|
|
}
|