mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-26 04:32:44 +01:00
7f7bfe12ea
Follow-up of D72172 and D72180
This patch passes `uint64_t Address` to print methods of PC-relative
operands so that subsequent target specific patches can change
`*InstPrinter::print{Operand,PCRelImm,...}` to customize the output.
Add MCInstPrinter::PrintBranchImmAsAddress which is set to true by
llvm-objdump.
```
// Current llvm-objdump -d output
aarch64: 20000: bl #0
ppc: 20000: bl .+4
x86: 20000: callq 0
// Ideal output
aarch64: 20000: bl 0x20000
ppc: 20000: bl 0x20004
x86: 20000: callq 0x20005
// GNU objdump -d. The lack of 0x is not ideal because the result cannot be re-assembled
aarch64: 20000: bl 20000
ppc: 20000: bl 0x20004
x86: 20000: callq 20005
```
In `lib/Target/X86/X86GenAsmWriter1.inc` (generated by `llvm-tblgen -gen-asm-writer`):
```
case 12:
// CALL64pcrel32, CALLpcrel16, CALLpcrel32, EH_SjLj_Setup, JCXZ, JECXZ, J...
- printPCRelImm(MI, 0, O);
+ printPCRelImm(MI, Address, 0, O);
return;
```
Some targets have 2 `printOperand` overloads, one without `Address` and
one with `Address`. They should annotate derived `Operand` properly with
`let OperandType = "OPERAND_PCREL"`.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D76574
44 lines
1.7 KiB
C++
44 lines
1.7 KiB
C++
//===-- X86InstPrinterCommon.cpp - X86 assembly instruction printing ------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file includes code common for rendering MCInst instances as AT&T-style
|
|
// and Intel-style assembly.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INSTPRINTERCOMMON_H
|
|
#define LLVM_LIB_TARGET_X86_MCTARGETDESC_X86INSTPRINTERCOMMON_H
|
|
|
|
#include "llvm/MC/MCInstPrinter.h"
|
|
|
|
namespace llvm {
|
|
|
|
class X86InstPrinterCommon : public MCInstPrinter {
|
|
public:
|
|
using MCInstPrinter::MCInstPrinter;
|
|
|
|
virtual void printOperand(const MCInst *MI, unsigned OpNo, raw_ostream &O) = 0;
|
|
void printCondCode(const MCInst *MI, unsigned Op, raw_ostream &OS);
|
|
void printSSEAVXCC(const MCInst *MI, unsigned Op, raw_ostream &OS);
|
|
void printVPCOMMnemonic(const MCInst *MI, raw_ostream &OS);
|
|
void printVPCMPMnemonic(const MCInst *MI, raw_ostream &OS);
|
|
void printCMPMnemonic(const MCInst *MI, bool IsVCmp, raw_ostream &OS);
|
|
void printRoundingControl(const MCInst *MI, unsigned Op, raw_ostream &O);
|
|
void printPCRelImm(const MCInst *MI, uint64_t Address, unsigned OpNo,
|
|
raw_ostream &O);
|
|
|
|
protected:
|
|
void printInstFlags(const MCInst *MI, raw_ostream &O);
|
|
void printOptionalSegReg(const MCInst *MI, unsigned OpNo, raw_ostream &O);
|
|
void printVKPair(const MCInst *MI, unsigned OpNo, raw_ostream &OS);
|
|
};
|
|
|
|
} // end namespace llvm
|
|
|
|
#endif // LLVM_LIB_TARGET_X86_MCTARGETDESC_X86ATTINSTPRINTER_H
|