mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-22 18:54:02 +01:00
2b0231f519
This replaces most argument uses with loads, but for now not all. The code in SelectionDAG for calling convention lowering is actively harmful for amdgpu_kernel. It attempts to split the argument types into register legal types, which results in low quality code for arbitary types. Since all kernel arguments are passed in memory, we just want the raw types. I've tried a couple of methods of mitigating this in SelectionDAG, but it's easier to just bypass this problem alltogether. It's possible to hack around the problem in the initial lowering, but the real problem is the DAG then expects to be able to use CopyToReg/CopyFromReg for uses of the arguments outside the block. Exposing the argument loads in the IR also has the advantage that the LoadStoreVectorizer can merge them. I'm not sure the best approach to dealing with the IR argument list is. The patch as-is just leaves the IR arguments in place, so all the existing code will still compute the same kernarg size and pointlessly lowers the arguments. Arguably the frontend should emit kernels with an empty argument list in the first place. Alternatively a dummy array could be inserted as a single argument just to reserve space. This does have some disadvantages. Local pointer kernel arguments can no longer have AssertZext placed on them as the equivalent !range metadata is not valid on pointer typed loads. This is mostly bad for SI which needs to know about the known bits in order to use the DS instruction offset, so in this case this is not done. More importantly, this skips noalias arguments since this pass does not yet convert this to the equivalent !alias.scope and !noalias metadata. Producing this metadata correctly seems to be tricky, although this logically is the same as inlining into a function which doesn't exist. Additionally, exposing these loads to the vectorizer may result in degraded aliasing information if a pointer load is merged with another argument load. I'm also not entirely sure this is preserving the current clover ABI, although I would greatly prefer if it would stop widening arguments and match the HSA ABI. As-is I think it is extending < 4-byte arguments to 4-bytes but doesn't align them to 4-bytes. llvm-svn: 335650
83 lines
3.1 KiB
LLVM
83 lines
3.1 KiB
LLVM
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=fiji -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
|
|
|
|
; Combine on select c, (load x), (load y) -> load (select c, x, y)
|
|
; drops MachinePointerInfo, so it can't be relied on for correctness.
|
|
|
|
; GCN-LABEL: {{^}}select_ptr_crash_i64_flat:
|
|
; GCN: s_load_dwordx2
|
|
; GCN: s_load_dwordx2
|
|
; GCN: s_load_dwordx2
|
|
|
|
; GCN: v_cmp_eq_u32
|
|
; GCN: v_cndmask_b32
|
|
; GCN: v_cndmask_b32
|
|
|
|
; GCN-NOT: load_dword
|
|
; GCN: flat_load_dwordx2
|
|
; GCN-NOT: load_dword
|
|
|
|
; GCN: flat_store_dwordx2
|
|
define amdgpu_kernel void @select_ptr_crash_i64_flat(i32 %tmp, [8 x i32], i64* %ptr0, [8 x i32], i64* %ptr1, [8 x i32], i64 addrspace(1)* %ptr2) {
|
|
%tmp2 = icmp eq i32 %tmp, 0
|
|
%tmp3 = load i64, i64* %ptr0, align 8
|
|
%tmp4 = load i64, i64* %ptr1, align 8
|
|
%tmp5 = select i1 %tmp2, i64 %tmp3, i64 %tmp4
|
|
store i64 %tmp5, i64 addrspace(1)* %ptr2, align 8
|
|
ret void
|
|
}
|
|
|
|
; The transform currently doesn't happen for non-addrspace 0, but it
|
|
; should.
|
|
|
|
; GCN-LABEL: {{^}}select_ptr_crash_i64_global:
|
|
; GCN: s_load_dwordx2
|
|
; GCN: s_load_dwordx2
|
|
; GCN: s_load_dwordx2
|
|
; GCN: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s{{\[[0-9]+:[0-9]+\]}}, 0x0{{$}}
|
|
; GCN: s_load_dwordx2 s{{\[[0-9]+:[0-9]+\]}}, s{{\[[0-9]+:[0-9]+\]}}, 0x0{{$}}
|
|
; GCN: v_cndmask_b32
|
|
; GCN: v_cndmask_b32
|
|
; GCN: flat_store_dwordx2
|
|
define amdgpu_kernel void @select_ptr_crash_i64_global(i32 %tmp, [8 x i32], i64 addrspace(1)* %ptr0, [8 x i32], i64 addrspace(1)* %ptr1, [8 x i32], i64 addrspace(1)* %ptr2) {
|
|
%tmp2 = icmp eq i32 %tmp, 0
|
|
%tmp3 = load i64, i64 addrspace(1)* %ptr0, align 8
|
|
%tmp4 = load i64, i64 addrspace(1)* %ptr1, align 8
|
|
%tmp5 = select i1 %tmp2, i64 %tmp3, i64 %tmp4
|
|
store i64 %tmp5, i64 addrspace(1)* %ptr2, align 8
|
|
ret void
|
|
}
|
|
|
|
; GCN-LABEL: {{^}}select_ptr_crash_i64_local:
|
|
; GCN: ds_read_b64
|
|
; GCN: ds_read_b64
|
|
; GCN: v_cndmask_b32
|
|
; GCN: v_cndmask_b32
|
|
; GCN: flat_store_dwordx2
|
|
define amdgpu_kernel void @select_ptr_crash_i64_local(i32 %tmp, i64 addrspace(3)* %ptr0, i64 addrspace(3)* %ptr1, i64 addrspace(1)* %ptr2) {
|
|
%tmp2 = icmp eq i32 %tmp, 0
|
|
%tmp3 = load i64, i64 addrspace(3)* %ptr0, align 8
|
|
%tmp4 = load i64, i64 addrspace(3)* %ptr1, align 8
|
|
%tmp5 = select i1 %tmp2, i64 %tmp3, i64 %tmp4
|
|
store i64 %tmp5, i64 addrspace(1)* %ptr2, align 8
|
|
ret void
|
|
}
|
|
|
|
; The transform will break addressing mode matching, so unclear it
|
|
; would be good to do
|
|
|
|
; GCN-LABEL: {{^}}select_ptr_crash_i64_local_offsets:
|
|
; GCN: ds_read_b64 {{v\[[0-9]+:[0-9]+\]}}, v{{[0-9]+}} offset:128
|
|
; GCN: ds_read_b64 {{v\[[0-9]+:[0-9]+\]}}, v{{[0-9]+}} offset:512
|
|
; GCN: v_cndmask_b32
|
|
; GCN: v_cndmask_b32
|
|
define amdgpu_kernel void @select_ptr_crash_i64_local_offsets(i32 %tmp, i64 addrspace(3)* %ptr0, i64 addrspace(3)* %ptr1, i64 addrspace(1)* %ptr2) {
|
|
%tmp2 = icmp eq i32 %tmp, 0
|
|
%gep0 = getelementptr inbounds i64, i64 addrspace(3)* %ptr0, i64 16
|
|
%gep1 = getelementptr inbounds i64, i64 addrspace(3)* %ptr1, i64 64
|
|
%tmp3 = load i64, i64 addrspace(3)* %gep0, align 8
|
|
%tmp4 = load i64, i64 addrspace(3)* %gep1, align 8
|
|
%tmp5 = select i1 %tmp2, i64 %tmp3, i64 %tmp4
|
|
store i64 %tmp5, i64 addrspace(1)* %ptr2, align 8
|
|
ret void
|
|
}
|