mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-11-25 20:23:11 +01:00
f53930f5f7
Summary: When handling exports from the command line or from .def files, the linker does a "fuzzy" string lookup to allow finding mangled symbols. However, when the symbol is re-exported under a new name, the linker has to transfer the decorations from the exported symbol over to the new name. This is implemented by taking the mangled symbol that was found in the object and replacing the original symbol name with the export name. Before this patch, LLD implemented the fuzzy search by adding an undefined symbol with the unmangled name, and then during symbol resolution, checking if similar mangled symbols had been added after the last round of symbol resolution. If so, LLD makes the original symbol a weak alias of the mangled symbol. Later, to get the original symbol name, LLD would look through the weak alias and forward it on to the import library writer, which copies the symbol decorations. This approach doesn't work when bar is itself a weak alias, as is the case in asan. It's especially bad when the aliasee of bar contains the string "bar", consider "bar_default". In this case, we would end up exporting the symbol "foo_default" when we should've exported just "foo". To fix this, don't look through weak aliases to find the mangled name. Save the mangled name earlier during fuzzy symbol lookup. Fixes PR42074 Reviewers: mstorsjo, ruiu Subscribers: thakis, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D62984 llvm-svn: 362849
114 lines
3.6 KiB
C++
114 lines
3.6 KiB
C++
//===- COFFImportFile.h - COFF short import file implementation -*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// COFF short import file is a special kind of file which contains
|
|
// only symbol names for DLL-exported symbols. This class implements
|
|
// exporting of Symbols to create libraries and a SymbolicFile
|
|
// interface for the file type.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLVM_OBJECT_COFF_IMPORT_FILE_H
|
|
#define LLVM_OBJECT_COFF_IMPORT_FILE_H
|
|
|
|
#include "llvm/ADT/ArrayRef.h"
|
|
#include "llvm/Object/COFF.h"
|
|
#include "llvm/Object/IRObjectFile.h"
|
|
#include "llvm/Object/ObjectFile.h"
|
|
#include "llvm/Object/SymbolicFile.h"
|
|
#include "llvm/Support/MemoryBuffer.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
namespace llvm {
|
|
namespace object {
|
|
|
|
class COFFImportFile : public SymbolicFile {
|
|
public:
|
|
COFFImportFile(MemoryBufferRef Source)
|
|
: SymbolicFile(ID_COFFImportFile, Source) {}
|
|
|
|
static bool classof(Binary const *V) { return V->isCOFFImportFile(); }
|
|
|
|
void moveSymbolNext(DataRefImpl &Symb) const override { ++Symb.p; }
|
|
|
|
Error printSymbolName(raw_ostream &OS, DataRefImpl Symb) const override {
|
|
if (Symb.p == 0)
|
|
OS << "__imp_";
|
|
OS << StringRef(Data.getBufferStart() + sizeof(coff_import_header));
|
|
return Error::success();
|
|
}
|
|
|
|
uint32_t getSymbolFlags(DataRefImpl Symb) const override {
|
|
return SymbolRef::SF_Global;
|
|
}
|
|
|
|
basic_symbol_iterator symbol_begin() const override {
|
|
return BasicSymbolRef(DataRefImpl(), this);
|
|
}
|
|
|
|
basic_symbol_iterator symbol_end() const override {
|
|
DataRefImpl Symb;
|
|
Symb.p = isData() ? 1 : 2;
|
|
return BasicSymbolRef(Symb, this);
|
|
}
|
|
|
|
const coff_import_header *getCOFFImportHeader() const {
|
|
return reinterpret_cast<const object::coff_import_header *>(
|
|
Data.getBufferStart());
|
|
}
|
|
|
|
private:
|
|
bool isData() const {
|
|
return getCOFFImportHeader()->getType() == COFF::IMPORT_DATA;
|
|
}
|
|
};
|
|
|
|
struct COFFShortExport {
|
|
/// The name of the export as specified in the .def file or on the command
|
|
/// line, i.e. "foo" in "/EXPORT:foo", and "bar" in "/EXPORT:foo=bar". This
|
|
/// may lack mangling, such as underscore prefixing and stdcall suffixing.
|
|
std::string Name;
|
|
|
|
/// The external, exported name. Only non-empty when export renaming is in
|
|
/// effect, i.e. "foo" in "/EXPORT:foo=bar".
|
|
std::string ExtName;
|
|
|
|
/// The real, mangled symbol name from the object file. Given
|
|
/// "/export:foo=bar", this could be "_bar@8" if bar is stdcall.
|
|
std::string SymbolName;
|
|
|
|
/// Creates a weak alias. This is the name of the weak aliasee. In a .def
|
|
/// file, this is "baz" in "EXPORTS\nfoo = bar == baz".
|
|
std::string AliasTarget;
|
|
|
|
uint16_t Ordinal = 0;
|
|
bool Noname = false;
|
|
bool Data = false;
|
|
bool Private = false;
|
|
bool Constant = false;
|
|
|
|
friend bool operator==(const COFFShortExport &L, const COFFShortExport &R) {
|
|
return L.Name == R.Name && L.ExtName == R.ExtName &&
|
|
L.Ordinal == R.Ordinal && L.Noname == R.Noname &&
|
|
L.Data == R.Data && L.Private == R.Private;
|
|
}
|
|
|
|
friend bool operator!=(const COFFShortExport &L, const COFFShortExport &R) {
|
|
return !(L == R);
|
|
}
|
|
};
|
|
|
|
Error writeImportLibrary(StringRef ImportName, StringRef Path,
|
|
ArrayRef<COFFShortExport> Exports,
|
|
COFF::MachineTypes Machine, bool MinGW);
|
|
|
|
} // namespace object
|
|
} // namespace llvm
|
|
|
|
#endif
|