mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-18 18:42:46 +02:00
b609feb61f
Commit 37962a331c77 ("bpf: Improve expanding logic in LowerSELECT_CC")
intended to improve code quality for certain jmp conditions. The
commit, however, has a couple of issues:
(1). In code, just swap is not enough, ConditionalCode CC
should also be swapped, otherwise incorrect code will
be generated.
(2). The ConditionalCode swap should be subject to
getHasJmpExt(). If getHasJmpExt() is False, certain
conditional codes will not be supported and swap
may generate incorrect code.
The original goal for this patch is to optimize jmp operations
which does not have JmpExt turned on. If JmpExt is on,
better code could be generated. For example, the test
select_ri.ll is introduced to demonstrate the optimization.
The same result can be achieved with -mcpu=v2 flag.
Signed-off-by: Yonghong Song <yhs@fb.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
llvm-svn: 329043
88 lines
1.9 KiB
LLVM
88 lines
1.9 KiB
LLVM
; RUN: llc < %s -march=bpf -mcpu=v2 -verify-machineinstrs | FileCheck %s
|
|
;
|
|
; Source file:
|
|
; int b, c;
|
|
; int test() {
|
|
; int a = b;
|
|
; if (a)
|
|
; a = c;
|
|
; return a;
|
|
; }
|
|
@b = common local_unnamed_addr global i32 0, align 4
|
|
@c = common local_unnamed_addr global i32 0, align 4
|
|
|
|
; Function Attrs: norecurse nounwind readonly
|
|
define i32 @test() local_unnamed_addr #0 {
|
|
entry:
|
|
%0 = load i32, i32* @b, align 4
|
|
%tobool = icmp eq i32 %0, 0
|
|
%1 = load i32, i32* @c, align 4
|
|
%. = select i1 %tobool, i32 0, i32 %1
|
|
; CHECK: r1 = b
|
|
; CHECK: r1 = *(u32 *)(r1 + 0)
|
|
; CHECK: if r1 == 0 goto
|
|
ret i32 %.
|
|
}
|
|
|
|
attributes #0 = { norecurse nounwind readonly }
|
|
|
|
; test immediate out of 32-bit range
|
|
; Source file:
|
|
|
|
; unsigned long long
|
|
; load_word(void *buf, unsigned long long off)
|
|
; asm("llvm.bpf.load.word");
|
|
;
|
|
; int
|
|
; foo(void *buf)
|
|
; {
|
|
; unsigned long long sum = 0;
|
|
;
|
|
; sum += load_word(buf, 100);
|
|
; sum += load_word(buf, 104);
|
|
;
|
|
; if (sum != 0x1ffffffffULL)
|
|
; return ~0U;
|
|
;
|
|
; return 0;
|
|
;}
|
|
|
|
; Function Attrs: nounwind readonly
|
|
define i32 @foo(i8*) local_unnamed_addr #0 {
|
|
%2 = tail call i64 @llvm.bpf.load.word(i8* %0, i64 100)
|
|
%3 = tail call i64 @llvm.bpf.load.word(i8* %0, i64 104)
|
|
%4 = add i64 %3, %2
|
|
%5 = icmp ne i64 %4, 8589934591
|
|
; CHECK: r{{[0-9]+}} = 8589934591 ll
|
|
%6 = sext i1 %5 to i32
|
|
ret i32 %6
|
|
}
|
|
|
|
; Function Attrs: nounwind readonly
|
|
declare i64 @llvm.bpf.load.word(i8*, i64) #1
|
|
|
|
; Source file:
|
|
; int m, n;
|
|
; int test2() {
|
|
; int a = m;
|
|
; if (a < 6)
|
|
; a = n;
|
|
; return a;
|
|
; }
|
|
|
|
@m = common local_unnamed_addr global i32 0, align 4
|
|
@n = common local_unnamed_addr global i32 0, align 4
|
|
|
|
; Function Attrs: norecurse nounwind readonly
|
|
define i32 @test2() local_unnamed_addr #0 {
|
|
entry:
|
|
%0 = load i32, i32* @m, align 4
|
|
%cmp = icmp slt i32 %0, 6
|
|
; CHECK: if r{{[0-9]+}} s{{<|>}} 6 goto
|
|
%1 = load i32, i32* @n, align 4
|
|
%spec.select = select i1 %cmp, i32 %1, i32 %0
|
|
ret i32 %spec.select
|
|
}
|
|
|
|
attributes #0 = { norecurse nounwind readonly }
|