mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-22 12:33:33 +02:00
aaf2db6c80
cmpxchg[8|16]b uses RBX as one of its argument. In other words, using this instruction clobbers RBX as it is defined to hold one the input. When the backend uses dynamically allocated stack, RBX is used as a reserved register for the base pointer. Reserved registers have special semantic that only the target understands and enforces, because of that, the register allocator don’t use them, but also, don’t try to make sure they are used properly (remember it does not know how they are supposed to be used). Therefore, when RBX is used as a reserved register but defined by something that is not compatible with that use, the register allocator will not fix the surrounding code to make sure it gets saved and restored properly around the broken code. This is the responsibility of the target to do the right thing with its reserved register. To fix that, when the base pointer needs to be preserved, we use a different pseudo instruction for cmpxchg that save rbx. That pseudo takes two more arguments than the regular instruction: - One is the value to be copied into RBX to set the proper value for the comparison. - The other is the virtual register holding the save of the value of RBX as the base pointer. This saving is done as part of isel (i.e., we emit a copy from rbx). cmpxchg_save_rbx <regular cmpxchg args>, input_for_rbx_reg, save_of_rbx_as_bp This gets expanded into: rbx = copy input_for_rbx_reg cmpxchg <regular cmpxchg args> rbx = save_of_rbx_as_bp Note: The actual modeling of the pseudo is a bit more complicated to make sure the interferes that appears after the pseudo gets expanded are properly modeled before that expansion. This fixes PR26883. llvm-svn: 263325
52 lines
2.7 KiB
LLVM
52 lines
2.7 KiB
LLVM
; RUN: llc -mtriple=x86_64-apple-macosx -mattr=+cx16 -x86-use-base-pointer=true -stackrealign -stack-alignment=32 %s -o - | FileCheck --check-prefix=CHECK --check-prefix=USE_BASE --check-prefix=USE_BASE_64 %s
|
|
; RUN: llc -mtriple=x86_64-apple-macosx -mattr=+cx16 -x86-use-base-pointer=false -stackrealign -stack-alignment=32 %s -o - | FileCheck --check-prefix=CHECK --check-prefix=DONT_USE_BASE %s
|
|
; RUN: llc -mtriple=x86_64-linux-gnux32 -mattr=+cx16 -x86-use-base-pointer=true -stackrealign -stack-alignment=32 %s -o - | FileCheck --check-prefix=CHECK --check-prefix=USE_BASE --check-prefix=USE_BASE_32 %s
|
|
; RUN: llc -mtriple=x86_64-linux-gnux32 -mattr=+cx16 -x86-use-base-pointer=false -stackrealign -stack-alignment=32 %s -o - | FileCheck --check-prefix=CHECK --check-prefix=DONT_USE_BASE %s
|
|
|
|
; This function uses dynamic allocated stack to force the use
|
|
; of a frame pointer.
|
|
; The inline asm clobbers a bunch of registers to make sure
|
|
; the frame pointer will need to be used (for spilling in that case).
|
|
;
|
|
; Then, we check that when we use rbx as the base pointer,
|
|
; we do not use cmpxchg, since using that instruction requires
|
|
; to clobbers rbx to set the arguments of the instruction and when
|
|
; rbx is used as the base pointer, RA cannot fix the code for us.
|
|
;
|
|
; CHECK-LABEL: cmp_and_swap16:
|
|
; Check that we actually use rbx.
|
|
; gnux32 use the 32bit variant of the registers.
|
|
; USE_BASE_64: movq %rsp, %rbx
|
|
; USE_BASE_32: movl %esp, %ebx
|
|
;
|
|
; Make sure the base pointer is saved before the RBX argument for
|
|
; cmpxchg16b is set.
|
|
;
|
|
; Because of how the test is written, we spill SAVE_RBX.
|
|
; However, it would have been perfectly fine to just keep it in register.
|
|
; USE_BASE: movq %rbx, [[SAVE_RBX_SLOT:[0-9]*\(%[er]bx\)]]
|
|
;
|
|
; SAVE_RBX must be in register before we clobber rbx.
|
|
; It is fine to use any register but rbx and the ones defined and use
|
|
; by cmpxchg. Since such regex would be complicated to write, just stick
|
|
; to the numbered registers. The bottom line is: if this test case fails
|
|
; because of that regex, this is likely just the regex being too conservative.
|
|
; USE_BASE: movq [[SAVE_RBX_SLOT]], [[SAVE_RBX:%r[0-9]+]]
|
|
;
|
|
; USE_BASE: movq {{[^ ]+}}, %rbx
|
|
; USE_BASE-NEXT: cmpxchg16b
|
|
; USE_BASE-NEXT: movq [[SAVE_RBX]], %rbx
|
|
;
|
|
; DONT_USE_BASE-NOT: movq %rsp, %rbx
|
|
; DONT_USE_BASE-NOT: movl %esp, %ebx
|
|
; DONT_USE_BASE: cmpxchg
|
|
define i1 @cmp_and_swap16(i128 %a, i128 %b, i128* %addr, i32 %n) {
|
|
%dummy = alloca i32, i32 %n
|
|
tail call void asm sideeffect "nop", "~{rax},~{rcx},~{rdx},~{rsi},~{rdi},~{rbp},~{r8},~{r9},~{r10},~{r11},~{r12},~{r13},~{r14},~{r15}"()
|
|
%cmp = cmpxchg i128* %addr, i128 %a, i128 %b seq_cst seq_cst
|
|
%res = extractvalue { i128, i1 } %cmp, 1
|
|
%idx = getelementptr i32, i32* %dummy, i32 5
|
|
store i32 %n, i32* %idx
|
|
ret i1 %res
|
|
}
|