mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-24 05:23:45 +02:00
2d3f6608fd
Summary: Hi Rafael, Would you be able to review this patch, please? (Clang part of the patch is D15832). When clang runs an external tool, e.g. a linker, it may create a command line that exceeds the length limit. Clang uses the llvm::sys::argumentsFitWithinSystemLimits function to check if command line length fits the OS limitation. There are two problems in this function that may cause exceeding of the limit: 1. It ignores the length of the program path in its calculations. On the other hand, clang adds the program path to the command line when it runs the program. 2. It assumes no space character is inserted after the last argument, which is not true for Windows. The flattenArgs function adds the trailing space for *each* argument. The result of this is that the terminating NULL character is not counted and may be placed beyond the length limit if the command line is exactly 32768 characters long. The WinAPI's CreateProcess does not find the NULL character and fails. Reviewers: rafael, ygao, probinson Subscribers: asl, llvm-commits Differential Revision: http://reviews.llvm.org/D15831 llvm-svn: 256866 |
||
---|---|---|
.. | ||
Unix | ||
Windows | ||
Allocator.cpp | ||
APFloat.cpp | ||
APInt.cpp | ||
APSInt.cpp | ||
ARMBuildAttrs.cpp | ||
ARMWinEH.cpp | ||
Atomic.cpp | ||
BlockFrequency.cpp | ||
BranchProbability.cpp | ||
circular_raw_ostream.cpp | ||
CMakeLists.txt | ||
COM.cpp | ||
CommandLine.cpp | ||
Compression.cpp | ||
ConvertUTF.c | ||
ConvertUTFWrapper.cpp | ||
COPYRIGHT.regex | ||
CrashRecoveryContext.cpp | ||
DAGDeltaAlgorithm.cpp | ||
DataExtractor.cpp | ||
DataStream.cpp | ||
Debug.cpp | ||
DeltaAlgorithm.cpp | ||
Dwarf.cpp | ||
DynamicLibrary.cpp | ||
Errno.cpp | ||
ErrorHandling.cpp | ||
FileOutputBuffer.cpp | ||
FileUtilities.cpp | ||
FoldingSet.cpp | ||
FormattedStream.cpp | ||
GraphWriter.cpp | ||
Hashing.cpp | ||
Host.cpp | ||
IntEqClasses.cpp | ||
IntervalMap.cpp | ||
IntrusiveRefCntPtr.cpp | ||
JamCRC.cpp | ||
LEB128.cpp | ||
LineIterator.cpp | ||
LLVMBuild.txt | ||
Locale.cpp | ||
LockFileManager.cpp | ||
Makefile | ||
ManagedStatic.cpp | ||
MathExtras.cpp | ||
MD5.cpp | ||
Memory.cpp | ||
MemoryBuffer.cpp | ||
MemoryObject.cpp | ||
Mutex.cpp | ||
Options.cpp | ||
Path.cpp | ||
PluginLoader.cpp | ||
PrettyStackTrace.cpp | ||
Process.cpp | ||
Program.cpp | ||
RandomNumberGenerator.cpp | ||
raw_os_ostream.cpp | ||
raw_ostream.cpp | ||
README.txt.system | ||
regcclass.h | ||
regcname.h | ||
regcomp.c | ||
regengine.inc | ||
regerror.c | ||
regex2.h | ||
regex_impl.h | ||
Regex.cpp | ||
regexec.c | ||
regfree.c | ||
regstrlcpy.c | ||
regutils.h | ||
RWMutex.cpp | ||
ScaledNumber.cpp | ||
SearchForAddressOfSpecialSymbol.cpp | ||
Signals.cpp | ||
SmallPtrSet.cpp | ||
SmallVector.cpp | ||
SourceMgr.cpp | ||
SpecialCaseList.cpp | ||
Statistic.cpp | ||
StreamingMemoryObject.cpp | ||
StringExtras.cpp | ||
StringMap.cpp | ||
StringPool.cpp | ||
StringRef.cpp | ||
StringSaver.cpp | ||
SystemUtils.cpp | ||
TargetParser.cpp | ||
TargetRegistry.cpp | ||
Threading.cpp | ||
ThreadLocal.cpp | ||
ThreadPool.cpp | ||
Timer.cpp | ||
TimeValue.cpp | ||
ToolOutputFile.cpp | ||
Triple.cpp | ||
Twine.cpp | ||
Unicode.cpp | ||
Valgrind.cpp | ||
Watchdog.cpp | ||
YAMLParser.cpp | ||
YAMLTraits.cpp |
Design Of lib/System ==================== The software in this directory is designed to completely shield LLVM from any and all operating system specific functionality. It is not intended to be a complete operating system wrapper (such as ACE), but only to provide the functionality necessary to support LLVM. The software located here, of necessity, has very specific and stringent design rules. Violation of these rules means that cracks in the shield could form and the primary goal of the library is defeated. By consistently using this library, LLVM becomes more easily ported to new platforms since the only thing requiring porting is this library. Complete documentation for the library can be found in the file: llvm/docs/SystemLibrary.html or at this URL: http://llvm.org/docs/SystemLibrary.html While we recommend that you read the more detailed documentation, for the impatient, here's a high level summary of the library's requirements. 1. No system header files are to be exposed through the interface. 2. Std C++ and Std C header files are okay to be exposed through the interface. 3. No exposed system-specific functions. 4. No exposed system-specific data. 5. Data in lib/System classes must use only simple C++ intrinsic types. 6. Errors are handled by returning "true" and setting an optional std::string 7. Library must not throw any exceptions, period. 8. Interface functions must not have throw() specifications. 9. No duplicate function impementations are permitted within an operating system class. To accomplish these requirements, the library has numerous design criteria that must be satisfied. Here's a high level summary of the library's design criteria: 1. No unused functionality (only what LLVM needs) 2. High-Level Interfaces 3. Use Opaque Classes 4. Common Implementations 5. Multiple Implementations 6. Minimize Memory Allocation 7. No Virtual Methods