Teresa Johnson ed6ec712ac [ThinLTO] Fix a crash in lazy loading of Metadata ... Summary: This is a revised version of D41474. When the debug location is parsed in BitcodeReader::parseFunction, the scope and inlinedAt MDNodes are obtained via MDLoader->getMDNodeFwdRefOrNull(), which will create a forward ref if they were not yet loaded. Specifically, if one of these MDNodes is in the module level metadata block, and this is during ThinLTO importing, that metadata block is lazily loaded. Most places in that invoke getMDNodeFwdRefOrNull have a corresponding call to resolveForwardRefsAndPlaceholders which will take care of resolving them. E.g. places that call getMetadataFwdRefOrLoad, or at the end of parsing a function-level metadata block, or at the end of the initial lazy load of module level metadata in order to handle invocations of getMDNodeFwdRefOrNull for named metadata and global object attachments. However, the calls for the scope/inlinedAt of debug locations are not backed by any such call to resolveForwardRefsAndPlaceholders. To fix this, change the scope and inlinedAt parsing to instead use getMetadataFwdRefOrLoad, which will ensure the forward refs to lazily loaded metadata are resolved. Fixes PR35472. Reviewers: dexonsmith, Sunil_Srivastava, vsk Subscribers: inglorion, eraman, steven_wu, sebpop, mehdi_amini, dmikulin, vsk, hiraditya, llvm-commits Differential Revision: https://reviews.llvm.org/D53596 llvm-svn: 345095		2018-10-23 22:57:21 +00:00
..
BitcodeReader.cpp	[ThinLTO] Fix a crash in lazy loading of Metadata	2018-10-23 22:57:21 +00:00
BitReader.cpp
BitstreamReader.cpp
CMakeLists.txt
LLVMBuild.txt
MetadataLoader.cpp	Emit template type and value parameter DIEs for template variables.	2018-10-03 18:44:53 +00:00
MetadataLoader.h	[NFC] Fix typo	2018-08-06 05:03:21 +00:00
ValueList.cpp	llvm::sort(C.begin(), C.end(), ...) -> llvm::sort(C, ...)	2018-09-27 02:13:45 +00:00
ValueList.h	[Bitcode] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes (NFC).	2017-09-07 23:28:24 +00:00