David Stenberg eea374d04e Allow null-valued function operands in getCalledFunction() ...

Summary:
Change the dynamic cast in CallBase::getCalledFunction() to allow
null-valued function operands.

This patch fixes a crash that occurred when a funtion operand of a
call instruction was dropped, and later on a metadata-carrying
instruction was printed out. When allocating the metadata slot numbers,
getCalledFunction() would be invoked on the call with the dropped
operand, resulting in a failed non-null assertion in isa<>.

This fixes PR38924, in which a printout in DBCE crashed due to this.

This aligns getCalledFunction() with getCalledValue(), as the latter
allows the operand to be null.

Reviewers: vsk, dexonsmith, hfinkel

Reviewed By: dexonsmith

Subscribers: hfinkel, llvm-commits

Differential Revision: https://reviews.llvm.org/D52537

llvm-svn: 345966

2018-11-02 11:46:24 +00:00

..

AsmWriterTest.cpp

[IR] Don't print "!DIExpression() = !DIExpression()" when dumping

2017-08-30 20:40:36 +00:00

AttributesTest.cpp

[Attributes] Fix a bug in AttributeList::get so it can handle a mix of FunctionIndex and ReturnIndex/arg indices at the same time

2018-04-16 17:05:01 +00:00

BasicBlockTest.cpp

[STLExtras] Add size() for ranges, and remove distance()

2018-05-16 23:20:42 +00:00

CFGBuilder.cpp

Rename DEBUG macro to LLVM_DEBUG.

2018-05-14 12:53:11 +00:00

CFGBuilder.h

[Dominators] Define Arc less-than operator inline.

2017-07-13 23:11:57 +00:00

CMakeLists.txt

[NewPM] teach -passes= to emit meaningful error messages

2018-10-17 10:36:23 +00:00

ConstantRangeTest.cpp

[ConstantRange] Add support of mul in makeGuaranteedNoWrapRegion.

2018-06-26 18:54:10 +00:00

ConstantsTest.cpp

Fix a bunch of places where operator-> was used directly on the return from dyn_cast.

2018-05-05 01:57:00 +00:00

DebugInfoTest.cpp

Formatting with clang-format patch r280700

2016-09-06 17:03:02 +00:00

DebugTypeODRUniquingTest.cpp

Add DWARF for discriminated unions

2018-02-06 23:45:59 +00:00

DominatorTreeBatchUpdatesTest.cpp

[DomTree] Cleanup Update and LegalizeUpdate API moved to Support header.

2018-08-14 17:12:30 +00:00

DominatorTreeTest.cpp

[TI removal] Make getTerminator() return a generic Instruction.

2018-10-15 10:42:50 +00:00

DomTreeUpdaterTest.cpp

[Dominators] Refine the logic of recalculate() in the DomTreeUpdater

2018-08-03 06:51:35 +00:00

FunctionTest.cpp

[GlobalObject] Fix setSection("")

2017-02-15 21:42:42 +00:00

InstructionsTest.cpp

[IR] add shuffle query for vector concatenation

2018-09-20 15:21:52 +00:00

IntrinsicsTest.cpp

Handle more edge cases in intrinsic name binary search

2016-01-26 22:33:19 +00:00

IRBuilderTest.cpp

[TI removal] Make getTerminator() return a generic Instruction.

2018-10-15 10:42:50 +00:00

LegacyPassManagerTest.cpp

allow custom OptBisect classes set to LLVMContext

2018-04-05 10:29:37 +00:00

ManglerTest.cpp

[IR] Avoid the need to prefix MS C++ symbols with '\01'

2018-03-16 20:13:32 +00:00

MDBuilderTest.cpp

…

MetadataTest.cpp

Allow null-valued function operands in getCalledFunction()

2018-11-02 11:46:24 +00:00

ModuleTest.cpp

Have Module::createRNG return a unique_ptr

2017-07-12 08:03:44 +00:00

PassBuilderCallbacksTest.cpp

[NewPM] teach -passes= to emit meaningful error messages

2018-10-17 10:36:23 +00:00

PassManagerTest.cpp

[New PM] Introducing PassInstrumentation framework

2018-09-20 17:08:45 +00:00

PatternMatch.cpp

[PatternMatch] Add m_Store pattern match helper

2018-06-20 07:27:45 +00:00

TypeBuilderTest.cpp

Suppress all uses of LLVM_END_WITH_NULL. NFC.

2017-05-09 19:31:13 +00:00

TypesTest.cpp

Fix several accidental DOS line endings in source files

2016-01-03 17:22:03 +00:00

UserTest.cpp

Re-sort #include lines for unittests. This uses a slightly modified

2017-06-06 11:06:56 +00:00

UseTest.cpp

Remove redundant includes from unittests.

2017-12-13 21:31:05 +00:00

ValueHandleTest.cpp

Add a new WeakVH value handle; NFC

2017-05-01 17:07:54 +00:00

ValueMapTest.cpp

s/LLVM_ON_WIN32/_WIN32/, llvm

2018-04-29 00:45:03 +00:00

ValueTest.cpp

[MIR] Making MIR Printing, opt -dot-cfg, and -debug printing faster

2018-03-22 21:29:07 +00:00

VerifierTest.cpp

Move the stripping of invalid debug info from the Verifier to AutoUpgrade.

2017-10-02 18:31:29 +00:00

WaymarkTest.cpp

Remove every uses of getGlobalContext() in LLVM (but the C API)

2016-04-14 21:59:01 +00:00