2017-09-29 00:27:31 +02:00
|
|
|
//===- HexagonPacketizer.cpp - VLIW packetizer ----------------------------===//
|
2012-05-03 23:52:53 +02:00
|
|
|
//
|
2019-01-19 09:50:56 +01:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
2012-05-03 23:52:53 +02:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
//
|
|
|
|
// This implements a simple VLIW packetizer using DFA. The packetizer works on
|
|
|
|
// machine basic blocks. For each instruction I in BB, the packetizer consults
|
|
|
|
// the DFA to see if machine resources are available to execute I. If so, the
|
|
|
|
// packetizer checks if I depends on any instruction J in the current packet.
|
|
|
|
// If no dependency is found, I is added to current packet and machine resource
|
|
|
|
// is marked as taken. If any dependency is found, a target API call is made to
|
|
|
|
// prune the dependence.
|
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
2017-09-29 00:27:31 +02:00
|
|
|
|
2017-06-06 13:49:48 +02:00
|
|
|
#include "HexagonVLIWPacketizer.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "Hexagon.h"
|
|
|
|
#include "HexagonInstrInfo.h"
|
2014-01-07 12:48:04 +01:00
|
|
|
#include "HexagonRegisterInfo.h"
|
|
|
|
#include "HexagonSubtarget.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "llvm/ADT/BitVector.h"
|
|
|
|
#include "llvm/ADT/DenseSet.h"
|
|
|
|
#include "llvm/ADT/STLExtras.h"
|
2019-09-09 15:17:55 +02:00
|
|
|
#include "llvm/ADT/StringExtras.h"
|
2015-12-16 20:36:12 +01:00
|
|
|
#include "llvm/Analysis/AliasAnalysis.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "llvm/CodeGen/MachineBasicBlock.h"
|
|
|
|
#include "llvm/CodeGen/MachineBranchProbabilityInfo.h"
|
2012-05-03 23:52:53 +02:00
|
|
|
#include "llvm/CodeGen/MachineDominators.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "llvm/CodeGen/MachineFrameInfo.h"
|
|
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
2012-05-03 23:52:53 +02:00
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
2017-12-13 03:51:04 +01:00
|
|
|
#include "llvm/CodeGen/MachineInstrBundle.h"
|
2012-05-03 23:52:53 +02:00
|
|
|
#include "llvm/CodeGen/MachineLoopInfo.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "llvm/CodeGen/MachineOperand.h"
|
|
|
|
#include "llvm/CodeGen/ScheduleDAG.h"
|
2017-11-17 02:07:10 +01:00
|
|
|
#include "llvm/CodeGen/TargetRegisterInfo.h"
|
|
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "llvm/IR/DebugLoc.h"
|
Sink all InitializePasses.h includes
This file lists every pass in LLVM, and is included by Pass.h, which is
very popular. Every time we add, remove, or rename a pass in LLVM, it
caused lots of recompilation.
I found this fact by looking at this table, which is sorted by the
number of times a file was changed over the last 100,000 git commits
multiplied by the number of object files that depend on it in the
current checkout:
recompiles touches affected_files header
342380 95 3604 llvm/include/llvm/ADT/STLExtras.h
314730 234 1345 llvm/include/llvm/InitializePasses.h
307036 118 2602 llvm/include/llvm/ADT/APInt.h
213049 59 3611 llvm/include/llvm/Support/MathExtras.h
170422 47 3626 llvm/include/llvm/Support/Compiler.h
162225 45 3605 llvm/include/llvm/ADT/Optional.h
158319 63 2513 llvm/include/llvm/ADT/Triple.h
140322 39 3598 llvm/include/llvm/ADT/StringRef.h
137647 59 2333 llvm/include/llvm/Support/Error.h
131619 73 1803 llvm/include/llvm/Support/FileSystem.h
Before this change, touching InitializePasses.h would cause 1345 files
to recompile. After this change, touching it only causes 550 compiles in
an incremental rebuild.
Reviewers: bkramer, asbirlea, bollu, jdoerfert
Differential Revision: https://reviews.llvm.org/D70211
2019-11-13 22:15:01 +01:00
|
|
|
#include "llvm/InitializePasses.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "llvm/MC/MCInstrDesc.h"
|
|
|
|
#include "llvm/Pass.h"
|
2013-03-01 18:37:13 +01:00
|
|
|
#include "llvm/Support/CommandLine.h"
|
2012-05-03 23:52:53 +02:00
|
|
|
#include "llvm/Support/Debug.h"
|
2017-09-29 00:27:31 +02:00
|
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
#include <cassert>
|
|
|
|
#include <cstdint>
|
|
|
|
#include <iterator>
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
using namespace llvm;
|
|
|
|
|
2014-04-22 04:41:26 +02:00
|
|
|
#define DEBUG_TYPE "packets"
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
static cl::opt<bool> DisablePacketizer("disable-packetizer", cl::Hidden,
|
|
|
|
cl::ZeroOrMore, cl::init(false),
|
|
|
|
cl::desc("Disable Hexagon packetizer pass"));
|
|
|
|
|
2019-08-23 21:59:23 +02:00
|
|
|
static cl::opt<bool> Slot1Store("slot1-store-slot0-load", cl::Hidden,
|
|
|
|
cl::ZeroOrMore, cl::init(true),
|
|
|
|
cl::desc("Allow slot1 store and slot0 load"));
|
2017-12-11 19:57:54 +01:00
|
|
|
|
2013-05-02 17:39:30 +02:00
|
|
|
static cl::opt<bool> PacketizeVolatiles("hexagon-packetize-volatiles",
|
2015-12-16 20:36:12 +01:00
|
|
|
cl::ZeroOrMore, cl::Hidden, cl::init(true),
|
|
|
|
cl::desc("Allow non-solo packetization of volatile memory references"));
|
|
|
|
|
|
|
|
static cl::opt<bool> EnableGenAllInsnClass("enable-gen-insn", cl::init(false),
|
|
|
|
cl::Hidden, cl::ZeroOrMore, cl::desc("Generate all instruction with TC"));
|
|
|
|
|
|
|
|
static cl::opt<bool> DisableVecDblNVStores("disable-vecdbl-nv-stores",
|
|
|
|
cl::init(false), cl::Hidden, cl::ZeroOrMore,
|
|
|
|
cl::desc("Disable vector double new-value-stores"));
|
|
|
|
|
|
|
|
extern cl::opt<bool> ScheduleInlineAsm;
|
2013-05-02 17:39:30 +02:00
|
|
|
|
|
|
|
namespace llvm {
|
|
|
|
|
2018-08-17 16:24:24 +02:00
|
|
|
FunctionPass *createHexagonPacketizer(bool Minimal);
|
2017-09-29 00:27:31 +02:00
|
|
|
void initializeHexagonPacketizerPass(PassRegistry&);
|
|
|
|
|
|
|
|
} // end namespace llvm
|
2013-05-02 17:39:30 +02:00
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
namespace {
|
2017-09-29 00:27:31 +02:00
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
class HexagonPacketizer : public MachineFunctionPass {
|
|
|
|
public:
|
|
|
|
static char ID;
|
2017-09-29 00:27:31 +02:00
|
|
|
|
2018-08-17 16:24:24 +02:00
|
|
|
HexagonPacketizer(bool Min = false)
|
|
|
|
: MachineFunctionPass(ID), Minimal(Min) {}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2014-04-29 09:58:16 +02:00
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
2012-05-03 23:52:53 +02:00
|
|
|
AU.setPreservesCFG();
|
2015-12-16 20:36:12 +01:00
|
|
|
AU.addRequired<AAResultsWrapperPass>();
|
2013-05-02 17:39:30 +02:00
|
|
|
AU.addRequired<MachineBranchProbabilityInfo>();
|
2015-12-16 20:36:12 +01:00
|
|
|
AU.addRequired<MachineDominatorTree>();
|
2012-05-03 23:52:53 +02:00
|
|
|
AU.addRequired<MachineLoopInfo>();
|
2015-12-16 20:36:12 +01:00
|
|
|
AU.addPreserved<MachineDominatorTree>();
|
2012-05-03 23:52:53 +02:00
|
|
|
AU.addPreserved<MachineLoopInfo>();
|
|
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
|
|
}
|
2017-09-29 00:27:31 +02:00
|
|
|
|
2016-10-01 04:56:57 +02:00
|
|
|
StringRef getPassName() const override { return "Hexagon Packetizer"; }
|
2014-04-29 09:58:16 +02:00
|
|
|
bool runOnMachineFunction(MachineFunction &Fn) override;
|
2017-09-29 00:27:31 +02:00
|
|
|
|
2016-04-04 19:09:25 +02:00
|
|
|
MachineFunctionProperties getRequiredProperties() const override {
|
|
|
|
return MachineFunctionProperties().set(
|
2016-08-25 03:27:13 +02:00
|
|
|
MachineFunctionProperties::Property::NoVRegs);
|
2016-04-04 19:09:25 +02:00
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
private:
|
2019-11-14 14:47:22 +01:00
|
|
|
const HexagonInstrInfo *HII = nullptr;
|
|
|
|
const HexagonRegisterInfo *HRI = nullptr;
|
|
|
|
const bool Minimal = false;
|
2012-05-03 23:52:53 +02:00
|
|
|
};
|
2015-12-16 20:36:12 +01:00
|
|
|
|
2017-09-29 00:27:31 +02:00
|
|
|
} // end anonymous namespace
|
|
|
|
|
|
|
|
char HexagonPacketizer::ID = 0;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2017-07-10 20:38:52 +02:00
|
|
|
INITIALIZE_PASS_BEGIN(HexagonPacketizer, "hexagon-packetizer",
|
|
|
|
"Hexagon Packetizer", false, false)
|
2013-05-02 17:39:30 +02:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(MachineDominatorTree)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(MachineBranchProbabilityInfo)
|
|
|
|
INITIALIZE_PASS_DEPENDENCY(MachineLoopInfo)
|
[PM/AA] Rebuild LLVM's alias analysis infrastructure in a way compatible
with the new pass manager, and no longer relying on analysis groups.
This builds essentially a ground-up new AA infrastructure stack for
LLVM. The core ideas are the same that are used throughout the new pass
manager: type erased polymorphism and direct composition. The design is
as follows:
- FunctionAAResults is a type-erasing alias analysis results aggregation
interface to walk a single query across a range of results from
different alias analyses. Currently this is function-specific as we
always assume that aliasing queries are *within* a function.
- AAResultBase is a CRTP utility providing stub implementations of
various parts of the alias analysis result concept, notably in several
cases in terms of other more general parts of the interface. This can
be used to implement only a narrow part of the interface rather than
the entire interface. This isn't really ideal, this logic should be
hoisted into FunctionAAResults as currently it will cause
a significant amount of redundant work, but it faithfully models the
behavior of the prior infrastructure.
- All the alias analysis passes are ported to be wrapper passes for the
legacy PM and new-style analysis passes for the new PM with a shared
result object. In some cases (most notably CFL), this is an extremely
naive approach that we should revisit when we can specialize for the
new pass manager.
- BasicAA has been restructured to reflect that it is much more
fundamentally a function analysis because it uses dominator trees and
loop info that need to be constructed for each function.
All of the references to getting alias analysis results have been
updated to use the new aggregation interface. All the preservation and
other pass management code has been updated accordingly.
The way the FunctionAAResultsWrapperPass works is to detect the
available alias analyses when run, and add them to the results object.
This means that we should be able to continue to respect when various
passes are added to the pipeline, for example adding CFL or adding TBAA
passes should just cause their results to be available and to get folded
into this. The exception to this rule is BasicAA which really needs to
be a function pass due to using dominator trees and loop info. As
a consequence, the FunctionAAResultsWrapperPass directly depends on
BasicAA and always includes it in the aggregation.
This has significant implications for preserving analyses. Generally,
most passes shouldn't bother preserving FunctionAAResultsWrapperPass
because rebuilding the results just updates the set of known AA passes.
The exception to this rule are LoopPass instances which need to preserve
all the function analyses that the loop pass manager will end up
needing. This means preserving both BasicAAWrapperPass and the
aggregating FunctionAAResultsWrapperPass.
Now, when preserving an alias analysis, you do so by directly preserving
that analysis. This is only necessary for non-immutable-pass-provided
alias analyses though, and there are only three of interest: BasicAA,
GlobalsAA (formerly GlobalsModRef), and SCEVAA. Usually BasicAA is
preserved when needed because it (like DominatorTree and LoopInfo) is
marked as a CFG-only pass. I've expanded GlobalsAA into the preserved
set everywhere we previously were preserving all of AliasAnalysis, and
I've added SCEVAA in the intersection of that with where we preserve
SCEV itself.
One significant challenge to all of this is that the CGSCC passes were
actually using the alias analysis implementations by taking advantage of
a pretty amazing set of loop holes in the old pass manager's analysis
management code which allowed analysis groups to slide through in many
cases. Moving away from analysis groups makes this problem much more
obvious. To fix it, I've leveraged the flexibility the design of the new
PM components provides to just directly construct the relevant alias
analyses for the relevant functions in the IPO passes that need them.
This is a bit hacky, but should go away with the new pass manager, and
is already in many ways cleaner than the prior state.
Another significant challenge is that various facilities of the old
alias analysis infrastructure just don't fit any more. The most
significant of these is the alias analysis 'counter' pass. That pass
relied on the ability to snoop on AA queries at different points in the
analysis group chain. Instead, I'm planning to build printing
functionality directly into the aggregation layer. I've not included
that in this patch merely to keep it smaller.
Note that all of this needs a nearly complete rewrite of the AA
documentation. I'm planning to do that, but I'd like to make sure the
new design settles, and to flesh out a bit more of what it looks like in
the new pass manager first.
Differential Revision: http://reviews.llvm.org/D12080
llvm-svn: 247167
2015-09-09 19:55:00 +02:00
|
|
|
INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass)
|
2017-07-10 20:38:52 +02:00
|
|
|
INITIALIZE_PASS_END(HexagonPacketizer, "hexagon-packetizer",
|
|
|
|
"Hexagon Packetizer", false, false)
|
2013-05-02 17:39:30 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
HexagonPacketizerList::HexagonPacketizerList(MachineFunction &MF,
|
2019-10-19 02:22:07 +02:00
|
|
|
MachineLoopInfo &MLI, AAResults *AA,
|
2018-08-17 16:24:24 +02:00
|
|
|
const MachineBranchProbabilityInfo *MBPI, bool Minimal)
|
|
|
|
: VLIWPacketizerList(MF, MLI, AA), MBPI(MBPI), MLI(&MLI),
|
|
|
|
Minimal(Minimal) {
|
2015-12-16 20:36:12 +01:00
|
|
|
HII = MF.getSubtarget<HexagonSubtarget>().getInstrInfo();
|
|
|
|
HRI = MF.getSubtarget<HexagonSubtarget>().getRegisterInfo();
|
2016-07-15 19:48:09 +02:00
|
|
|
|
2019-08-15 17:54:37 +02:00
|
|
|
addMutation(std::make_unique<HexagonSubtarget::UsrOverflowMutation>());
|
|
|
|
addMutation(std::make_unique<HexagonSubtarget::HVXMemLatencyMutation>());
|
|
|
|
addMutation(std::make_unique<HexagonSubtarget::BankConflictMutation>());
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Check if FirstI modifies a register that SecondI reads.
|
2016-07-12 03:55:32 +02:00
|
|
|
static bool hasWriteToReadDep(const MachineInstr &FirstI,
|
|
|
|
const MachineInstr &SecondI,
|
|
|
|
const TargetRegisterInfo *TRI) {
|
|
|
|
for (auto &MO : FirstI.operands()) {
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!MO.isReg() || !MO.isDef())
|
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register R = MO.getReg();
|
2016-07-12 03:55:32 +02:00
|
|
|
if (SecondI.readsRegister(R, TRI))
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
static MachineBasicBlock::iterator moveInstrOut(MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
MachineBasicBlock::iterator BundleIt, bool Before) {
|
|
|
|
MachineBasicBlock::instr_iterator InsertPt;
|
|
|
|
if (Before)
|
2016-02-22 22:30:15 +01:00
|
|
|
InsertPt = BundleIt.getInstrIterator();
|
2015-12-16 20:36:12 +01:00
|
|
|
else
|
2016-02-22 22:30:15 +01:00
|
|
|
InsertPt = std::next(BundleIt).getInstrIterator();
|
2015-12-16 20:36:12 +01:00
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineBasicBlock &B = *MI.getParent();
|
2015-12-16 20:36:12 +01:00
|
|
|
// The instruction should at least be bundled with the preceding instruction
|
|
|
|
// (there will always be one, i.e. BUNDLE, if nothing else).
|
2016-07-29 23:49:42 +02:00
|
|
|
assert(MI.isBundledWithPred());
|
|
|
|
if (MI.isBundledWithSucc()) {
|
|
|
|
MI.clearFlag(MachineInstr::BundledSucc);
|
|
|
|
MI.clearFlag(MachineInstr::BundledPred);
|
2015-12-16 20:36:12 +01:00
|
|
|
} else {
|
|
|
|
// If it's not bundled with the successor (i.e. it is the last one
|
|
|
|
// in the bundle), then we can simply unbundle it from the predecessor,
|
|
|
|
// which will take care of updating the predecessor's flag.
|
2016-07-29 23:49:42 +02:00
|
|
|
MI.unbundleFromPred();
|
2015-12-16 20:36:12 +01:00
|
|
|
}
|
2016-07-29 23:49:42 +02:00
|
|
|
B.splice(InsertPt, &B, MI.getIterator());
|
2015-12-16 20:36:12 +01:00
|
|
|
|
|
|
|
// Get the size of the bundle without asserting.
|
2016-07-12 03:55:32 +02:00
|
|
|
MachineBasicBlock::const_instr_iterator I = BundleIt.getInstrIterator();
|
2015-12-16 20:36:12 +01:00
|
|
|
MachineBasicBlock::const_instr_iterator E = B.instr_end();
|
|
|
|
unsigned Size = 0;
|
|
|
|
for (++I; I != E && I->isBundledWithPred(); ++I)
|
|
|
|
++Size;
|
|
|
|
|
|
|
|
// If there are still two or more instructions, then there is nothing
|
|
|
|
// else to be done.
|
|
|
|
if (Size > 1)
|
|
|
|
return BundleIt;
|
|
|
|
|
|
|
|
// Otherwise, extract the single instruction out and delete the bundle.
|
|
|
|
MachineBasicBlock::iterator NextIt = std::next(BundleIt);
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineInstr &SingleI = *BundleIt->getNextNode();
|
|
|
|
SingleI.unbundleFromPred();
|
|
|
|
assert(!SingleI.isBundledWithSucc());
|
2015-12-16 20:36:12 +01:00
|
|
|
BundleIt->eraseFromParent();
|
|
|
|
return NextIt;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool HexagonPacketizer::runOnMachineFunction(MachineFunction &MF) {
|
2018-03-12 18:47:46 +01:00
|
|
|
auto &HST = MF.getSubtarget<HexagonSubtarget>();
|
|
|
|
HII = HST.getInstrInfo();
|
|
|
|
HRI = HST.getRegisterInfo();
|
2015-12-16 20:36:12 +01:00
|
|
|
auto &MLI = getAnalysis<MachineLoopInfo>();
|
|
|
|
auto *AA = &getAnalysis<AAResultsWrapperPass>().getAAResults();
|
|
|
|
auto *MBPI = &getAnalysis<MachineBranchProbabilityInfo>();
|
|
|
|
|
|
|
|
if (EnableGenAllInsnClass)
|
|
|
|
HII->genAllInsnTimingClasses(MF);
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
// Instantiate the packetizer.
|
2018-08-17 16:24:24 +02:00
|
|
|
bool MinOnly = Minimal || DisablePacketizer || !HST.usePackets() ||
|
|
|
|
skipFunction(MF.getFunction());
|
|
|
|
HexagonPacketizerList Packetizer(MF, MLI, AA, MBPI, MinOnly);
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
// DFA state table should not be empty.
|
|
|
|
assert(Packetizer.getResourceTracker() && "Empty DFA table!");
|
|
|
|
|
|
|
|
// Loop over all basic blocks and remove KILL pseudo-instructions
|
|
|
|
// These instructions confuse the dependence analysis. Consider:
|
|
|
|
// D0 = ... (Insn 0)
|
|
|
|
// R0 = KILL R0, D0 (Insn 1)
|
|
|
|
// R0 = ... (Insn 2)
|
|
|
|
// Here, Insn 1 will result in the dependence graph not emitting an output
|
|
|
|
// dependence between Insn 0 and Insn 2. This can lead to incorrect
|
|
|
|
// packetization
|
2018-08-17 16:24:24 +02:00
|
|
|
for (MachineBasicBlock &MB : MF) {
|
2015-12-16 20:36:12 +01:00
|
|
|
auto End = MB.end();
|
|
|
|
auto MI = MB.begin();
|
2012-05-03 23:52:53 +02:00
|
|
|
while (MI != End) {
|
2015-12-16 20:36:12 +01:00
|
|
|
auto NextI = std::next(MI);
|
2012-05-03 23:52:53 +02:00
|
|
|
if (MI->isKill()) {
|
2015-12-16 20:36:12 +01:00
|
|
|
MB.erase(MI);
|
|
|
|
End = MB.end();
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
MI = NextI;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-01-13 23:07:30 +01:00
|
|
|
// TinyCore with Duplexes: Translate to big-instructions.
|
|
|
|
if (HST.isTinyCoreWithDuplex())
|
|
|
|
HII->translateInstrsForDup(MF, true);
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
// Loop over all of the basic blocks.
|
2015-12-16 20:36:12 +01:00
|
|
|
for (auto &MB : MF) {
|
|
|
|
auto Begin = MB.begin(), End = MB.end();
|
|
|
|
while (Begin != End) {
|
2017-05-24 15:43:42 +02:00
|
|
|
// Find the first non-boundary starting from the end of the last
|
2015-12-16 20:36:12 +01:00
|
|
|
// scheduling region.
|
|
|
|
MachineBasicBlock::iterator RB = Begin;
|
2016-06-30 02:01:54 +02:00
|
|
|
while (RB != End && HII->isSchedulingBoundary(*RB, &MB, MF))
|
2015-12-16 20:36:12 +01:00
|
|
|
++RB;
|
2017-05-24 15:43:42 +02:00
|
|
|
// Find the first boundary starting from the beginning of the new
|
2015-12-16 20:36:12 +01:00
|
|
|
// region.
|
|
|
|
MachineBasicBlock::iterator RE = RB;
|
2016-06-30 02:01:54 +02:00
|
|
|
while (RE != End && !HII->isSchedulingBoundary(*RE, &MB, MF))
|
2015-12-16 20:36:12 +01:00
|
|
|
++RE;
|
|
|
|
// Add the scheduling boundary if it's not block end.
|
|
|
|
if (RE != End)
|
|
|
|
++RE;
|
|
|
|
// If RB == End, then RE == End.
|
|
|
|
if (RB != End)
|
|
|
|
Packetizer.PacketizeMIs(&MB, RB, RE);
|
|
|
|
|
|
|
|
Begin = RE;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-01-13 23:07:30 +01:00
|
|
|
// TinyCore with Duplexes: Translate to tiny-instructions.
|
|
|
|
if (HST.isTinyCoreWithDuplex())
|
|
|
|
HII->translateInstrsForDup(MF, false);
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
Packetizer.unpacketizeSoloInstrs(MF);
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Reserve resources for a constant extender. Trigger an assertion if the
|
|
|
|
// reservation fails.
|
|
|
|
void HexagonPacketizerList::reserveResourcesForConstExt() {
|
|
|
|
if (!tryAllocateResourcesForConstExt(true))
|
|
|
|
llvm_unreachable("Resources not available");
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
bool HexagonPacketizerList::canReserveResourcesForConstExt() {
|
|
|
|
return tryAllocateResourcesForConstExt(false);
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Allocate resources (i.e. 4 bytes) for constant extender. If succeeded,
|
|
|
|
// return true, otherwise, return false.
|
|
|
|
bool HexagonPacketizerList::tryAllocateResourcesForConstExt(bool Reserve) {
|
|
|
|
auto *ExtMI = MF.CreateMachineInstr(HII->get(Hexagon::A4_ext), DebugLoc());
|
2016-02-27 20:09:00 +01:00
|
|
|
bool Avail = ResourceTracker->canReserveResources(*ExtMI);
|
2015-12-16 20:36:12 +01:00
|
|
|
if (Reserve && Avail)
|
2016-02-27 20:09:00 +01:00
|
|
|
ResourceTracker->reserveResources(*ExtMI);
|
2015-12-16 20:36:12 +01:00
|
|
|
MF.DeleteMachineInstr(ExtMI);
|
|
|
|
return Avail;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::isCallDependent(const MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
SDep::Kind DepType, unsigned DepReg) {
|
|
|
|
// Check for LR dependence.
|
|
|
|
if (DepReg == HRI->getRARegister())
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
if (HII->isDeallocRet(MI))
|
|
|
|
if (DepReg == HRI->getFrameRegister() || DepReg == HRI->getStackRegister())
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
|
2017-06-01 20:02:40 +02:00
|
|
|
// Call-like instructions can be packetized with preceding instructions
|
|
|
|
// that define registers implicitly used or modified by the call. Explicit
|
|
|
|
// uses are still prohibited, as in the case of indirect calls:
|
|
|
|
// r0 = ...
|
|
|
|
// J2_jumpr r0
|
|
|
|
if (DepType == SDep::Data) {
|
2019-12-22 19:35:02 +01:00
|
|
|
for (const MachineOperand &MO : MI.operands())
|
2017-06-01 20:02:40 +02:00
|
|
|
if (MO.isReg() && MO.getReg() == DepReg && !MO.isImplicit())
|
|
|
|
return true;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
static bool isRegDependence(const SDep::Kind DepType) {
|
|
|
|
return DepType == SDep::Data || DepType == SDep::Anti ||
|
|
|
|
DepType == SDep::Output;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
static bool isDirectJump(const MachineInstr &MI) {
|
|
|
|
return MI.getOpcode() == Hexagon::J2_jump;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
static bool isSchedBarrier(const MachineInstr &MI) {
|
|
|
|
switch (MI.getOpcode()) {
|
2015-02-05 19:56:28 +01:00
|
|
|
case Hexagon::Y2_barrier:
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
static bool isControlFlow(const MachineInstr &MI) {
|
|
|
|
return MI.getDesc().isTerminator() || MI.getDesc().isCall();
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
/// Returns true if the instruction modifies a callee-saved register.
|
2016-07-29 23:49:42 +02:00
|
|
|
static bool doesModifyCalleeSavedReg(const MachineInstr &MI,
|
2012-05-03 23:52:53 +02:00
|
|
|
const TargetRegisterInfo *TRI) {
|
2016-07-29 23:49:42 +02:00
|
|
|
const MachineFunction &MF = *MI.getParent()->getParent();
|
2015-12-16 20:36:12 +01:00
|
|
|
for (auto *CSR = TRI->getCalleeSavedRegs(&MF); CSR && *CSR; ++CSR)
|
2016-07-29 23:49:42 +02:00
|
|
|
if (MI.modifiesRegister(*CSR, TRI))
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Returns true if an instruction can be promoted to .new predicate or
|
|
|
|
// new-value store.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::isNewifiable(const MachineInstr &MI,
|
2016-07-26 22:30:30 +02:00
|
|
|
const TargetRegisterClass *NewRC) {
|
|
|
|
// Vector stores can be predicated, and can be new-value stores, but
|
|
|
|
// they cannot be predicated on a .new predicate value.
|
2017-06-01 20:02:40 +02:00
|
|
|
if (NewRC == &Hexagon::PredRegsRegClass) {
|
2017-05-03 22:10:36 +02:00
|
|
|
if (HII->isHVXVec(MI) && MI.mayStore())
|
2016-07-26 22:30:30 +02:00
|
|
|
return false;
|
2017-06-01 20:02:40 +02:00
|
|
|
return HII->isPredicated(MI) && HII->getDotNewPredOp(MI, nullptr) > 0;
|
|
|
|
}
|
|
|
|
// If the class is not PredRegs, it could only apply to new-value stores.
|
|
|
|
return HII->mayBeNewStore(MI);
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Promote an instructiont to its .cur form.
|
|
|
|
// At this time, we have already made a call to canPromoteToDotCur and made
|
|
|
|
// sure that it can *indeed* be promoted.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::promoteToDotCur(MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
SDep::Kind DepType, MachineBasicBlock::iterator &MII,
|
|
|
|
const TargetRegisterClass* RC) {
|
|
|
|
assert(DepType == SDep::Data);
|
|
|
|
int CurOpcode = HII->getDotCurOp(MI);
|
2016-07-29 23:49:42 +02:00
|
|
|
MI.setDesc(HII->get(CurOpcode));
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
void HexagonPacketizerList::cleanUpDotCur() {
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineInstr *MI = nullptr;
|
2015-12-16 20:36:12 +01:00
|
|
|
for (auto BI : CurrentPacketMIs) {
|
2018-05-14 14:53:11 +02:00
|
|
|
LLVM_DEBUG(dbgs() << "Cleanup packet has "; BI->dump(););
|
2017-05-03 17:28:56 +02:00
|
|
|
if (HII->isDotCurInst(*BI)) {
|
2015-12-16 20:36:12 +01:00
|
|
|
MI = BI;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (MI) {
|
|
|
|
for (auto &MO : BI->operands())
|
|
|
|
if (MO.isReg() && MO.getReg() == MI->getOperand(0).getReg())
|
|
|
|
return;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!MI)
|
|
|
|
return;
|
|
|
|
// We did not find a use of the CUR, so de-cur it.
|
2017-05-03 17:28:56 +02:00
|
|
|
MI->setDesc(HII->get(HII->getNonDotCurOp(*MI)));
|
2018-05-14 14:53:11 +02:00
|
|
|
LLVM_DEBUG(dbgs() << "Demoted CUR "; MI->dump(););
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Check to see if an instruction can be dot cur.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::canPromoteToDotCur(const MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
const SUnit *PacketSU, unsigned DepReg, MachineBasicBlock::iterator &MII,
|
|
|
|
const TargetRegisterClass *RC) {
|
2017-05-03 22:10:36 +02:00
|
|
|
if (!HII->isHVXVec(MI))
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
2017-05-03 22:10:36 +02:00
|
|
|
if (!HII->isHVXVec(*MII))
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
2012-05-14 21:35:42 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Already a dot new instruction.
|
|
|
|
if (HII->isDotCurInst(MI) && !HII->mayBeCurLoad(MI))
|
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!HII->mayBeCurLoad(MI))
|
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// The "cur value" cannot come from inline asm.
|
|
|
|
if (PacketSU->getInstr()->isInlineAsm())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Make sure candidate instruction uses cur.
|
2018-05-14 14:53:11 +02:00
|
|
|
LLVM_DEBUG(dbgs() << "Can we DOT Cur Vector MI\n"; MI.dump();
|
|
|
|
dbgs() << "in packet\n";);
|
2016-07-12 03:55:32 +02:00
|
|
|
MachineInstr &MJ = *MII;
|
2018-05-14 14:53:11 +02:00
|
|
|
LLVM_DEBUG({
|
2016-07-12 03:55:32 +02:00
|
|
|
dbgs() << "Checking CUR against ";
|
|
|
|
MJ.dump();
|
|
|
|
});
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register DestReg = MI.getOperand(0).getReg();
|
2015-12-16 20:36:12 +01:00
|
|
|
bool FoundMatch = false;
|
2016-07-12 03:55:32 +02:00
|
|
|
for (auto &MO : MJ.operands())
|
2015-12-16 20:36:12 +01:00
|
|
|
if (MO.isReg() && MO.getReg() == DestReg)
|
|
|
|
FoundMatch = true;
|
|
|
|
if (!FoundMatch)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Check for existing uses of a vector register within the packet which
|
|
|
|
// would be affected by converting a vector load into .cur formt.
|
|
|
|
for (auto BI : CurrentPacketMIs) {
|
2018-05-14 14:53:11 +02:00
|
|
|
LLVM_DEBUG(dbgs() << "packet has "; BI->dump(););
|
2015-12-16 20:36:12 +01:00
|
|
|
if (BI->readsRegister(DepReg, MF.getSubtarget().getRegisterInfo()))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-05-14 14:53:11 +02:00
|
|
|
LLVM_DEBUG(dbgs() << "Can Dot CUR MI\n"; MI.dump(););
|
2015-12-16 20:36:12 +01:00
|
|
|
// We can convert the opcode into a .cur.
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Promote an instruction to its .new form. At this time, we have already
|
|
|
|
// made a call to canPromoteToDotNew and made sure that it can *indeed* be
|
|
|
|
// promoted.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::promoteToDotNew(MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
SDep::Kind DepType, MachineBasicBlock::iterator &MII,
|
|
|
|
const TargetRegisterClass* RC) {
|
2017-09-29 00:27:31 +02:00
|
|
|
assert(DepType == SDep::Data);
|
2012-05-03 23:52:53 +02:00
|
|
|
int NewOpcode;
|
|
|
|
if (RC == &Hexagon::PredRegsRegClass)
|
2015-12-16 20:36:12 +01:00
|
|
|
NewOpcode = HII->getDotNewPredOp(MI, MBPI);
|
2012-05-03 23:52:53 +02:00
|
|
|
else
|
2015-12-16 20:36:12 +01:00
|
|
|
NewOpcode = HII->getDotNewOp(MI);
|
2016-07-29 23:49:42 +02:00
|
|
|
MI.setDesc(HII->get(NewOpcode));
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::demoteToDotOld(MachineInstr &MI) {
|
2017-03-06 18:03:16 +01:00
|
|
|
int NewOpcode = HII->getDotOldOp(MI);
|
2016-07-29 23:49:42 +02:00
|
|
|
MI.setDesc(HII->get(NewOpcode));
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::useCallersSP(MachineInstr &MI) {
|
|
|
|
unsigned Opc = MI.getOpcode();
|
2016-07-26 16:24:46 +02:00
|
|
|
switch (Opc) {
|
|
|
|
case Hexagon::S2_storerd_io:
|
|
|
|
case Hexagon::S2_storeri_io:
|
|
|
|
case Hexagon::S2_storerh_io:
|
|
|
|
case Hexagon::S2_storerb_io:
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
llvm_unreachable("Unexpected instruction");
|
|
|
|
}
|
2016-07-28 20:40:00 +02:00
|
|
|
unsigned FrameSize = MF.getFrameInfo().getStackSize();
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineOperand &Off = MI.getOperand(1);
|
2016-07-26 16:24:46 +02:00
|
|
|
int64_t NewOff = Off.getImm() - (FrameSize + HEXAGON_LRFP_SIZE);
|
2017-09-15 17:46:05 +02:00
|
|
|
if (HII->isValidOffset(Opc, NewOff, HRI)) {
|
2016-07-26 16:24:46 +02:00
|
|
|
Off.setImm(NewOff);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
void HexagonPacketizerList::useCalleesSP(MachineInstr &MI) {
|
|
|
|
unsigned Opc = MI.getOpcode();
|
2016-07-26 16:24:46 +02:00
|
|
|
switch (Opc) {
|
|
|
|
case Hexagon::S2_storerd_io:
|
|
|
|
case Hexagon::S2_storeri_io:
|
|
|
|
case Hexagon::S2_storerh_io:
|
|
|
|
case Hexagon::S2_storerb_io:
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
llvm_unreachable("Unexpected instruction");
|
|
|
|
}
|
2016-07-28 20:40:00 +02:00
|
|
|
unsigned FrameSize = MF.getFrameInfo().getStackSize();
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineOperand &Off = MI.getOperand(1);
|
2016-07-26 16:24:46 +02:00
|
|
|
Off.setImm(Off.getImm() + FrameSize + HEXAGON_LRFP_SIZE);
|
|
|
|
}
|
|
|
|
|
2017-10-11 17:51:44 +02:00
|
|
|
/// Return true if we can update the offset in MI so that MI and MJ
|
|
|
|
/// can be packetized together.
|
|
|
|
bool HexagonPacketizerList::updateOffset(SUnit *SUI, SUnit *SUJ) {
|
|
|
|
assert(SUI->getInstr() && SUJ->getInstr());
|
|
|
|
MachineInstr &MI = *SUI->getInstr();
|
|
|
|
MachineInstr &MJ = *SUJ->getInstr();
|
|
|
|
|
|
|
|
unsigned BPI, OPI;
|
|
|
|
if (!HII->getBaseAndOffsetPosition(MI, BPI, OPI))
|
|
|
|
return false;
|
|
|
|
unsigned BPJ, OPJ;
|
|
|
|
if (!HII->getBaseAndOffsetPosition(MJ, BPJ, OPJ))
|
|
|
|
return false;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register Reg = MI.getOperand(BPI).getReg();
|
2017-10-11 17:51:44 +02:00
|
|
|
if (Reg != MJ.getOperand(BPJ).getReg())
|
|
|
|
return false;
|
|
|
|
// Make sure that the dependences do not restrict adding MI to the packet.
|
|
|
|
// That is, ignore anti dependences, and make sure the only data dependence
|
|
|
|
// involves the specific register.
|
|
|
|
for (const auto &PI : SUI->Preds)
|
|
|
|
if (PI.getKind() != SDep::Anti &&
|
|
|
|
(PI.getKind() != SDep::Data || PI.getReg() != Reg))
|
|
|
|
return false;
|
|
|
|
int Incr;
|
|
|
|
if (!HII->getIncrementValue(MJ, Incr))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
int64_t Offset = MI.getOperand(OPI).getImm();
|
2018-03-30 21:28:37 +02:00
|
|
|
if (!HII->isValidOffset(MI.getOpcode(), Offset+Incr, HRI))
|
|
|
|
return false;
|
|
|
|
|
2017-10-11 17:51:44 +02:00
|
|
|
MI.getOperand(OPI).setImm(Offset + Incr);
|
|
|
|
ChangedOffset = Offset;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Undo the changed offset. This is needed if the instruction cannot be
|
|
|
|
/// added to the current packet due to a different instruction.
|
|
|
|
void HexagonPacketizerList::undoChangedOffset(MachineInstr &MI) {
|
|
|
|
unsigned BP, OP;
|
|
|
|
if (!HII->getBaseAndOffsetPosition(MI, BP, OP))
|
|
|
|
llvm_unreachable("Unable to find base and offset operands.");
|
|
|
|
MI.getOperand(OP).setImm(ChangedOffset);
|
|
|
|
}
|
|
|
|
|
2013-05-10 22:27:34 +02:00
|
|
|
enum PredicateKind {
|
|
|
|
PK_False,
|
|
|
|
PK_True,
|
|
|
|
PK_Unknown
|
|
|
|
};
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2013-05-10 22:27:34 +02:00
|
|
|
/// Returns true if an instruction is predicated on p0 and false if it's
|
|
|
|
/// predicated on !p0.
|
2016-02-23 03:46:52 +01:00
|
|
|
static PredicateKind getPredicateSense(const MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
const HexagonInstrInfo *HII) {
|
|
|
|
if (!HII->isPredicated(MI))
|
2013-05-10 22:27:34 +02:00
|
|
|
return PK_Unknown;
|
2015-12-16 20:36:12 +01:00
|
|
|
if (HII->isPredicatedTrue(MI))
|
2013-05-10 22:27:34 +02:00
|
|
|
return PK_True;
|
|
|
|
return PK_False;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
static const MachineOperand &getPostIncrementOperand(const MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
const HexagonInstrInfo *HII) {
|
2016-08-01 19:55:48 +02:00
|
|
|
assert(HII->isPostIncrement(MI) && "Not a post increment operation.");
|
2012-05-03 23:52:53 +02:00
|
|
|
#ifndef NDEBUG
|
|
|
|
// Post Increment means duplicates. Use dense map to find duplicates in the
|
|
|
|
// list. Caution: Densemap initializes with the minimum of 64 buckets,
|
|
|
|
// whereas there are at most 5 operands in the post increment.
|
2015-12-16 20:36:12 +01:00
|
|
|
DenseSet<unsigned> DefRegsSet;
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : MI.operands())
|
2015-12-16 20:36:12 +01:00
|
|
|
if (MO.isReg() && MO.isDef())
|
|
|
|
DefRegsSet.insert(MO.getReg());
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : MI.operands())
|
2015-12-16 20:36:12 +01:00
|
|
|
if (MO.isReg() && MO.isUse() && DefRegsSet.count(MO.getReg()))
|
|
|
|
return MO;
|
2012-05-03 23:52:53 +02:00
|
|
|
#else
|
2016-07-29 23:49:42 +02:00
|
|
|
if (MI.mayLoad()) {
|
|
|
|
const MachineOperand &Op1 = MI.getOperand(1);
|
2012-05-03 23:52:53 +02:00
|
|
|
// The 2nd operand is always the post increment operand in load.
|
2015-12-16 20:36:12 +01:00
|
|
|
assert(Op1.isReg() && "Post increment operand has be to a register.");
|
|
|
|
return Op1;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
2016-07-29 23:49:42 +02:00
|
|
|
if (MI.getDesc().mayStore()) {
|
|
|
|
const MachineOperand &Op0 = MI.getOperand(0);
|
2012-05-03 23:52:53 +02:00
|
|
|
// The 1st operand is always the post increment operand in store.
|
2015-12-16 20:36:12 +01:00
|
|
|
assert(Op0.isReg() && "Post increment operand has be to a register.");
|
|
|
|
return Op0;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
// we should never come here.
|
|
|
|
llvm_unreachable("mayLoad or mayStore not set for Post Increment operation");
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Get the value being stored.
|
2016-07-29 23:49:42 +02:00
|
|
|
static const MachineOperand& getStoreValueOperand(const MachineInstr &MI) {
|
2012-05-03 23:52:53 +02:00
|
|
|
// value being stored is always the last operand.
|
2016-07-29 23:49:42 +02:00
|
|
|
return MI.getOperand(MI.getNumOperands()-1);
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
static bool isLoadAbsSet(const MachineInstr &MI) {
|
|
|
|
unsigned Opc = MI.getOpcode();
|
2015-12-16 20:36:12 +01:00
|
|
|
switch (Opc) {
|
|
|
|
case Hexagon::L4_loadrd_ap:
|
|
|
|
case Hexagon::L4_loadrb_ap:
|
|
|
|
case Hexagon::L4_loadrh_ap:
|
|
|
|
case Hexagon::L4_loadrub_ap:
|
|
|
|
case Hexagon::L4_loadruh_ap:
|
|
|
|
case Hexagon::L4_loadri_ap:
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
static const MachineOperand &getAbsSetOperand(const MachineInstr &MI) {
|
2015-12-16 20:36:12 +01:00
|
|
|
assert(isLoadAbsSet(MI));
|
2016-07-29 23:49:42 +02:00
|
|
|
return MI.getOperand(1);
|
2015-12-16 20:36:12 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// Can be new value store?
|
2012-05-03 23:52:53 +02:00
|
|
|
// Following restrictions are to be respected in convert a store into
|
|
|
|
// a new value store.
|
|
|
|
// 1. If an instruction uses auto-increment, its address register cannot
|
|
|
|
// be a new-value register. Arch Spec 5.4.2.1
|
2015-12-16 20:36:12 +01:00
|
|
|
// 2. If an instruction uses absolute-set addressing mode, its address
|
|
|
|
// register cannot be a new-value register. Arch Spec 5.4.2.1.
|
2012-05-03 23:52:53 +02:00
|
|
|
// 3. If an instruction produces a 64-bit result, its registers cannot be used
|
|
|
|
// as new-value registers. Arch Spec 5.4.2.2.
|
2015-12-16 20:36:12 +01:00
|
|
|
// 4. If the instruction that sets the new-value register is conditional, then
|
2012-05-03 23:52:53 +02:00
|
|
|
// the instruction that uses the new-value register must also be conditional,
|
|
|
|
// and both must always have their predicates evaluate identically.
|
|
|
|
// Arch Spec 5.4.2.3.
|
2015-12-16 20:36:12 +01:00
|
|
|
// 5. There is an implied restriction that a packet cannot have another store,
|
|
|
|
// if there is a new value store in the packet. Corollary: if there is
|
2012-05-03 23:52:53 +02:00
|
|
|
// already a store in a packet, there can not be a new value store.
|
|
|
|
// Arch Spec: 3.4.4.2
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::canPromoteToNewValueStore(const MachineInstr &MI,
|
|
|
|
const MachineInstr &PacketMI, unsigned DepReg) {
|
2013-05-10 22:58:11 +02:00
|
|
|
// Make sure we are looking at the store, that can be promoted.
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!HII->mayBeNewStore(MI))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Make sure there is dependency and can be new value'd.
|
|
|
|
const MachineOperand &Val = getStoreValueOperand(MI);
|
|
|
|
if (Val.isReg() && Val.getReg() != DepReg)
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
const MCInstrDesc& MCID = PacketMI.getDesc();
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// First operand is always the result.
|
|
|
|
const TargetRegisterClass *PacketRC = HII->getRegClass(MCID, 0, HRI, MF);
|
|
|
|
// Double regs can not feed into new value store: PRM section: 5.4.2.2.
|
|
|
|
if (PacketRC == &Hexagon::DoubleRegsRegClass)
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
2015-12-16 20:36:12 +01:00
|
|
|
|
|
|
|
// New-value stores are of class NV (slot 0), dual stores require class ST
|
|
|
|
// in slot 0 (PRM 5.5).
|
|
|
|
for (auto I : CurrentPacketMIs) {
|
|
|
|
SUnit *PacketSU = MIToSUnit.find(I)->second;
|
|
|
|
if (PacketSU->getInstr()->mayStore())
|
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure it's NOT the post increment register that we are going to
|
|
|
|
// new value.
|
2016-08-01 19:55:48 +02:00
|
|
|
if (HII->isPostIncrement(MI) &&
|
2015-12-16 20:36:12 +01:00
|
|
|
getPostIncrementOperand(MI, HII).getReg() == DepReg) {
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-08-01 19:55:48 +02:00
|
|
|
if (HII->isPostIncrement(PacketMI) && PacketMI.mayLoad() &&
|
2015-12-16 20:36:12 +01:00
|
|
|
getPostIncrementOperand(PacketMI, HII).getReg() == DepReg) {
|
|
|
|
// If source is post_inc, or absolute-set addressing, it can not feed
|
|
|
|
// into new value store
|
|
|
|
// r3 = memw(r2++#4)
|
|
|
|
// memw(r30 + #-1404) = r2.new -> can not be new value store
|
|
|
|
// arch spec section: 5.4.2.1.
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
if (isLoadAbsSet(PacketMI) && getAbsSetOperand(PacketMI).getReg() == DepReg)
|
|
|
|
return false;
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
// If the source that feeds the store is predicated, new value store must
|
2013-05-10 22:58:11 +02:00
|
|
|
// also be predicated.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (HII->isPredicated(PacketMI)) {
|
|
|
|
if (!HII->isPredicated(MI))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// Check to make sure that they both will have their predicates
|
2015-12-16 20:36:12 +01:00
|
|
|
// evaluate identically.
|
2012-05-11 22:00:34 +02:00
|
|
|
unsigned predRegNumSrc = 0;
|
|
|
|
unsigned predRegNumDst = 0;
|
2014-04-25 07:30:21 +02:00
|
|
|
const TargetRegisterClass* predRegClass = nullptr;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Get predicate register used in the source instruction.
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : PacketMI.operands()) {
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
|
|
|
predRegNumSrc = MO.getReg();
|
|
|
|
predRegClass = HRI->getMinimalPhysRegClass(predRegNumSrc);
|
|
|
|
if (predRegClass == &Hexagon::PredRegsRegClass)
|
2012-05-03 23:52:53 +02:00
|
|
|
break;
|
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
assert((predRegClass == &Hexagon::PredRegsRegClass) &&
|
|
|
|
"predicate register not found in a predicated PacketMI instruction");
|
|
|
|
|
|
|
|
// Get predicate register used in new-value store instruction.
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : MI.operands()) {
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
|
|
|
predRegNumDst = MO.getReg();
|
|
|
|
predRegClass = HRI->getMinimalPhysRegClass(predRegNumDst);
|
|
|
|
if (predRegClass == &Hexagon::PredRegsRegClass)
|
2012-05-03 23:52:53 +02:00
|
|
|
break;
|
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
assert((predRegClass == &Hexagon::PredRegsRegClass) &&
|
|
|
|
"predicate register not found in a predicated MI instruction");
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
// New-value register producer and user (store) need to satisfy these
|
|
|
|
// constraints:
|
|
|
|
// 1) Both instructions should be predicated on the same register.
|
|
|
|
// 2) If producer of the new-value register is .new predicated then store
|
|
|
|
// should also be .new predicated and if producer is not .new predicated
|
|
|
|
// then store should not be .new predicated.
|
|
|
|
// 3) Both new-value register producer and user should have same predicate
|
2015-12-16 20:36:12 +01:00
|
|
|
// sense, i.e, either both should be negated or both should be non-negated.
|
|
|
|
if (predRegNumDst != predRegNumSrc ||
|
2016-02-23 03:46:52 +01:00
|
|
|
HII->isDotNewInst(PacketMI) != HII->isDotNewInst(MI) ||
|
2016-07-29 23:49:42 +02:00
|
|
|
getPredicateSense(MI, HII) != getPredicateSense(PacketMI, HII))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure that other than the new-value register no other store instruction
|
|
|
|
// register has been modified in the same packet. Predicate registers can be
|
|
|
|
// modified by they should not be modified between the producer and the store
|
|
|
|
// instruction as it will make them both conditional on different values.
|
|
|
|
// We already know this to be true for all the instructions before and
|
|
|
|
// including PacketMI. Howerver, we need to perform the check for the
|
|
|
|
// remaining instructions in the packet.
|
|
|
|
|
|
|
|
unsigned StartCheck = 0;
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
for (auto I : CurrentPacketMIs) {
|
|
|
|
SUnit *TempSU = MIToSUnit.find(I)->second;
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineInstr &TempMI = *TempSU->getInstr();
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
// Following condition is true for all the instructions until PacketMI is
|
|
|
|
// reached (StartCheck is set to 0 before the for loop).
|
|
|
|
// StartCheck flag is 1 for all the instructions after PacketMI.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (&TempMI != &PacketMI && !StartCheck) // Start processing only after
|
|
|
|
continue; // encountering PacketMI.
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
StartCheck = 1;
|
2016-07-29 23:49:42 +02:00
|
|
|
if (&TempMI == &PacketMI) // We don't want to check PacketMI for dependence.
|
2012-05-03 23:52:53 +02:00
|
|
|
continue;
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : MI.operands())
|
2015-12-16 20:36:12 +01:00
|
|
|
if (MO.isReg() && TempSU->getInstr()->modifiesRegister(MO.getReg(), HRI))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2013-12-05 06:44:44 +01:00
|
|
|
// Make sure that for non-POST_INC stores:
|
2012-05-03 23:52:53 +02:00
|
|
|
// 1. The only use of reg is DepReg and no other registers.
|
2018-10-19 19:31:11 +02:00
|
|
|
// This handles base+index registers.
|
2012-05-03 23:52:53 +02:00
|
|
|
// The following store can not be dot new.
|
2015-12-16 20:36:12 +01:00
|
|
|
// Eg. r0 = add(r0, #3)
|
2012-05-03 23:52:53 +02:00
|
|
|
// memw(r1+r0<<#2) = r0
|
2016-08-01 19:55:48 +02:00
|
|
|
if (!HII->isPostIncrement(MI)) {
|
2016-07-29 23:49:42 +02:00
|
|
|
for (unsigned opNum = 0; opNum < MI.getNumOperands()-1; opNum++) {
|
|
|
|
const MachineOperand &MO = MI.getOperand(opNum);
|
2015-12-16 20:36:12 +01:00
|
|
|
if (MO.isReg() && MO.getReg() == DepReg)
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// If data definition is because of implicit definition of the register,
|
|
|
|
// do not newify the store. Eg.
|
2017-12-07 11:40:31 +01:00
|
|
|
// %r9 = ZXTH %r12, implicit %d6, implicit-def %r12
|
|
|
|
// S2_storerh_io %r8, 2, killed %r12; mem:ST2[%scevgep343]
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : PacketMI.operands()) {
|
2017-02-17 23:14:51 +01:00
|
|
|
if (MO.isRegMask() && MO.clobbersPhysReg(DepReg))
|
|
|
|
return false;
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!MO.isReg() || !MO.isDef() || !MO.isImplicit())
|
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register R = MO.getReg();
|
2015-12-16 20:36:12 +01:00
|
|
|
if (R == DepReg || HRI->isSuperRegister(DepReg, R))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Handle imp-use of super reg case. There is a target independent side
|
|
|
|
// change that should prevent this situation but I am handling it for
|
|
|
|
// just-in-case. For example, we cannot newify R2 in the following case:
|
2017-12-07 11:40:31 +01:00
|
|
|
// %r3 = A2_tfrsi 0;
|
|
|
|
// S2_storeri_io killed %r0, 0, killed %r2, implicit killed %d1;
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : MI.operands()) {
|
2015-12-16 20:36:12 +01:00
|
|
|
if (MO.isReg() && MO.isUse() && MO.isImplicit() && MO.getReg() == DepReg)
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
// Can be dot new store.
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Can this MI to promoted to either new value store or new value jump.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::canPromoteToNewValue(const MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
const SUnit *PacketSU, unsigned DepReg,
|
|
|
|
MachineBasicBlock::iterator &MII) {
|
|
|
|
if (!HII->mayBeNewStore(MI))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// Check to see the store can be new value'ed.
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineInstr &PacketMI = *PacketSU->getInstr();
|
2015-12-16 20:36:12 +01:00
|
|
|
if (canPromoteToNewValueStore(MI, PacketMI, DepReg))
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
|
|
|
|
// Check to see the compare/jump can be new value'ed.
|
|
|
|
// This is done as a pass on its own. Don't need to check it here.
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2017-06-01 20:02:40 +02:00
|
|
|
static bool isImplicitDependency(const MachineInstr &I, bool CheckDef,
|
|
|
|
unsigned DepReg) {
|
2017-02-17 23:14:51 +01:00
|
|
|
for (auto &MO : I.operands()) {
|
2017-06-01 20:02:40 +02:00
|
|
|
if (CheckDef && MO.isRegMask() && MO.clobbersPhysReg(DepReg))
|
2017-02-17 23:14:51 +01:00
|
|
|
return true;
|
2017-06-01 20:02:40 +02:00
|
|
|
if (!MO.isReg() || MO.getReg() != DepReg || !MO.isImplicit())
|
|
|
|
continue;
|
|
|
|
if (CheckDef == MO.isDef())
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
2017-02-17 23:14:51 +01:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-10-19 19:31:11 +02:00
|
|
|
// Check to see if an instruction can be dot new.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::canPromoteToDotNew(const MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
const SUnit *PacketSU, unsigned DepReg, MachineBasicBlock::iterator &MII,
|
|
|
|
const TargetRegisterClass* RC) {
|
2013-03-28 20:44:04 +01:00
|
|
|
// Already a dot new instruction.
|
2015-12-16 20:36:12 +01:00
|
|
|
if (HII->isDotNewInst(MI) && !HII->mayBeNewStore(MI))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
2016-07-26 22:30:30 +02:00
|
|
|
if (!isNewifiable(MI, RC))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
const MachineInstr &PI = *PacketSU->getInstr();
|
2015-12-16 20:36:12 +01:00
|
|
|
|
|
|
|
// The "new value" cannot come from inline asm.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (PI.isInlineAsm())
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// IMPLICIT_DEFs won't materialize as real instructions, so .new makes no
|
|
|
|
// sense.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (PI.isImplicitDef())
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// If dependency is trough an implicitly defined register, we should not
|
|
|
|
// newify the use.
|
2017-06-01 20:02:40 +02:00
|
|
|
if (isImplicitDependency(PI, true, DepReg) ||
|
|
|
|
isImplicitDependency(MI, false, DepReg))
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
const MCInstrDesc& MCID = PI.getDesc();
|
2015-12-16 20:36:12 +01:00
|
|
|
const TargetRegisterClass *VecRC = HII->getRegClass(MCID, 0, HRI, MF);
|
2017-09-15 17:46:05 +02:00
|
|
|
if (DisableVecDblNVStores && VecRC == &Hexagon::HvxWRRegClass)
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
// predicate .new
|
2015-12-16 20:36:12 +01:00
|
|
|
if (RC == &Hexagon::PredRegsRegClass)
|
2017-06-01 20:02:40 +02:00
|
|
|
return HII->predCanBeUsedAsDotNew(PI, DepReg);
|
2015-12-16 20:36:12 +01:00
|
|
|
|
|
|
|
if (RC != &Hexagon::PredRegsRegClass && !HII->mayBeNewStore(MI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Create a dot new machine instruction to see if resources can be
|
|
|
|
// allocated. If not, bail out now.
|
|
|
|
int NewOpcode = HII->getDotNewOp(MI);
|
|
|
|
const MCInstrDesc &D = HII->get(NewOpcode);
|
|
|
|
MachineInstr *NewMI = MF.CreateMachineInstr(D, DebugLoc());
|
2016-02-27 20:09:00 +01:00
|
|
|
bool ResourcesAvailable = ResourceTracker->canReserveResources(*NewMI);
|
2015-12-16 20:36:12 +01:00
|
|
|
MF.DeleteMachineInstr(NewMI);
|
|
|
|
if (!ResourcesAvailable)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// New Value Store only. New Value Jump generated as a separate pass.
|
|
|
|
if (!canPromoteToNewValue(MI, PacketSU, DepReg, MII))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Go through the packet instructions and search for an anti dependency between
|
|
|
|
// them and DepReg from MI. Consider this case:
|
2012-05-03 23:52:53 +02:00
|
|
|
// Trying to add
|
2017-12-07 11:40:31 +01:00
|
|
|
// a) %r1 = TFRI_cdNotPt %p3, 2
|
2012-05-03 23:52:53 +02:00
|
|
|
// to this packet:
|
|
|
|
// {
|
2017-12-07 11:40:31 +01:00
|
|
|
// b) %p0 = C2_or killed %p3, killed %p0
|
|
|
|
// c) %p3 = C2_tfrrp %r23
|
|
|
|
// d) %r1 = C2_cmovenewit %p3, 4
|
2012-05-03 23:52:53 +02:00
|
|
|
// }
|
|
|
|
// The P3 from a) and d) will be complements after
|
|
|
|
// a)'s P3 is converted to .new form
|
2015-12-16 20:36:12 +01:00
|
|
|
// Anti-dep between c) and b) is irrelevant for this case
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::restrictingDepExistInPacket(MachineInstr &MI,
|
2015-12-16 20:36:12 +01:00
|
|
|
unsigned DepReg) {
|
2016-07-29 23:49:42 +02:00
|
|
|
SUnit *PacketSUDep = MIToSUnit.find(&MI)->second;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
for (auto I : CurrentPacketMIs) {
|
2012-05-03 23:52:53 +02:00
|
|
|
// We only care for dependencies to predicated instructions
|
2016-02-23 03:46:52 +01:00
|
|
|
if (!HII->isPredicated(*I))
|
2015-12-16 20:36:12 +01:00
|
|
|
continue;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
// Scheduling Unit for current insn in the packet
|
2015-12-16 20:36:12 +01:00
|
|
|
SUnit *PacketSU = MIToSUnit.find(I)->second;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Look at dependencies between current members of the packet and
|
|
|
|
// predicate defining instruction MI. Make sure that dependency is
|
|
|
|
// on the exact register we care about.
|
2012-05-03 23:52:53 +02:00
|
|
|
if (PacketSU->isSucc(PacketSUDep)) {
|
|
|
|
for (unsigned i = 0; i < PacketSU->Succs.size(); ++i) {
|
2015-12-16 20:36:12 +01:00
|
|
|
auto &Dep = PacketSU->Succs[i];
|
|
|
|
if (Dep.getSUnit() == PacketSUDep && Dep.getKind() == SDep::Anti &&
|
|
|
|
Dep.getReg() == DepReg)
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2013-05-14 18:36:34 +02:00
|
|
|
/// Gets the predicate register of a predicated instruction.
|
2016-02-23 03:46:52 +01:00
|
|
|
static unsigned getPredicatedRegister(MachineInstr &MI,
|
2013-05-23 17:43:11 +02:00
|
|
|
const HexagonInstrInfo *QII) {
|
2013-05-14 18:36:34 +02:00
|
|
|
/// We use the following rule: The first predicate register that is a use is
|
|
|
|
/// the predicate register of a predicated instruction.
|
|
|
|
assert(QII->isPredicated(MI) && "Must be predicated instruction");
|
|
|
|
|
2016-02-23 03:46:52 +01:00
|
|
|
for (auto &Op : MI.operands()) {
|
2013-05-14 18:36:34 +02:00
|
|
|
if (Op.isReg() && Op.getReg() && Op.isUse() &&
|
|
|
|
Hexagon::PredRegsRegClass.contains(Op.getReg()))
|
|
|
|
return Op.getReg();
|
|
|
|
}
|
|
|
|
|
|
|
|
llvm_unreachable("Unknown instruction operand layout");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
// Given two predicated instructions, this function detects whether
|
2015-12-16 20:36:12 +01:00
|
|
|
// the predicates are complements.
|
2016-02-23 03:46:52 +01:00
|
|
|
bool HexagonPacketizerList::arePredicatesComplements(MachineInstr &MI1,
|
|
|
|
MachineInstr &MI2) {
|
2013-05-14 18:36:34 +02:00
|
|
|
// If we don't know the predicate sense of the instructions bail out early, we
|
|
|
|
// need it later.
|
2015-12-16 20:36:12 +01:00
|
|
|
if (getPredicateSense(MI1, HII) == PK_Unknown ||
|
|
|
|
getPredicateSense(MI2, HII) == PK_Unknown)
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Scheduling unit for candidate.
|
2016-02-23 03:46:52 +01:00
|
|
|
SUnit *SU = MIToSUnit[&MI1];
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
// One corner case deals with the following scenario:
|
|
|
|
// Trying to add
|
2017-12-07 11:40:31 +01:00
|
|
|
// a) %r24 = A2_tfrt %p0, %r25
|
2012-05-03 23:52:53 +02:00
|
|
|
// to this packet:
|
|
|
|
// {
|
2017-12-07 11:40:31 +01:00
|
|
|
// b) %r25 = A2_tfrf %p0, %r24
|
|
|
|
// c) %p0 = C2_cmpeqi %r26, 1
|
2012-05-03 23:52:53 +02:00
|
|
|
// }
|
|
|
|
//
|
2015-12-16 20:36:12 +01:00
|
|
|
// On general check a) and b) are complements, but presence of c) will
|
|
|
|
// convert a) to .new form, and then it is not a complement.
|
|
|
|
// We attempt to detect it by analyzing existing dependencies in the packet.
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
// Analyze relationships between all existing members of the packet.
|
2015-12-16 20:36:12 +01:00
|
|
|
// Look for Anti dependecy on the same predicate reg as used in the
|
|
|
|
// candidate.
|
|
|
|
for (auto I : CurrentPacketMIs) {
|
|
|
|
// Scheduling Unit for current insn in the packet.
|
|
|
|
SUnit *PacketSU = MIToSUnit.find(I)->second;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
|
|
|
// If this instruction in the packet is succeeded by the candidate...
|
|
|
|
if (PacketSU->isSucc(SU)) {
|
|
|
|
for (unsigned i = 0; i < PacketSU->Succs.size(); ++i) {
|
2015-12-16 20:36:12 +01:00
|
|
|
auto Dep = PacketSU->Succs[i];
|
|
|
|
// The corner case exist when there is true data dependency between
|
|
|
|
// candidate and one of current packet members, this dep is on
|
|
|
|
// predicate reg, and there already exist anti dep on the same pred in
|
2012-05-03 23:52:53 +02:00
|
|
|
// the packet.
|
2015-12-16 20:36:12 +01:00
|
|
|
if (Dep.getSUnit() == SU && Dep.getKind() == SDep::Data &&
|
|
|
|
Hexagon::PredRegsRegClass.contains(Dep.getReg())) {
|
|
|
|
// Here I know that I is predicate setting instruction with true
|
|
|
|
// data dep to candidate on the register we care about - c) in the
|
|
|
|
// above example. Now I need to see if there is an anti dependency
|
|
|
|
// from c) to any other instruction in the same packet on the pred
|
|
|
|
// reg of interest.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (restrictingDepExistInPacket(*I, Dep.getReg()))
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// If the above case does not apply, check regular complement condition.
|
|
|
|
// Check that the predicate register is the same and that the predicate
|
|
|
|
// sense is different We also need to differentiate .old vs. .new: !p0
|
|
|
|
// is not complementary to p0.new.
|
|
|
|
unsigned PReg1 = getPredicatedRegister(MI1, HII);
|
|
|
|
unsigned PReg2 = getPredicatedRegister(MI2, HII);
|
|
|
|
return PReg1 == PReg2 &&
|
|
|
|
Hexagon::PredRegsRegClass.contains(PReg1) &&
|
|
|
|
Hexagon::PredRegsRegClass.contains(PReg2) &&
|
|
|
|
getPredicateSense(MI1, HII) != getPredicateSense(MI2, HII) &&
|
2016-07-29 23:49:42 +02:00
|
|
|
HII->isDotNewInst(MI1) == HII->isDotNewInst(MI2);
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Initialize packetizer flags.
|
2012-05-03 23:52:53 +02:00
|
|
|
void HexagonPacketizerList::initPacketizerState() {
|
|
|
|
Dependence = false;
|
|
|
|
PromotedToDotNew = false;
|
|
|
|
GlueToNewValueJump = false;
|
|
|
|
GlueAllocframeStore = false;
|
|
|
|
FoundSequentialDependence = false;
|
2017-10-11 17:51:44 +02:00
|
|
|
ChangedOffset = INT64_MAX;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Ignore bundling of pseudo instructions.
|
2016-02-27 20:09:00 +01:00
|
|
|
bool HexagonPacketizerList::ignorePseudoInstruction(const MachineInstr &MI,
|
|
|
|
const MachineBasicBlock *) {
|
2018-05-09 04:42:00 +02:00
|
|
|
if (MI.isDebugInstr())
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
|
2016-02-27 20:09:00 +01:00
|
|
|
if (MI.isCFIInstruction())
|
2015-04-22 17:47:35 +02:00
|
|
|
return false;
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// We must print out inline assembly.
|
2016-02-27 20:09:00 +01:00
|
|
|
if (MI.isInlineAsm())
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
|
|
|
|
2016-02-27 20:09:00 +01:00
|
|
|
if (MI.isImplicitDef())
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
|
|
|
|
|
|
|
// We check if MI has any functional units mapped to it. If it doesn't,
|
|
|
|
// we ignore the instruction.
|
2016-02-27 20:09:00 +01:00
|
|
|
const MCInstrDesc& TID = MI.getDesc();
|
2015-12-16 20:36:12 +01:00
|
|
|
auto *IS = ResourceTracker->getInstrItins()->beginStage(TID.getSchedClass());
|
2019-12-09 16:22:57 +01:00
|
|
|
return !IS->getUnits();
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2016-02-27 20:09:00 +01:00
|
|
|
bool HexagonPacketizerList::isSoloInstruction(const MachineInstr &MI) {
|
2020-05-22 14:32:39 +02:00
|
|
|
// Ensure any bundles created by gather packetize remain separate.
|
2017-12-11 19:57:54 +01:00
|
|
|
if (MI.isBundle())
|
|
|
|
return true;
|
|
|
|
|
2016-02-27 20:09:00 +01:00
|
|
|
if (MI.isEHLabel() || MI.isCFIInstruction())
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Consider inline asm to not be a solo instruction by default.
|
|
|
|
// Inline asm will be put in a packet temporarily, but then it will be
|
|
|
|
// removed, and placed outside of the packet (before or after, depending
|
|
|
|
// on dependencies). This is to reduce the impact of inline asm as a
|
|
|
|
// "packet splitting" instruction.
|
2016-02-27 20:09:00 +01:00
|
|
|
if (MI.isInlineAsm() && !ScheduleInlineAsm)
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
if (isSchedBarrier(MI))
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
if (HII->isSolo(MI))
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
|
|
|
|
2016-02-27 20:09:00 +01:00
|
|
|
if (MI.getOpcode() == Hexagon::A2_nop)
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Quick check if instructions MI and MJ cannot coexist in the same packet.
|
|
|
|
// Limit the tests to be "one-way", e.g. "if MI->isBranch and MJ->isInlineAsm",
|
|
|
|
// but not the symmetric case: "if MJ->isBranch and MI->isInlineAsm".
|
|
|
|
// For full test call this function twice:
|
|
|
|
// cannotCoexistAsymm(MI, MJ) || cannotCoexistAsymm(MJ, MI)
|
|
|
|
// Doing the test only one way saves the amount of code in this function,
|
|
|
|
// since every test would need to be repeated with the MI and MJ reversed.
|
2016-07-29 23:49:42 +02:00
|
|
|
static bool cannotCoexistAsymm(const MachineInstr &MI, const MachineInstr &MJ,
|
2015-12-16 20:36:12 +01:00
|
|
|
const HexagonInstrInfo &HII) {
|
2016-07-29 23:49:42 +02:00
|
|
|
const MachineFunction *MF = MI.getParent()->getParent();
|
2018-06-20 15:56:09 +02:00
|
|
|
if (MF->getSubtarget<HexagonSubtarget>().hasV60OpsOnly() &&
|
2015-12-16 20:36:12 +01:00
|
|
|
HII.isHVXMemWithAIndirect(MI, MJ))
|
|
|
|
return true;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// An inline asm cannot be together with a branch, because we may not be
|
|
|
|
// able to remove the asm out after packetizing (i.e. if the asm must be
|
|
|
|
// moved past the bundle). Similarly, two asms cannot be together to avoid
|
|
|
|
// complications when determining their relative order outside of a bundle.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (MI.isInlineAsm())
|
|
|
|
return MJ.isInlineAsm() || MJ.isBranch() || MJ.isBarrier() ||
|
|
|
|
MJ.isCall() || MJ.isTerminator();
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2018-09-04 23:07:27 +02:00
|
|
|
// New-value stores cannot coexist with any other stores.
|
|
|
|
if (HII.isNewValueStore(MI) && MJ.mayStore())
|
|
|
|
return true;
|
|
|
|
|
2016-08-19 18:57:05 +02:00
|
|
|
switch (MI.getOpcode()) {
|
2017-12-11 19:57:54 +01:00
|
|
|
case Hexagon::S2_storew_locked:
|
|
|
|
case Hexagon::S4_stored_locked:
|
|
|
|
case Hexagon::L2_loadw_locked:
|
|
|
|
case Hexagon::L4_loadd_locked:
|
2018-06-19 19:26:20 +02:00
|
|
|
case Hexagon::Y2_dccleana:
|
|
|
|
case Hexagon::Y2_dccleaninva:
|
|
|
|
case Hexagon::Y2_dcinva:
|
|
|
|
case Hexagon::Y2_dczeroa:
|
2017-12-11 19:57:54 +01:00
|
|
|
case Hexagon::Y4_l2fetch:
|
|
|
|
case Hexagon::Y5_l2fetch: {
|
2016-08-19 18:57:05 +02:00
|
|
|
// These instructions can only be grouped with ALU32 or non-floating-point
|
|
|
|
// XTYPE instructions. Since there is no convenient way of identifying fp
|
|
|
|
// XTYPE instructions, only allow grouping with ALU32 for now.
|
|
|
|
unsigned TJ = HII.getType(MJ);
|
2017-02-07 18:47:37 +01:00
|
|
|
if (TJ != HexagonII::TypeALU32_2op &&
|
|
|
|
TJ != HexagonII::TypeALU32_3op &&
|
|
|
|
TJ != HexagonII::TypeALU32_ADDI)
|
2016-08-19 18:57:05 +02:00
|
|
|
return true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// "False" really means that the quick check failed to determine if
|
|
|
|
// I and J cannot coexist.
|
|
|
|
return false;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Full, symmetric check.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::cannotCoexist(const MachineInstr &MI,
|
|
|
|
const MachineInstr &MJ) {
|
2015-12-16 20:36:12 +01:00
|
|
|
return cannotCoexistAsymm(MI, MJ, *HII) || cannotCoexistAsymm(MJ, MI, *HII);
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
void HexagonPacketizerList::unpacketizeSoloInstrs(MachineFunction &MF) {
|
|
|
|
for (auto &B : MF) {
|
|
|
|
MachineBasicBlock::iterator BundleIt;
|
|
|
|
MachineBasicBlock::instr_iterator NextI;
|
|
|
|
for (auto I = B.instr_begin(), E = B.instr_end(); I != E; I = NextI) {
|
|
|
|
NextI = std::next(I);
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineInstr &MI = *I;
|
|
|
|
if (MI.isBundle())
|
2015-12-16 20:36:12 +01:00
|
|
|
BundleIt = I;
|
2016-07-29 23:49:42 +02:00
|
|
|
if (!MI.isInsideBundle())
|
2015-12-16 20:36:12 +01:00
|
|
|
continue;
|
|
|
|
|
|
|
|
// Decide on where to insert the instruction that we are pulling out.
|
|
|
|
// Debug instructions always go before the bundle, but the placement of
|
|
|
|
// INLINE_ASM depends on potential dependencies. By default, try to
|
|
|
|
// put it before the bundle, but if the asm writes to a register that
|
|
|
|
// other instructions in the bundle read, then we need to place it
|
|
|
|
// after the bundle (to preserve the bundle semantics).
|
|
|
|
bool InsertBeforeBundle;
|
2016-07-29 23:49:42 +02:00
|
|
|
if (MI.isInlineAsm())
|
|
|
|
InsertBeforeBundle = !hasWriteToReadDep(MI, *BundleIt, HRI);
|
|
|
|
else if (MI.isDebugValue())
|
2015-12-16 20:36:12 +01:00
|
|
|
InsertBeforeBundle = true;
|
|
|
|
else
|
|
|
|
continue;
|
|
|
|
|
|
|
|
BundleIt = moveInstrOut(MI, BundleIt, InsertBeforeBundle);
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Check if a given instruction is of class "system".
|
2016-07-29 23:49:42 +02:00
|
|
|
static bool isSystemInstr(const MachineInstr &MI) {
|
|
|
|
unsigned Opc = MI.getOpcode();
|
2015-12-16 20:36:12 +01:00
|
|
|
switch (Opc) {
|
|
|
|
case Hexagon::Y2_barrier:
|
|
|
|
case Hexagon::Y2_dcfetchbo:
|
2017-12-11 19:57:54 +01:00
|
|
|
case Hexagon::Y4_l2fetch:
|
|
|
|
case Hexagon::Y5_l2fetch:
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::hasDeadDependence(const MachineInstr &I,
|
|
|
|
const MachineInstr &J) {
|
2015-12-16 20:36:12 +01:00
|
|
|
// The dependence graph may not include edges between dead definitions,
|
|
|
|
// so without extra checks, we could end up packetizing two instruction
|
|
|
|
// defining the same (dead) register.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (I.isCall() || J.isCall())
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
2016-07-29 23:49:42 +02:00
|
|
|
if (HII->isPredicated(I) || HII->isPredicated(J))
|
2012-05-03 23:52:53 +02:00
|
|
|
return false;
|
2015-12-16 20:36:12 +01:00
|
|
|
|
|
|
|
BitVector DeadDefs(Hexagon::NUM_TARGET_REGS);
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : I.operands()) {
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!MO.isReg() || !MO.isDef() || !MO.isDead())
|
|
|
|
continue;
|
|
|
|
DeadDefs[MO.getReg()] = true;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
for (auto &MO : J.operands()) {
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!MO.isReg() || !MO.isDef() || !MO.isDead())
|
|
|
|
continue;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register R = MO.getReg();
|
2015-12-16 20:36:12 +01:00
|
|
|
if (R != Hexagon::USR_OVF && DeadDefs[R])
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::hasControlDependence(const MachineInstr &I,
|
|
|
|
const MachineInstr &J) {
|
2015-12-16 20:36:12 +01:00
|
|
|
// A save callee-save register function call can only be in a packet
|
|
|
|
// with instructions that don't write to the callee-save registers.
|
|
|
|
if ((HII->isSaveCalleeSavedRegsCall(I) &&
|
|
|
|
doesModifyCalleeSavedReg(J, HRI)) ||
|
|
|
|
(HII->isSaveCalleeSavedRegsCall(J) &&
|
|
|
|
doesModifyCalleeSavedReg(I, HRI)))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
// Two control flow instructions cannot go in the same packet.
|
|
|
|
if (isControlFlow(I) && isControlFlow(J))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
// \ref-manual (7.3.4) A loop setup packet in loopN or spNloop0 cannot
|
|
|
|
// contain a speculative indirect jump,
|
|
|
|
// a new-value compare jump or a dealloc_return.
|
2016-07-29 23:49:42 +02:00
|
|
|
auto isBadForLoopN = [this] (const MachineInstr &MI) -> bool {
|
|
|
|
if (MI.isCall() || HII->isDeallocRet(MI) || HII->isNewValueJump(MI))
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
2016-07-29 23:49:42 +02:00
|
|
|
if (HII->isPredicated(MI) && HII->isPredicatedNew(MI) && HII->isJumpR(MI))
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
|
|
|
return false;
|
|
|
|
};
|
|
|
|
|
|
|
|
if (HII->isLoopN(I) && isBadForLoopN(J))
|
|
|
|
return true;
|
|
|
|
if (HII->isLoopN(J) && isBadForLoopN(I))
|
|
|
|
return true;
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
// dealloc_return cannot appear in the same packet as a conditional or
|
|
|
|
// unconditional jump.
|
2015-12-16 20:36:12 +01:00
|
|
|
return HII->isDeallocRet(I) &&
|
2016-07-29 23:49:42 +02:00
|
|
|
(J.isBranch() || J.isCall() || J.isBarrier());
|
2015-12-16 20:36:12 +01:00
|
|
|
}
|
|
|
|
|
2017-02-17 23:14:51 +01:00
|
|
|
bool HexagonPacketizerList::hasRegMaskDependence(const MachineInstr &I,
|
|
|
|
const MachineInstr &J) {
|
|
|
|
// Adding I to a packet that has J.
|
|
|
|
|
|
|
|
// Regmasks are not reflected in the scheduling dependency graph, so
|
|
|
|
// we need to check them manually. This code assumes that regmasks only
|
|
|
|
// occur on calls, and the problematic case is when we add an instruction
|
|
|
|
// defining a register R to a packet that has a call that clobbers R via
|
|
|
|
// a regmask. Those cannot be packetized together, because the call will
|
|
|
|
// be executed last. That's also a reson why it is ok to add a call
|
|
|
|
// clobbering R to a packet that defines R.
|
|
|
|
|
|
|
|
// Look for regmasks in J.
|
|
|
|
for (const MachineOperand &OpJ : J.operands()) {
|
|
|
|
if (!OpJ.isRegMask())
|
|
|
|
continue;
|
|
|
|
assert((J.isCall() || HII->isTailCall(J)) && "Regmask on a non-call");
|
|
|
|
for (const MachineOperand &OpI : I.operands()) {
|
|
|
|
if (OpI.isReg()) {
|
|
|
|
if (OpJ.clobbersPhysReg(OpI.getReg()))
|
|
|
|
return true;
|
|
|
|
} else if (OpI.isRegMask()) {
|
|
|
|
// Both are regmasks. Assume that they intersect.
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-10-19 19:31:11 +02:00
|
|
|
bool HexagonPacketizerList::hasDualStoreDependence(const MachineInstr &I,
|
|
|
|
const MachineInstr &J) {
|
2015-12-16 20:36:12 +01:00
|
|
|
bool SysI = isSystemInstr(I), SysJ = isSystemInstr(J);
|
2016-07-29 23:49:42 +02:00
|
|
|
bool StoreI = I.mayStore(), StoreJ = J.mayStore();
|
2015-12-16 20:36:12 +01:00
|
|
|
if ((SysI && StoreJ) || (SysJ && StoreI))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
if (StoreI && StoreJ) {
|
|
|
|
if (HII->isNewValueInst(J) || HII->isMemOp(J) || HII->isMemOp(I))
|
|
|
|
return true;
|
|
|
|
} else {
|
|
|
|
// A memop cannot be in the same packet with another memop or a store.
|
|
|
|
// Two stores can be together, but here I and J cannot both be stores.
|
|
|
|
bool MopStI = HII->isMemOp(I) || StoreI;
|
|
|
|
bool MopStJ = HII->isMemOp(J) || StoreJ;
|
|
|
|
if (MopStI && MopStJ)
|
|
|
|
return true;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
return (StoreJ && HII->isDeallocRet(I)) || (StoreI && HII->isDeallocRet(J));
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// SUI is the current instruction that is out side of the current packet.
|
|
|
|
// SUJ is the current instruction inside the current packet against which that
|
|
|
|
// SUI will be packetized.
|
|
|
|
bool HexagonPacketizerList::isLegalToPacketizeTogether(SUnit *SUI, SUnit *SUJ) {
|
2016-07-29 23:49:42 +02:00
|
|
|
assert(SUI->getInstr() && SUJ->getInstr());
|
|
|
|
MachineInstr &I = *SUI->getInstr();
|
|
|
|
MachineInstr &J = *SUJ->getInstr();
|
2015-12-16 20:36:12 +01:00
|
|
|
|
|
|
|
// Clear IgnoreDepMIs when Packet starts.
|
|
|
|
if (CurrentPacketMIs.size() == 1)
|
|
|
|
IgnoreDepMIs.clear();
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineBasicBlock::iterator II = I.getIterator();
|
2015-12-16 20:36:12 +01:00
|
|
|
|
|
|
|
// Solo instructions cannot go in the packet.
|
2016-07-29 23:49:42 +02:00
|
|
|
assert(!isSoloInstruction(I) && "Unexpected solo instr!");
|
2015-12-16 20:36:12 +01:00
|
|
|
|
|
|
|
if (cannotCoexist(I, J))
|
2015-02-09 22:56:37 +01:00
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
Dependence = hasDeadDependence(I, J) || hasControlDependence(I, J);
|
|
|
|
if (Dependence)
|
2015-02-09 22:56:37 +01:00
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2017-02-17 23:14:51 +01:00
|
|
|
// Regmasks are not accounted for in the scheduling graph, so we need
|
|
|
|
// to explicitly check for dependencies caused by them. They should only
|
|
|
|
// appear on calls, so it's not too pessimistic to reject all regmask
|
|
|
|
// dependencies.
|
|
|
|
Dependence = hasRegMaskDependence(I, J);
|
|
|
|
if (Dependence)
|
|
|
|
return false;
|
|
|
|
|
2018-10-19 19:31:11 +02:00
|
|
|
// Dual-store does not allow second store, if the first store is not
|
|
|
|
// in SLOT0. New value store, new value jump, dealloc_return and memop
|
|
|
|
// always take SLOT0. Arch spec 3.4.4.2.
|
|
|
|
Dependence = hasDualStoreDependence(I, J);
|
2015-12-16 20:36:12 +01:00
|
|
|
if (Dependence)
|
2015-02-09 22:56:37 +01:00
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-02-09 22:56:37 +01:00
|
|
|
// If an instruction feeds new value jump, glue it.
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineBasicBlock::iterator NextMII = I.getIterator();
|
2015-02-09 22:56:37 +01:00
|
|
|
++NextMII;
|
2016-07-29 23:49:42 +02:00
|
|
|
if (NextMII != I.getParent()->end() && HII->isNewValueJump(*NextMII)) {
|
2016-07-12 03:55:32 +02:00
|
|
|
MachineInstr &NextMI = *NextMII;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-02-09 22:56:37 +01:00
|
|
|
bool secondRegMatch = false;
|
2016-07-12 03:55:32 +02:00
|
|
|
const MachineOperand &NOp0 = NextMI.getOperand(0);
|
|
|
|
const MachineOperand &NOp1 = NextMI.getOperand(1);
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
if (NOp1.isReg() && I.getOperand(0).getReg() == NOp1.getReg())
|
2015-02-09 22:56:37 +01:00
|
|
|
secondRegMatch = true;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2017-10-11 23:20:43 +02:00
|
|
|
for (MachineInstr *PI : CurrentPacketMIs) {
|
2015-12-16 20:36:12 +01:00
|
|
|
// NVJ can not be part of the dual jump - Arch Spec: section 7.8.
|
2017-10-11 23:20:43 +02:00
|
|
|
if (PI->isCall()) {
|
2015-02-09 22:56:37 +01:00
|
|
|
Dependence = true;
|
|
|
|
break;
|
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
// Validate:
|
2015-02-09 22:56:37 +01:00
|
|
|
// 1. Packet does not have a store in it.
|
|
|
|
// 2. If the first operand of the nvj is newified, and the second
|
|
|
|
// operand is also a reg, it (second reg) is not defined in
|
|
|
|
// the same packet.
|
|
|
|
// 3. If the second operand of the nvj is newified, (which means
|
|
|
|
// first operand is also a reg), first reg is not defined in
|
|
|
|
// the same packet.
|
2017-10-11 23:20:43 +02:00
|
|
|
if (PI->getOpcode() == Hexagon::S2_allocframe || PI->mayStore() ||
|
|
|
|
HII->isLoopN(*PI)) {
|
2015-12-16 20:36:12 +01:00
|
|
|
Dependence = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
// Check #2/#3.
|
|
|
|
const MachineOperand &OpR = secondRegMatch ? NOp0 : NOp1;
|
2017-10-11 23:20:43 +02:00
|
|
|
if (OpR.isReg() && PI->modifiesRegister(OpR.getReg(), HRI)) {
|
2015-02-09 22:56:37 +01:00
|
|
|
Dependence = true;
|
|
|
|
break;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
|
2017-10-11 23:20:43 +02:00
|
|
|
GlueToNewValueJump = true;
|
2015-12-16 20:36:12 +01:00
|
|
|
if (Dependence)
|
2015-02-09 22:56:37 +01:00
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// There no dependency between a prolog instruction and its successor.
|
|
|
|
if (!SUJ->isSucc(SUI))
|
|
|
|
return true;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
for (unsigned i = 0; i < SUJ->Succs.size(); ++i) {
|
|
|
|
if (FoundSequentialDependence)
|
|
|
|
break;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
if (SUJ->Succs[i].getSUnit() != SUI)
|
|
|
|
continue;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
SDep::Kind DepType = SUJ->Succs[i].getKind();
|
|
|
|
// For direct calls:
|
|
|
|
// Ignore register dependences for call instructions for packetization
|
|
|
|
// purposes except for those due to r31 and predicate registers.
|
|
|
|
//
|
|
|
|
// For indirect calls:
|
|
|
|
// Same as direct calls + check for true dependences to the register
|
|
|
|
// used in the indirect call.
|
|
|
|
//
|
|
|
|
// We completely ignore Order dependences for call instructions.
|
|
|
|
//
|
|
|
|
// For returns:
|
|
|
|
// Ignore register dependences for return instructions like jumpr,
|
|
|
|
// dealloc return unless we have dependencies on the explicit uses
|
|
|
|
// of the registers used by jumpr (like r31) or dealloc return
|
|
|
|
// (like r29 or r30).
|
|
|
|
unsigned DepReg = 0;
|
|
|
|
const TargetRegisterClass *RC = nullptr;
|
|
|
|
if (DepType == SDep::Data) {
|
|
|
|
DepReg = SUJ->Succs[i].getReg();
|
|
|
|
RC = HRI->getMinimalPhysRegClass(DepReg);
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2016-08-23 18:01:01 +02:00
|
|
|
if (I.isCall() || HII->isJumpR(I) || I.isReturn() || HII->isTailCall(I)) {
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!isRegDependence(DepType))
|
|
|
|
continue;
|
|
|
|
if (!isCallDependent(I, DepType, SUJ->Succs[i].getReg()))
|
|
|
|
continue;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
if (DepType == SDep::Data) {
|
|
|
|
if (canPromoteToDotCur(J, SUJ, DepReg, II, RC))
|
|
|
|
if (promoteToDotCur(J, DepType, II, RC))
|
|
|
|
continue;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Data dpendence ok if we have load.cur.
|
|
|
|
if (DepType == SDep::Data && HII->isDotCurInst(J)) {
|
2017-05-03 22:10:36 +02:00
|
|
|
if (HII->isHVXVec(I))
|
2015-12-16 20:36:12 +01:00
|
|
|
continue;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// For instructions that can be promoted to dot-new, try to promote.
|
|
|
|
if (DepType == SDep::Data) {
|
|
|
|
if (canPromoteToDotNew(I, SUJ, DepReg, II, RC)) {
|
|
|
|
if (promoteToDotNew(I, DepType, II, RC)) {
|
|
|
|
PromotedToDotNew = true;
|
2017-05-03 22:10:36 +02:00
|
|
|
if (cannotCoexist(I, J))
|
|
|
|
FoundSequentialDependence = true;
|
2015-12-16 20:36:12 +01:00
|
|
|
continue;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
if (HII->isNewValueJump(I))
|
|
|
|
continue;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// For predicated instructions, if the predicates are complements then
|
|
|
|
// there can be no dependence.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (HII->isPredicated(I) && HII->isPredicated(J) &&
|
|
|
|
arePredicatesComplements(I, J)) {
|
2015-12-16 20:36:12 +01:00
|
|
|
// Not always safe to do this translation.
|
|
|
|
// DAG Builder attempts to reduce dependence edges using transitive
|
|
|
|
// nature of dependencies. Here is an example:
|
2012-05-03 23:52:53 +02:00
|
|
|
//
|
2015-12-16 20:36:12 +01:00
|
|
|
// r0 = tfr_pt ... (1)
|
|
|
|
// r0 = tfr_pf ... (2)
|
|
|
|
// r0 = tfr_pt ... (3)
|
2012-05-03 23:52:53 +02:00
|
|
|
//
|
2015-12-16 20:36:12 +01:00
|
|
|
// There will be an output dependence between (1)->(2) and (2)->(3).
|
|
|
|
// However, there is no dependence edge between (1)->(3). This results
|
|
|
|
// in all 3 instructions going in the same packet. We ignore dependce
|
|
|
|
// only once to avoid this situation.
|
2016-08-12 00:21:41 +02:00
|
|
|
auto Itr = find(IgnoreDepMIs, &J);
|
2015-12-16 20:36:12 +01:00
|
|
|
if (Itr != IgnoreDepMIs.end()) {
|
|
|
|
Dependence = true;
|
|
|
|
return false;
|
|
|
|
}
|
2016-07-29 23:49:42 +02:00
|
|
|
IgnoreDepMIs.push_back(&I);
|
2015-12-16 20:36:12 +01:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Ignore Order dependences between unconditional direct branches
|
|
|
|
// and non-control-flow instructions.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (isDirectJump(I) && !J.isBranch() && !J.isCall() &&
|
2015-12-16 20:36:12 +01:00
|
|
|
DepType == SDep::Order)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
// Ignore all dependences for jumps except for true and output
|
|
|
|
// dependences.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (I.isConditionalBranch() && DepType != SDep::Data &&
|
2015-12-16 20:36:12 +01:00
|
|
|
DepType != SDep::Output)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (DepType == SDep::Output) {
|
|
|
|
FoundSequentialDependence = true;
|
|
|
|
break;
|
|
|
|
}
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// For Order dependences:
|
2018-10-19 19:31:11 +02:00
|
|
|
// 1. Volatile loads/stores can be packetized together, unless other
|
|
|
|
// rules prevent is.
|
2015-12-16 20:36:12 +01:00
|
|
|
// 2. Store followed by a load is not allowed.
|
2018-10-19 19:31:11 +02:00
|
|
|
// 3. Store followed by a store is valid.
|
2015-12-16 20:36:12 +01:00
|
|
|
// 4. Load followed by any memory operation is allowed.
|
|
|
|
if (DepType == SDep::Order) {
|
|
|
|
if (!PacketizeVolatiles) {
|
2016-07-29 23:49:42 +02:00
|
|
|
bool OrdRefs = I.hasOrderedMemoryRef() || J.hasOrderedMemoryRef();
|
2015-12-16 20:36:12 +01:00
|
|
|
if (OrdRefs) {
|
2012-05-03 23:52:53 +02:00
|
|
|
FoundSequentialDependence = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
// J is first, I is second.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool LoadJ = J.mayLoad(), StoreJ = J.mayStore();
|
|
|
|
bool LoadI = I.mayLoad(), StoreI = I.mayStore();
|
2017-12-11 19:57:54 +01:00
|
|
|
bool NVStoreJ = HII->isNewValueStore(J);
|
|
|
|
bool NVStoreI = HII->isNewValueStore(I);
|
|
|
|
bool IsVecJ = HII->isHVXVec(J);
|
|
|
|
bool IsVecI = HII->isHVXVec(I);
|
|
|
|
|
2018-06-20 15:56:09 +02:00
|
|
|
if (Slot1Store && MF.getSubtarget<HexagonSubtarget>().hasV65Ops() &&
|
2017-12-11 19:57:54 +01:00
|
|
|
((LoadJ && StoreI && !NVStoreI) ||
|
|
|
|
(StoreJ && LoadI && !NVStoreJ)) &&
|
|
|
|
(J.getOpcode() != Hexagon::S2_allocframe &&
|
|
|
|
I.getOpcode() != Hexagon::S2_allocframe) &&
|
|
|
|
(J.getOpcode() != Hexagon::L2_deallocframe &&
|
|
|
|
I.getOpcode() != Hexagon::L2_deallocframe) &&
|
|
|
|
(!HII->isMemOp(J) && !HII->isMemOp(I)) && (!IsVecJ && !IsVecI))
|
|
|
|
setmemShufDisabled(true);
|
|
|
|
else
|
|
|
|
if (StoreJ && LoadI && alias(J, I)) {
|
|
|
|
FoundSequentialDependence = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!StoreJ)
|
|
|
|
if (!LoadJ || (!LoadI && !StoreI)) {
|
|
|
|
// If J is neither load nor store, assume a dependency.
|
|
|
|
// If J is a load, but I is neither, also assume a dependency.
|
2012-05-03 23:52:53 +02:00
|
|
|
FoundSequentialDependence = true;
|
|
|
|
break;
|
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
// Store followed by store: not OK on V2.
|
|
|
|
// Store followed by load: not OK on all.
|
|
|
|
// Load followed by store: OK on all.
|
|
|
|
// Load followed by load: OK on all.
|
|
|
|
continue;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2018-10-19 19:31:11 +02:00
|
|
|
// Special case for ALLOCFRAME: even though there is dependency
|
2015-12-16 20:36:12 +01:00
|
|
|
// between ALLOCFRAME and subsequent store, allow it to be packetized
|
|
|
|
// in a same packet. This implies that the store is using the caller's
|
|
|
|
// SP. Hence, offset needs to be updated accordingly.
|
2016-07-29 23:49:42 +02:00
|
|
|
if (DepType == SDep::Data && J.getOpcode() == Hexagon::S2_allocframe) {
|
|
|
|
unsigned Opc = I.getOpcode();
|
2015-12-16 20:36:12 +01:00
|
|
|
switch (Opc) {
|
|
|
|
case Hexagon::S2_storerd_io:
|
|
|
|
case Hexagon::S2_storeri_io:
|
|
|
|
case Hexagon::S2_storerh_io:
|
|
|
|
case Hexagon::S2_storerb_io:
|
2016-07-29 23:49:42 +02:00
|
|
|
if (I.getOperand(0).getReg() == HRI->getStackRegister()) {
|
2016-07-26 16:24:46 +02:00
|
|
|
// Since this store is to be glued with allocframe in the same
|
|
|
|
// packet, it will use SP of the previous stack frame, i.e.
|
|
|
|
// caller's SP. Therefore, we need to recalculate offset
|
|
|
|
// according to this change.
|
|
|
|
GlueAllocframeStore = useCallersSP(I);
|
|
|
|
if (GlueAllocframeStore)
|
2015-12-16 20:36:12 +01:00
|
|
|
continue;
|
|
|
|
}
|
Fix clang -Wimplicit-fallthrough warnings across llvm, NFC
This patch should not introduce any behavior changes. It consists of
mostly one of two changes:
1. Replacing fall through comments with the LLVM_FALLTHROUGH macro
2. Inserting 'break' before falling through into a case block consisting
of only 'break'.
We were already using this warning with GCC, but its warning behaves
slightly differently. In this patch, the following differences are
relevant:
1. GCC recognizes comments that say "fall through" as annotations, clang
doesn't
2. GCC doesn't warn on "case N: foo(); default: break;", clang does
3. GCC doesn't warn when the case contains a switch, but falls through
the outer case.
I will enable the warning separately in a follow-up patch so that it can
be cleanly reverted if necessary.
Reviewers: alexfh, rsmith, lattner, rtrieu, EricWF, bollu
Differential Revision: https://reviews.llvm.org/D53950
llvm-svn: 345882
2018-11-01 20:54:45 +01:00
|
|
|
break;
|
2015-12-16 20:36:12 +01:00
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-06 21:13:38 +02:00
|
|
|
// There are certain anti-dependencies that cannot be ignored.
|
|
|
|
// Specifically:
|
2017-12-07 11:40:31 +01:00
|
|
|
// J2_call ... implicit-def %r0 ; SUJ
|
2016-05-06 21:13:38 +02:00
|
|
|
// R0 = ... ; SUI
|
|
|
|
// Those cannot be packetized together, since the call will observe
|
|
|
|
// the effect of the assignment to R0.
|
2017-02-17 23:14:51 +01:00
|
|
|
if ((DepType == SDep::Anti || DepType == SDep::Output) && J.isCall()) {
|
2016-05-06 21:13:38 +02:00
|
|
|
// Check if I defines any volatile register. We should also check
|
|
|
|
// registers that the call may read, but these happen to be a
|
|
|
|
// subset of the volatile register set.
|
2017-02-17 23:14:51 +01:00
|
|
|
for (const MachineOperand &Op : I.operands()) {
|
|
|
|
if (Op.isReg() && Op.isDef()) {
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register R = Op.getReg();
|
2017-02-17 23:14:51 +01:00
|
|
|
if (!J.readsRegister(R, HRI) && !J.modifiesRegister(R, HRI))
|
|
|
|
continue;
|
|
|
|
} else if (!Op.isRegMask()) {
|
|
|
|
// If I has a regmask assume dependency.
|
2016-05-06 21:13:38 +02:00
|
|
|
continue;
|
2017-02-17 23:14:51 +01:00
|
|
|
}
|
2016-05-06 21:13:38 +02:00
|
|
|
FoundSequentialDependence = true;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Skip over remaining anti-dependences. Two instructions that are
|
|
|
|
// anti-dependent can share a packet, since in most such cases all
|
|
|
|
// operands are read before any modifications take place.
|
|
|
|
// The exceptions are branch and call instructions, since they are
|
|
|
|
// executed after all other instructions have completed (at least
|
|
|
|
// conceptually).
|
2015-12-16 20:36:12 +01:00
|
|
|
if (DepType != SDep::Anti) {
|
|
|
|
FoundSequentialDependence = true;
|
|
|
|
break;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
if (FoundSequentialDependence) {
|
|
|
|
Dependence = true;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool HexagonPacketizerList::isLegalToPruneDependencies(SUnit *SUI, SUnit *SUJ) {
|
2016-07-29 23:49:42 +02:00
|
|
|
assert(SUI->getInstr() && SUJ->getInstr());
|
|
|
|
MachineInstr &I = *SUI->getInstr();
|
|
|
|
MachineInstr &J = *SUJ->getInstr();
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2017-05-03 22:10:36 +02:00
|
|
|
bool Coexist = !cannotCoexist(I, J);
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2017-05-03 22:10:36 +02:00
|
|
|
if (Coexist && !Dependence)
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Check if the instruction was promoted to a dot-new. If so, demote it
|
|
|
|
// back into a dot-old.
|
|
|
|
if (PromotedToDotNew)
|
|
|
|
demoteToDotOld(I);
|
|
|
|
|
|
|
|
cleanUpDotCur();
|
|
|
|
// Check if the instruction (must be a store) was glued with an allocframe
|
|
|
|
// instruction. If so, restore its offset to its original value, i.e. use
|
|
|
|
// current SP instead of caller's SP.
|
|
|
|
if (GlueAllocframeStore) {
|
2016-07-26 16:24:46 +02:00
|
|
|
useCalleesSP(I);
|
|
|
|
GlueAllocframeStore = false;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
2017-10-11 17:51:44 +02:00
|
|
|
|
|
|
|
if (ChangedOffset != INT64_MAX)
|
|
|
|
undoChangedOffset(I);
|
2017-10-11 23:20:43 +02:00
|
|
|
|
|
|
|
if (GlueToNewValueJump) {
|
|
|
|
// Putting I and J together would prevent the new-value jump from being
|
|
|
|
// packetized with the producer. In that case I and J must be separated.
|
|
|
|
GlueToNewValueJump = false;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-09-04 23:07:27 +02:00
|
|
|
if (!Coexist)
|
|
|
|
return false;
|
|
|
|
|
2017-10-11 23:20:43 +02:00
|
|
|
if (ChangedOffset == INT64_MAX && updateOffset(SUI, SUJ)) {
|
2017-10-11 17:51:44 +02:00
|
|
|
FoundSequentialDependence = false;
|
|
|
|
Dependence = false;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
return false;
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
|
2017-12-11 19:57:54 +01:00
|
|
|
|
|
|
|
bool HexagonPacketizerList::foundLSInPacket() {
|
|
|
|
bool FoundLoad = false;
|
|
|
|
bool FoundStore = false;
|
|
|
|
|
|
|
|
for (auto MJ : CurrentPacketMIs) {
|
|
|
|
unsigned Opc = MJ->getOpcode();
|
|
|
|
if (Opc == Hexagon::S2_allocframe || Opc == Hexagon::L2_deallocframe)
|
|
|
|
continue;
|
|
|
|
if (HII->isMemOp(*MJ))
|
|
|
|
continue;
|
|
|
|
if (MJ->mayLoad())
|
|
|
|
FoundLoad = true;
|
|
|
|
if (MJ->mayStore() && !HII->isNewValueStore(*MJ))
|
|
|
|
FoundStore = true;
|
|
|
|
}
|
|
|
|
return FoundLoad && FoundStore;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
MachineBasicBlock::iterator
|
2016-02-27 20:09:00 +01:00
|
|
|
HexagonPacketizerList::addToPacket(MachineInstr &MI) {
|
2016-07-29 23:49:42 +02:00
|
|
|
MachineBasicBlock::iterator MII = MI.getIterator();
|
2016-02-27 20:09:00 +01:00
|
|
|
MachineBasicBlock *MBB = MI.getParent();
|
2017-05-02 20:12:19 +02:00
|
|
|
|
2017-09-29 00:27:31 +02:00
|
|
|
if (CurrentPacketMIs.empty())
|
2017-05-02 20:12:19 +02:00
|
|
|
PacketStalls = false;
|
|
|
|
PacketStalls |= producesStall(MI);
|
|
|
|
|
2018-04-06 20:19:22 +02:00
|
|
|
if (MI.isImplicitDef()) {
|
|
|
|
// Add to the packet to allow subsequent instructions to be checked
|
|
|
|
// properly.
|
|
|
|
CurrentPacketMIs.push_back(&MI);
|
2015-12-16 20:36:12 +01:00
|
|
|
return MII;
|
2018-04-06 20:19:22 +02:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
assert(ResourceTracker->canReserveResources(MI));
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
bool ExtMI = HII->isExtended(MI) || HII->isConstExtended(MI);
|
2015-12-16 20:36:12 +01:00
|
|
|
bool Good = true;
|
|
|
|
|
|
|
|
if (GlueToNewValueJump) {
|
2016-02-27 20:09:00 +01:00
|
|
|
MachineInstr &NvjMI = *++MII;
|
2015-12-16 20:36:12 +01:00
|
|
|
// We need to put both instructions in the same packet: MI and NvjMI.
|
|
|
|
// Either of them can require a constant extender. Try to add both to
|
|
|
|
// the current packet, and if that fails, end the packet and start a
|
|
|
|
// new one.
|
|
|
|
ResourceTracker->reserveResources(MI);
|
|
|
|
if (ExtMI)
|
|
|
|
Good = tryAllocateResourcesForConstExt(true);
|
|
|
|
|
2016-07-29 23:49:42 +02:00
|
|
|
bool ExtNvjMI = HII->isExtended(NvjMI) || HII->isConstExtended(NvjMI);
|
2015-12-16 20:36:12 +01:00
|
|
|
if (Good) {
|
|
|
|
if (ResourceTracker->canReserveResources(NvjMI))
|
|
|
|
ResourceTracker->reserveResources(NvjMI);
|
|
|
|
else
|
|
|
|
Good = false;
|
|
|
|
}
|
|
|
|
if (Good && ExtNvjMI)
|
|
|
|
Good = tryAllocateResourcesForConstExt(true);
|
2012-05-03 23:52:53 +02:00
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
if (!Good) {
|
|
|
|
endPacket(MBB, MI);
|
2012-05-03 23:52:53 +02:00
|
|
|
assert(ResourceTracker->canReserveResources(MI));
|
|
|
|
ResourceTracker->reserveResources(MI);
|
2015-12-16 20:36:12 +01:00
|
|
|
if (ExtMI) {
|
|
|
|
assert(canReserveResourcesForConstExt());
|
|
|
|
tryAllocateResourcesForConstExt(true);
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
assert(ResourceTracker->canReserveResources(NvjMI));
|
|
|
|
ResourceTracker->reserveResources(NvjMI);
|
|
|
|
if (ExtNvjMI) {
|
|
|
|
assert(canReserveResourcesForConstExt());
|
|
|
|
reserveResourcesForConstExt();
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|
|
|
|
}
|
2016-02-27 20:09:00 +01:00
|
|
|
CurrentPacketMIs.push_back(&MI);
|
|
|
|
CurrentPacketMIs.push_back(&NvjMI);
|
2012-05-03 23:52:53 +02:00
|
|
|
return MII;
|
2015-12-16 20:36:12 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
ResourceTracker->reserveResources(MI);
|
|
|
|
if (ExtMI && !tryAllocateResourcesForConstExt(true)) {
|
|
|
|
endPacket(MBB, MI);
|
|
|
|
if (PromotedToDotNew)
|
2016-07-29 23:49:42 +02:00
|
|
|
demoteToDotOld(MI);
|
2016-07-26 16:24:46 +02:00
|
|
|
if (GlueAllocframeStore) {
|
2016-07-29 23:49:42 +02:00
|
|
|
useCalleesSP(MI);
|
2016-07-26 16:24:46 +02:00
|
|
|
GlueAllocframeStore = false;
|
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
ResourceTracker->reserveResources(MI);
|
|
|
|
reserveResourcesForConstExt();
|
|
|
|
}
|
|
|
|
|
2016-02-27 20:09:00 +01:00
|
|
|
CurrentPacketMIs.push_back(&MI);
|
2015-12-16 20:36:12 +01:00
|
|
|
return MII;
|
|
|
|
}
|
|
|
|
|
|
|
|
void HexagonPacketizerList::endPacket(MachineBasicBlock *MBB,
|
2018-08-17 16:24:24 +02:00
|
|
|
MachineBasicBlock::iterator EndMI) {
|
|
|
|
// Replace VLIWPacketizerList::endPacket(MBB, EndMI).
|
2019-09-09 15:17:55 +02:00
|
|
|
LLVM_DEBUG({
|
|
|
|
if (!CurrentPacketMIs.empty()) {
|
|
|
|
dbgs() << "Finalizing packet:\n";
|
|
|
|
unsigned Idx = 0;
|
|
|
|
for (MachineInstr *MI : CurrentPacketMIs) {
|
|
|
|
unsigned R = ResourceTracker->getUsedResources(Idx++);
|
|
|
|
dbgs() << " * [res:0x" << utohexstr(R) << "] " << *MI;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
});
|
2017-12-11 19:57:54 +01:00
|
|
|
|
|
|
|
bool memShufDisabled = getmemShufDisabled();
|
|
|
|
if (memShufDisabled && !foundLSInPacket()) {
|
|
|
|
setmemShufDisabled(false);
|
2018-05-14 14:53:11 +02:00
|
|
|
LLVM_DEBUG(dbgs() << " Not added to NoShufPacket\n");
|
2017-12-11 19:57:54 +01:00
|
|
|
}
|
|
|
|
memShufDisabled = getmemShufDisabled();
|
|
|
|
|
2018-08-17 16:24:24 +02:00
|
|
|
OldPacketMIs.clear();
|
|
|
|
for (MachineInstr *MI : CurrentPacketMIs) {
|
|
|
|
MachineBasicBlock::instr_iterator NextMI = std::next(MI->getIterator());
|
|
|
|
for (auto &I : make_range(HII->expandVGatherPseudo(*MI), NextMI))
|
|
|
|
OldPacketMIs.push_back(&I);
|
|
|
|
}
|
|
|
|
CurrentPacketMIs.clear();
|
2017-12-11 19:57:54 +01:00
|
|
|
|
2018-08-17 16:24:24 +02:00
|
|
|
if (OldPacketMIs.size() > 1) {
|
|
|
|
MachineBasicBlock::instr_iterator FirstMI(OldPacketMIs.front());
|
|
|
|
MachineBasicBlock::instr_iterator LastMI(EndMI.getInstrIterator());
|
|
|
|
finalizeBundle(*MBB, FirstMI, LastMI);
|
2017-12-11 19:57:54 +01:00
|
|
|
auto BundleMII = std::prev(FirstMI);
|
|
|
|
if (memShufDisabled)
|
|
|
|
HII->setBundleNoShuf(BundleMII);
|
|
|
|
|
|
|
|
setmemShufDisabled(false);
|
|
|
|
}
|
|
|
|
|
2020-01-13 23:07:30 +01:00
|
|
|
PacketHasDuplex = false;
|
|
|
|
PacketHasSLOT0OnlyInsn = false;
|
2017-12-11 19:57:54 +01:00
|
|
|
ResourceTracker->clearResources();
|
2018-05-14 14:53:11 +02:00
|
|
|
LLVM_DEBUG(dbgs() << "End packet\n");
|
2015-12-16 20:36:12 +01:00
|
|
|
}
|
|
|
|
|
2016-02-27 20:09:00 +01:00
|
|
|
bool HexagonPacketizerList::shouldAddToPacket(const MachineInstr &MI) {
|
2018-08-17 16:24:24 +02:00
|
|
|
if (Minimal)
|
|
|
|
return false;
|
2020-01-13 23:07:30 +01:00
|
|
|
|
|
|
|
// Constrainst for not packetizing this MI with existing instructions in a
|
|
|
|
// packet.
|
|
|
|
// MI is a store instruction.
|
|
|
|
// CurrentPacketMIs has a SLOT0 only instruction with constraint
|
|
|
|
// A_RESTRICT_NOSLOT1_STORE/isRestrictNoSlot1Store.
|
|
|
|
if (MI.mayStore() && isPureSlot0InsnWithNoSlot1Store(MI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (producesStall(MI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// If TinyCore with Duplexes is enabled, check if this MI can form a Duplex
|
|
|
|
// with any other instruction in the existing packet.
|
|
|
|
auto &HST = MI.getParent()->getParent()->getSubtarget<HexagonSubtarget>();
|
|
|
|
// Constraint 1: Only one duplex allowed per packet.
|
|
|
|
// Constraint 2: Consider duplex checks only if there is atleast one
|
|
|
|
// instruction in a packet.
|
|
|
|
// Constraint 3: If one of the existing instructions in the packet has a
|
|
|
|
// SLOT0 only instruction that can not be duplexed, do not attempt to form
|
|
|
|
// duplexes. (TODO: This will invalidate the L4_return* instructions to form a
|
|
|
|
// duplex)
|
|
|
|
if (HST.isTinyCoreWithDuplex() && CurrentPacketMIs.size() > 0 &&
|
|
|
|
!PacketHasDuplex) {
|
|
|
|
// Check for SLOT0 only non-duplexable instruction in packet.
|
|
|
|
for (auto &MJ : CurrentPacketMIs)
|
|
|
|
PacketHasSLOT0OnlyInsn |= HII->isPureSlot0(*MJ);
|
|
|
|
// Get the Big Core Opcode (dup_*).
|
|
|
|
int Opcode = HII->getDuplexOpcode(MI, false);
|
|
|
|
if (Opcode >= 0) {
|
|
|
|
// We now have an instruction that can be duplexed.
|
|
|
|
for (auto &MJ : CurrentPacketMIs) {
|
|
|
|
if (HII->isDuplexPair(MI, *MJ) && !PacketHasSLOT0OnlyInsn) {
|
|
|
|
PacketHasDuplex = true;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// If it can not be duplexed, check if there is a valid transition in DFA
|
|
|
|
// with the original opcode.
|
|
|
|
MachineInstr &MIRef = const_cast<MachineInstr &>(MI);
|
|
|
|
MIRef.setDesc(HII->get(Opcode));
|
|
|
|
return ResourceTracker->canReserveResources(MIRef);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
bool HexagonPacketizerList::isPureSlot0InsnWithNoSlot1Store(
|
|
|
|
const MachineInstr &MI) {
|
|
|
|
bool noSlot1Store = false;
|
|
|
|
bool isSlot0Only = false;
|
|
|
|
for (auto J : CurrentPacketMIs) {
|
|
|
|
noSlot1Store |= HII->isRestrictNoSlot1Store(*J);
|
|
|
|
isSlot0Only |= HII->isPureSlot0(*J);
|
|
|
|
}
|
|
|
|
|
|
|
|
return (noSlot1Store && isSlot0Only);
|
2015-12-16 20:36:12 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// V60 forward scheduling.
|
2016-07-29 23:49:42 +02:00
|
|
|
bool HexagonPacketizerList::producesStall(const MachineInstr &I) {
|
2017-05-02 20:12:19 +02:00
|
|
|
// If the packet already stalls, then ignore the stall from a subsequent
|
|
|
|
// instruction in the same packet.
|
|
|
|
if (PacketStalls)
|
|
|
|
return false;
|
|
|
|
|
2015-12-16 20:36:12 +01:00
|
|
|
// Check whether the previous packet is in a different loop. If this is the
|
|
|
|
// case, there is little point in trying to avoid a stall because that would
|
|
|
|
// favor the rare case (loop entry) over the common case (loop iteration).
|
|
|
|
//
|
|
|
|
// TODO: We should really be able to check all the incoming edges if this is
|
|
|
|
// the first packet in a basic block, so we can avoid stalls from the loop
|
|
|
|
// backedge.
|
|
|
|
if (!OldPacketMIs.empty()) {
|
|
|
|
auto *OldBB = OldPacketMIs.front()->getParent();
|
2016-07-29 23:49:42 +02:00
|
|
|
auto *ThisBB = I.getParent();
|
2015-12-16 20:36:12 +01:00
|
|
|
if (MLI->getLoopFor(OldBB) != MLI->getLoopFor(ThisBB))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2017-05-03 22:10:36 +02:00
|
|
|
SUnit *SUI = MIToSUnit[const_cast<MachineInstr *>(&I)];
|
2017-05-02 20:12:19 +02:00
|
|
|
|
2018-04-06 20:13:11 +02:00
|
|
|
// If the latency is 0 and there is a data dependence between this
|
|
|
|
// instruction and any instruction in the current packet, we disregard any
|
|
|
|
// potential stalls due to the instructions in the previous packet. Most of
|
|
|
|
// the instruction pairs that can go together in the same packet have 0
|
|
|
|
// latency between them. The exceptions are
|
|
|
|
// 1. NewValueJumps as they're generated much later and the latencies can't
|
|
|
|
// be changed at that point.
|
|
|
|
// 2. .cur instructions, if its consumer has a 0 latency successor (such as
|
|
|
|
// .new). In this case, the latency between .cur and the consumer stays
|
|
|
|
// non-zero even though we can have both .cur and .new in the same packet.
|
|
|
|
// Changing the latency to 0 is not an option as it causes software pipeliner
|
|
|
|
// to not pipeline in some cases.
|
2017-05-03 22:10:36 +02:00
|
|
|
|
|
|
|
// For Example:
|
|
|
|
// {
|
|
|
|
// I1: v6.cur = vmem(r0++#1)
|
|
|
|
// I2: v7 = valign(v6,v4,r2)
|
|
|
|
// I3: vmem(r5++#1) = v7.new
|
|
|
|
// }
|
|
|
|
// Here I2 and I3 has 0 cycle latency, but I1 and I2 has 2.
|
2015-12-16 20:36:12 +01:00
|
|
|
|
2017-05-03 22:10:36 +02:00
|
|
|
for (auto J : CurrentPacketMIs) {
|
|
|
|
SUnit *SUJ = MIToSUnit[J];
|
|
|
|
for (auto &Pred : SUI->Preds)
|
2018-04-06 20:13:11 +02:00
|
|
|
if (Pred.getSUnit() == SUJ)
|
|
|
|
if ((Pred.getLatency() == 0 && Pred.isAssignedRegDep()) ||
|
|
|
|
HII->isNewValueJump(I) || HII->isToBeScheduledASAP(*J, I))
|
|
|
|
return false;
|
2017-05-03 22:10:36 +02:00
|
|
|
}
|
2015-12-16 20:36:12 +01:00
|
|
|
|
2017-05-03 22:10:36 +02:00
|
|
|
// Check if the latency is greater than one between this instruction and any
|
|
|
|
// instruction in the previous packet.
|
|
|
|
for (auto J : OldPacketMIs) {
|
|
|
|
SUnit *SUJ = MIToSUnit[J];
|
|
|
|
for (auto &Pred : SUI->Preds)
|
|
|
|
if (Pred.getSUnit() == SUJ && Pred.getLatency() > 1)
|
2015-12-16 20:36:12 +01:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2012-05-03 23:52:53 +02:00
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// Public Constructor Functions
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
2018-08-17 16:24:24 +02:00
|
|
|
FunctionPass *llvm::createHexagonPacketizer(bool Minimal) {
|
|
|
|
return new HexagonPacketizer(Minimal);
|
2012-05-03 23:52:53 +02:00
|
|
|
}
|