mirror of
https://github.com/RPCS3/llvm-mirror.git
synced 2024-10-22 20:43:44 +02:00
65848e30b4
Summary: The original heuristic to break critical edge during machine sink is relatively conservertive: when there is only one instruction sinkable to the critical edge, it is likely that the machine sink pass will not break the critical edge. This leads to many speculative instructions executed at runtime. However, with profile info, we could model the splitting benefits: if the critical edge has 50% taken rate, it would always be beneficial to split the critical edge to avoid the speculated runtime instructions. This patch uses profile to guide critical edge splitting in machine sink pass. The performance impact on speccpu2006 on Intel sandybridge machines: spec/2006/fp/C++/444.namd 25.3 +0.26% spec/2006/fp/C++/447.dealII 45.96 -0.10% spec/2006/fp/C++/450.soplex 41.97 +1.49% spec/2006/fp/C++/453.povray 36.83 -0.96% spec/2006/fp/C/433.milc 23.81 +0.32% spec/2006/fp/C/470.lbm 41.17 +0.34% spec/2006/fp/C/482.sphinx3 48.13 +0.69% spec/2006/int/C++/471.omnetpp 22.45 +3.25% spec/2006/int/C++/473.astar 21.35 -2.06% spec/2006/int/C++/483.xalancbmk 36.02 -2.39% spec/2006/int/C/400.perlbench 33.7 -0.17% spec/2006/int/C/401.bzip2 22.9 +0.52% spec/2006/int/C/403.gcc 32.42 -0.54% spec/2006/int/C/429.mcf 39.59 +0.19% spec/2006/int/C/445.gobmk 26.98 -0.00% spec/2006/int/C/456.hmmer 24.52 -0.18% spec/2006/int/C/458.sjeng 28.26 +0.02% spec/2006/int/C/462.libquantum 55.44 +3.74% spec/2006/int/C/464.h264ref 46.67 -0.39% geometric mean +0.20% Manually checked 473 and 471 to verify the diff is in the noise range. Reviewers: rengolin, davidxl Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D24818 llvm-svn: 284757
22 lines
453 B
LLVM
22 lines
453 B
LLVM
; RUN: llc < %s -mtriple=x86_64-pc-linux | FileCheck %s
|
|
|
|
; Checks if movl $1 is sinked to critical edge.
|
|
; CHECK-NOT: movl $1
|
|
; CHECK: jbe
|
|
; CHECK: movl $1
|
|
define i32 @test(i32 %n, i32 %k) nounwind {
|
|
entry:
|
|
%cmp = icmp ugt i32 %k, %n
|
|
br i1 %cmp, label %ifthen, label %ifend, !prof !1
|
|
|
|
ifthen:
|
|
%y = add i32 %k, 2
|
|
br label %ifend
|
|
|
|
ifend:
|
|
%ret = phi i32 [ 1, %entry ] , [ %y, %ifthen]
|
|
ret i32 %ret
|
|
}
|
|
|
|
!1 = !{!"branch_weights", i32 100, i32 1}
|