RPCS3/llvm-mirror
1
0
Fork 0
mirror of https://github.com/RPCS3/llvm-mirror.git synced 2024-10-22 12:33:33 +02:00
Code Issues Projects Releases Wiki Activity
60,718 Commits 4 Branches 5 Tags 704 MiB
0d88ad2de1
Commit Graph

4330 Commits

Author SHA1 Message Date
Dan Gohman
e980525516 Remove this debug output. The MachineFunction will be printed once all of 
instruction selection is done; it's confusing to see parts of it printed,
while other parts are omitted, along the way.

llvm-svn: 102771
 2010-04-30 21:21:21 +00:00
Dan Gohman
066b8d3640 EmitDbgValue doesn't need its EdgeMapping argument. 
llvm-svn: 102742
 2010-04-30 19:35:33 +00:00
Dan Gohman
e9ff394082 Apply a patch from Jan Sjodin to fix a compiler abort on vector 
comparisons sign-extended to a different bitwidth than the
comparison operands.

llvm-svn: 102721
 2010-04-30 17:19:19 +00:00
Dan Gohman
140e0899ad Temporarily disable SelectionDAG kill flags, which are causing trouble. 
llvm-svn: 102680
 2010-04-30 00:32:51 +00:00
Dan Gohman
1534ad2d28 Set register kill flags on the SelectionDAG path, at least in the 
easy cases.

llvm-svn: 102678
 2010-04-30 00:08:21 +00:00
Devang Patel
bdfc01f418 Refactor. 
llvm-svn: 102661
 2010-04-29 20:40:36 +00:00
Devang Patel
1e28f36308 DO not push DBG_VALUE machine instructions for inlined fuction arguments in entry block. 
llvm-svn: 102653
 2010-04-29 18:50:36 +00:00
Evan Cheng
b9fe4fd40c Add comment. 
llvm-svn: 102606
 2010-04-29 06:58:53 +00:00
Evan Cheng
ba7dcad569 Re-enable 102565 with fixes. 
llvm-svn: 102602
 2010-04-29 06:33:38 +00:00
Evan Cheng
3e9545cfb4 Temporarily disable my changes to unbreak the build. 
llvm-svn: 102590
 2010-04-29 03:34:19 +00:00
Evan Cheng
053000f3f5 Do not generate duplicate dbg_value instructions for function arguments. 
llvm-svn: 102585
 2010-04-29 01:40:30 +00:00
Dan Gohman
ec9e1d8a88 Fix missing #include. 
llvm-svn: 102584
 2010-04-29 01:39:13 +00:00
Evan Cheng
801b8e5530 Avoid emitting a dbg_value machineinstr that's not going to be inserted into entry block. 
llvm-svn: 102581
 2010-04-29 01:23:55 +00:00
Evan Cheng
d08e8f2b24 Check Reg against zero. 
llvm-svn: 102573
 2010-04-29 00:59:34 +00:00
Devang Patel
84e3ddd87c tidy up. 
llvm-svn: 102558
 2010-04-28 23:24:13 +00:00
Evan Cheng
a02c9072fc Replace r102368 with code that's less fragile. This creates DBG_VALUE instructions for function arguments early and insert them after instruction selection is done. 
llvm-svn: 102554
 2010-04-28 23:08:54 +00:00
Devang Patel
181c86e4e7 While lowering dbg_declare, emit DBG_VALUE machine instruction if alloca matching llvm.dbg.declare intrinsic is missing. 
llvm-svn: 102513
 2010-04-28 19:27:33 +00:00
Evan Cheng
4561d60a2b Try operation promotion only if regular dag combine and target-specific ones failed to do anything. 
llvm-svn: 102492
 2010-04-28 07:10:39 +00:00
Devang Patel
8b3c1ffb8b Ignore DBG_VALUE instructions that points to undef values. 
llvm-svn: 102463
 2010-04-27 20:54:45 +00:00
Evan Cheng
94bcca7004 - When legal, promote a load to zextload rather than ext load. 
- Catch more further dag combine opportunities as result of operand promotion, e.g. (i32 anyext (i16 trunc (i32 x))) -> (i32 x)

llvm-svn: 102455
 2010-04-27 19:48:13 +00:00
Dale Johannesen
244d2bdb24 Revert a small part of 102372; this fixes at least one 
of the dbg testsuite regressions.  I don't think this is
really the right fix; this change exposed an existing problem
upstream somewhere.

llvm-svn: 102410
 2010-04-27 02:10:05 +00:00
Bob Wilson
6547515094 Avoid adding a null MD node operand, which crashes with "-debug" when trying 
to print the operand.

llvm-svn: 102395
 2010-04-26 22:56:56 +00:00
Dale Johannesen
2f1de9e0c1 Remove crufty comments. 
llvm-svn: 102380
 2010-04-26 20:48:54 +00:00
Dale Johannesen
4327f03110 Add DBG_VALUE handling for byval parameters; this 
produces a comment on targets that support it, but
the Dwarf writer is not hooked up yet.

llvm-svn: 102372
 2010-04-26 20:06:49 +00:00
Evan Cheng
dc0ce1eae8 - Move TargetLowering::EmitTargetCodeForFrameDebugValue to TargetInstrInfo and rename it to emitFrameIndexDebugValue. 
- Teach spiller to modify DBG_VALUE instructions to reference spill slots.

llvm-svn: 102323
 2010-04-26 07:38:55 +00:00
Dale Johannesen
d27eedab6d Stop abusing EmitInstrWithCustomInserter for target-dependent 
form of DEBUG_VALUE, as it doesn't have reasonable default
behavior for unsupported targets.  Add a new hook instead.
No functional change.

llvm-svn: 102320
 2010-04-25 21:33:54 +00:00
Dale Johannesen
d33a5ec459 Add comment re byval args. Doesn't actually work this way yet. 
xs

llvm-svn: 102316
 2010-04-25 21:03:54 +00:00
Evan Cheng
3eedf18f4c When a load operand is promoted to an extload, replace other uses with uses of extload result truncated. 
llvm-svn: 102236
 2010-04-24 04:43:44 +00:00
Dan Gohman
42c3d3fe44 Apply a fix for a vector setcc dagcombine from Jan Sjodin. No 
testcase yet, as the testcase now fails downstream.

llvm-svn: 102228
 2010-04-24 01:17:30 +00:00
Evan Cheng
34f01afb97 Code refactoring. 
llvm-svn: 102202
 2010-04-23 19:10:30 +00:00
Dan Gohman
6680b97d89 Move FastISel's HandlePHINodesInSuccessorBlocks call down into FastISel 
itself too.

llvm-svn: 102176
 2010-04-23 15:29:50 +00:00
Dan Gohman
391423b743 Sink SelectionDAGBuilder's HandlePHINodesInSuccessorBlocks down 
into SelectionDAGBuilder itself.

llvm-svn: 102128
 2010-04-22 20:55:53 +00:00
Dan Gohman
d819e7fc95 Move HandlePHINodesInSuccessorBlocks functions out of SelectionDAGISel 
and into SelectionDAGBuilder and FastISel.

llvm-svn: 102123
 2010-04-22 20:46:50 +00:00
Evan Cheng
da832d5c85 - It's not safe to promote rotates (at least not trivially). 
- Some code refactoring.

llvm-svn: 102111
 2010-04-22 20:19:46 +00:00
Dan Gohman
56b517480e Fix a comment. 
llvm-svn: 102110
 2010-04-22 20:06:42 +00:00
Dan Gohman
a177e59e3e Move PHINodesToUpdate out of SelectionDAGBuilder and into 
FunctionLoweringInfo, as it isn't SelectionDAG-specific. This isn't
completely natural, as PHI node state is not per-function but rather
per-basic-block, however there's currently no other convenient
per-basic-block state to group it with.

llvm-svn: 102109
 2010-04-22 19:55:20 +00:00
Dan Gohman
4ff2d817a3 Add more const qualifiers on TargetMachine and friends. 
llvm-svn: 101977
 2010-04-21 01:34:56 +00:00
Dan Gohman
1d3532d925 Move several SelectionDAG-independent utility functions out of the 
SelectionDAG directory and into a new Analysis.cpp file.

llvm-svn: 101975
 2010-04-21 01:22:34 +00:00
Dan Gohman
570b621976 Add another variant of this test which found a place where 
CodeGen's ComputeMaskedBits was being over-conservative when computing
bits for an ADD.

llvm-svn: 101963
 2010-04-21 00:19:28 +00:00
Dale Johannesen
510282d54b Because of the EMMS problem, right now we have to support 
user-defined operations that use MMX register types, but
the compiler shouldn't generate them on its own.  This adds
a Synthesizable abstraction to represent this, and changes
the vector widening computation so it won't produce MMX types.
(The motivation is to remove noise from the ABI compatibility
part of the gcc test suite, which has some breakage right now.)

llvm-svn: 101951
 2010-04-20 22:34:09 +00:00
Dan Gohman
44ab9ed9b8 Sink the CopyToExportRegsIfNeeded calls out of SelectionDAGISel 
into SelectionDAGBuilder. This avoids a separate pass over the
instructions, and has the side effect of providing debug location
information to the copy.

llvm-svn: 101906
 2010-04-20 15:03:56 +00:00
Dan Gohman
3915c2cc7c Don't send PHI nodes down to SelectionDAGBuilder of FastISel, since 
they end up doing nothing.

llvm-svn: 101904
 2010-04-20 15:00:41 +00:00
Dan Gohman
0c1f92afe1 Sink this use_empty() check into isUsedOutsideOfDefiningBlock. 
llvm-svn: 101902
 2010-04-20 14:50:13 +00:00
Dan Gohman
c276def9e9 If a PHI node somehow has debug info, propogate it to the MachineInstr PHI. 
llvm-svn: 101901
 2010-04-20 14:48:02 +00:00
Dan Gohman
47859e6848 Don't iterate through the whole block just to find the PHI nodes. 
llvm-svn: 101900
 2010-04-20 14:46:25 +00:00
Dan Gohman
5f8489396e Delete a redundant return statement. 
llvm-svn: 101860
 2010-04-20 01:58:20 +00:00
Bill Wendling
887dac2aa6 The visitXOR method can return the same SDNode. If so, we don't want to delete 
it as it's not dead.

llvm-svn: 101855
 2010-04-20 01:25:01 +00:00
Dan Gohman
5d47f180a2 Remove this debug output; it isn't that useful, and it's incomplete 
in the case where a basic block is split.

llvm-svn: 101850
 2010-04-20 00:56:44 +00:00
Dan Gohman
e8387b1250 Sink DebugLoc handling out of SelectionDAGISel into FastISel and 
SelectionDAGBuilder, where it doesn't have to be as complicated.

llvm-svn: 101848
 2010-04-20 00:48:35 +00:00
Dan Gohman
c64745ba43 Remove MachineFunction's DefaultDebugLoc member, and make DwarfDebug.cpp 
responsible for figuring out what that's supposed to be on its own.

llvm-svn: 101844
 2010-04-20 00:37:27 +00:00
Dan Gohman
1d05054dc1 Reapply the removal of SelectionDAGISel's BB, with a fix for the case 
where multiple blocks are emitted; functions which do this need to return
the new BB so that their callers can stay current.

llvm-svn: 101843
 2010-04-20 00:29:35 +00:00
Dan Gohman
744e2b34b0 Revert 101825, which is causing trouble. 
llvm-svn: 101832
 2010-04-19 23:34:15 +00:00
Dan Gohman
94383f9d34 Eliminate SelectionDAGISel's "current block" member. Just pass it as 
an argument to things that need it.

llvm-svn: 101825
 2010-04-19 22:51:14 +00:00
Dan Gohman
b02e2f6c92 Eliminate the CurMBB member from SelectionDAGBuilder. For places that 
need it, just pass around the parent block of the current instruction
explicitly.

llvm-svn: 101822
 2010-04-19 22:41:47 +00:00
Evan Cheng
8efe9e0351 More progress on promoting i16 operations to i32 for x86. Work in progress. 
llvm-svn: 101808
 2010-04-19 19:29:22 +00:00
Dan Gohman
6bcd9dabb7 Give SelectionDAG a TargetMachine too, rather than having it 
fetch one from the MachineFunction.

llvm-svn: 101807
 2010-04-19 19:22:07 +00:00
Evan Cheng
d65a23c1e6 More 80 col violation. 
llvm-svn: 101806
 2010-04-19 19:17:44 +00:00
Dan Gohman
f1f21fb3c6 Code that needs a TargetMachine should have access to one directly, rather 
than just getting one through a TargetLowering.

llvm-svn: 101802
 2010-04-19 19:05:59 +00:00
Dan Gohman
3c58144bfd Move isInTailCallPosition out of SelectionDAGBuilder, as it isn't 
SelectionDAG-specific.

llvm-svn: 101801
 2010-04-19 18:41:46 +00:00
Dan Gohman
fba34ef042 Fix -Wcast-qual warnings. 
llvm-svn: 101655
 2010-04-17 17:42:52 +00:00
Dan Gohman
6065ff317b Delete now-unnecessary const_casts. 
llvm-svn: 101637
 2010-04-17 15:32:28 +00:00
Dan Gohman
a0f855157e Use const qualifiers with TargetLowering. This eliminates several 
const_casts, and it reinforces the design of the Target classes being
immutable.

SelectionDAGISel::IsLegalToFold is now a static member function, because
PIC16 uses it in an unconventional way. There is more room for API
cleanup here.

And PIC16's AsmPrinter no longer uses TargetLowering.

llvm-svn: 101635
 2010-04-17 15:26:15 +00:00
Evan Cheng
6442d111dd More work to allow dag combiner to promote 16-bit ops to 32-bit. 
llvm-svn: 101621
 2010-04-17 06:13:15 +00:00
Evan Cheng
aa2f3449c4 Another 80 col violation. 
llvm-svn: 101620
 2010-04-17 06:12:32 +00:00
Eric Christopher
e78496e5f1 Revert 101465, it broke internal OpenGL testing. 
Probably the best way to know that all getOperand() calls have been handled
is to replace that API instead of updating.

llvm-svn: 101579
 2010-04-16 23:37:20 +00:00
Evan Cheng
b55929892f (i32 sext_in_reg (i32 aext (i16 x)), i16) -> (i32 sext x). No known test case until -promote-16bit is enabled. 
llvm-svn: 101551
 2010-04-16 22:26:19 +00:00
Dan Gohman
b3afc2a215 Create a new TargetSelectionDAGInfo class. This will eventually acquire 
SelectionDAG-specific parts of TargetLowering.

llvm-svn: 101537
 2010-04-16 21:12:11 +00:00
Dan Gohman
2912cb780f Commit this, which should have accompanied 101531. 
llvm-svn: 101532
 2010-04-16 20:22:43 +00:00
Evan Cheng
80afc6964c 80 col. 
llvm-svn: 101501
 2010-04-16 17:58:41 +00:00
Evan Cheng
e541446e11 80 col. 
llvm-svn: 101500
 2010-04-16 17:57:59 +00:00
Dan Gohman
e9683c52da Avoid creating virtual registers for unused values. 
llvm-svn: 101480
 2010-04-16 17:15:02 +00:00
Dan Gohman
30de6c2b1c Fix an assertion string. 
llvm-svn: 101478
 2010-04-16 16:55:18 +00:00
Dan Gohman
cb1d4ed9d0 Fix a comment. 
llvm-svn: 101477
 2010-04-16 16:52:37 +00:00
Gabor Greif
e7d6812008 reapply r101434 
with a fix for self-hosting

rotate CallInst operands, i.e. move callee to the back
of the operand array

the motivation for this patch are laid out in my mail to llvm-commits:
more efficient access to operands and callee, faster callgraph-construction,
smaller compiler binary

llvm-svn: 101465
 2010-04-16 15:33:14 +00:00
Evan Cheng
d143bfe0a4 Adding support for dag combiner to promote operations for profit. This requires target specific queries. For example, x86 should promote i16 to i32 when it does not impact load folding. 
x86 support is off by default. It can be enabled with -promote-16bit.

Work in progress.

llvm-svn: 101448
 2010-04-16 06:14:10 +00:00
Dan Gohman
01d4af69bf Refine further the scope where the global DebugLoc value is active. 
llvm-svn: 101443
 2010-04-16 05:06:56 +00:00
Gabor Greif
cd116e8c6a back out r101423 and r101397, they break llvm-gcc self-host on darwin10 
llvm-svn: 101434
 2010-04-16 01:16:20 +00:00
Gabor Greif
2e18d34d80 reapply r101364, which has been backed out in r101368 
with a fix

rotate CallInst operands, i.e. move callee to the back
of the operand array

the motivation for this patch are laid out in my mail to llvm-commits:
more efficient access to operands and callee, faster callgraph-construction,
smaller compiler binary

llvm-svn: 101397
 2010-04-15 20:51:13 +00:00
Dan Gohman
d48633d340 Fix a bunch of namespace polution. 
llvm-svn: 101376
 2010-04-15 17:08:50 +00:00
Gabor Greif
6022150477 back out r101364, as it trips the linux nightlybot on some clang C++ tests 
llvm-svn: 101368
 2010-04-15 12:46:56 +00:00
Gabor Greif
428ca23bbd rotate CallInst operands, i.e. move callee to the back 
of the operand array

the motivation for this patch are laid out in my mail to llvm-commits:
more efficient access to operands and callee, faster callgraph-construction,
smaller compiler binary

llvm-svn: 101364
 2010-04-15 10:49:53 +00:00
Chris Lattner
1b7ecfdf60 enhance the load/store narrowing optimization to handle a 
tokenfactor in between the load/store.  This allows us to 
optimize test7 into:

_test7:                                 ## @test7
## BB#0:                                ## %entry
	movl	(%rdx), %eax
                                        ## kill: SIL<def> ESI<kill>
	movb	%sil, 5(%rdi)
	ret

instead of:

_test7:                                 ## @test7
## BB#0:                                ## %entry
	movl	4(%esp), %ecx
	movl	$-65281, %eax           ## imm = 0xFFFFFFFFFFFF00FF
	andl	4(%ecx), %eax
	movzbl	8(%esp), %edx
	shll	$8, %edx
	addl	%eax, %edx
	movl	12(%esp), %eax
	movl	(%eax), %eax
	movl	%edx, 4(%ecx)
	ret

llvm-svn: 101355
 2010-04-15 06:10:49 +00:00
Chris Lattner
8c5a5c9094 teach codegen to turn trunc(zextload) into load when possible. 
This doesn't occur much at all, it only seems to formed in the case
when the trunc optimization kicks in due to phase ordering.  In that
case it is saves a few bytes on x86-32.

llvm-svn: 101350
 2010-04-15 05:40:59 +00:00
Chris Lattner
510d19e597 add a simple dag combine to replace trivial shl+lshr with 
and.  This happens with the store->load narrowing stuff.

llvm-svn: 101348
 2010-04-15 05:28:43 +00:00
Chris Lattner
3282f3d34f Implement rdar://7860110 (also in target/readme.txt) narrowing 
a load/or/and/store sequence into a narrower store when it is
safe.  Daniel tells me that clang will start producing this sort
of thing with bitfields, and this does  trigger a few dozen times
on 176.gcc produced by llvm-gcc even now.

This compiles code like CodeGen/X86/2009-05-28-DAGCombineCrash.ll 
into:

        movl    %eax, 36(%rdi)

instead of:

        movl    $4294967295, %eax       ## imm = 0xFFFFFFFF
        andq    32(%rdi), %rax
        shlq    $32, %rcx
        addq    %rax, %rcx
        movq    %rcx, 32(%rdi)

and each of the testcases into a single store.  Each of them used
to compile into craziness like this:

_test4:
	movl	$65535, %eax            ## imm = 0xFFFF
	andl	(%rdi), %eax
	shll	$16, %esi
	addl	%eax, %esi
	movl	%esi, (%rdi)
	ret

llvm-svn: 101343
 2010-04-15 04:48:01 +00:00
Dan Gohman
64a84ceb3f Add more const qualifiers for LLVM IR pointers in CodeGen. 
llvm-svn: 101342
 2010-04-15 04:33:49 +00:00
Dan Gohman
0e0b8cf9fd Add const qualifiers to CodeGen's use of LLVM IR constructs. 
llvm-svn: 101334
 2010-04-15 01:51:59 +00:00
Evan Cheng
8249affa3b More 80 violations. 
llvm-svn: 101330
 2010-04-15 01:25:27 +00:00
Evan Cheng
263c547804 80 col violations. 
llvm-svn: 101325
 2010-04-15 01:01:55 +00:00
Dan Gohman
1b67547226 Delete unneeeded arguments. 
llvm-svn: 101276
 2010-04-14 20:17:22 +00:00
Dan Gohman
d5d199da5f Delete unused arguments. 
llvm-svn: 101275
 2010-04-14 20:05:00 +00:00
Dan Gohman
c64d1d02a3 Factor out EH landing pad code into a separate function, and constify 
a bunch of stuff to support it.

llvm-svn: 101273
 2010-04-14 19:53:31 +00:00
Dan Gohman
c94abce286 Reset the debug location even if the instruction was a terminator. 
llvm-svn: 101272
 2010-04-14 19:30:02 +00:00
Dan Gohman
2d61a3f384 Refine #includes. 
llvm-svn: 101269
 2010-04-14 18:49:17 +00:00
Dan Gohman
b0b1974ddd Pull utility routines with no SelectionDAG dependence out of 
SelectionDAGBuilder. FunctionLoweringInfo isn't an ideal place for
them to live, but it's better than SelectionDAGBuilder for now.

llvm-svn: 101267
 2010-04-14 18:31:02 +00:00
Dan Gohman
64582fc238 Fix typos in comments. 
llvm-svn: 101266
 2010-04-14 18:24:06 +00:00
Dan Gohman
60b5b8fa20 Delete an obsolete comment. 
llvm-svn: 101264
 2010-04-14 17:40:25 +00:00
Dan Gohman
4fd4153d52 Delete an unused function. 
llvm-svn: 101263
 2010-04-14 17:22:02 +00:00
Dan Gohman
45b0642839 Clear the FunctionLoweringInfo object before doing other things that 
don't need it.

llvm-svn: 101262
 2010-04-14 17:13:16 +00:00
Dan Gohman
3738dc7587 Move this assert out of SelectionDAGISel into FunctionLoweringInfo, and 
drop the redundant #ifndef NDEBUG.

llvm-svn: 101261
 2010-04-14 17:11:23 +00:00