Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
//===- AMDGPUInstructionSelector.cpp ----------------------------*- C++ -*-==//
|
|
|
|
//
|
2019-01-19 09:50:56 +01:00
|
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
//
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
/// \file
|
|
|
|
/// This file implements the targeting of the InstructionSelector class for
|
|
|
|
/// AMDGPU.
|
|
|
|
/// \todo This should be generated by TableGen.
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
#include "AMDGPUInstructionSelector.h"
|
|
|
|
#include "AMDGPUInstrInfo.h"
|
|
|
|
#include "AMDGPURegisterBankInfo.h"
|
|
|
|
#include "AMDGPURegisterInfo.h"
|
|
|
|
#include "AMDGPUSubtarget.h"
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
#include "AMDGPUTargetMachine.h"
|
AMDGPU: Remove #include "MCTargetDesc/AMDGPUMCTargetDesc.h" from common headers
Summary:
MCTargetDesc/AMDGPUMCTargetDesc.h contains enums for all the instuction
and register defintions, which are huge so we only want to include
them where needed.
This will also make it easier if we want to split the R600 and GCN
definitions into separate tablegenerated files.
I was unable to remove AMDGPUMCTargetDesc.h from SIMachineFunctionInfo.h
because it uses some enums from the header to initialize default values
for the SIMachineFunction class, so I ended up having to remove includes of
SIMachineFunctionInfo.h from headers too.
Reviewers: arsenm, nhaehnle
Reviewed By: nhaehnle
Subscribers: MatzeB, kzhuravl, wdng, yaxunl, dstuttard, tpr, t-tye, javed.absar, llvm-commits
Differential Revision: https://reviews.llvm.org/D46272
llvm-svn: 332930
2018-05-22 04:03:23 +02:00
|
|
|
#include "MCTargetDesc/AMDGPUMCTargetDesc.h"
|
2019-07-16 21:22:21 +02:00
|
|
|
#include "SIMachineFunctionInfo.h"
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
#include "llvm/CodeGen/GlobalISel/InstructionSelector.h"
|
|
|
|
#include "llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h"
|
2019-07-16 21:22:21 +02:00
|
|
|
#include "llvm/CodeGen/GlobalISel/MIPatternMatch.h"
|
2018-01-17 20:31:33 +01:00
|
|
|
#include "llvm/CodeGen/GlobalISel/Utils.h"
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
#include "llvm/CodeGen/MachineBasicBlock.h"
|
|
|
|
#include "llvm/CodeGen/MachineFunction.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
|
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
|
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
|
|
#include "llvm/IR/Type.h"
|
|
|
|
#include "llvm/Support/Debug.h"
|
|
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
|
|
|
|
#define DEBUG_TYPE "amdgpu-isel"
|
|
|
|
|
|
|
|
using namespace llvm;
|
2019-07-16 21:22:21 +02:00
|
|
|
using namespace MIPatternMatch;
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
#define GET_GLOBALISEL_IMPL
|
2018-07-11 22:59:01 +02:00
|
|
|
#define AMDGPUSubtarget GCNSubtarget
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
#include "AMDGPUGenGlobalISel.inc"
|
|
|
|
#undef GET_GLOBALISEL_IMPL
|
2018-07-11 22:59:01 +02:00
|
|
|
#undef AMDGPUSubtarget
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
AMDGPUInstructionSelector::AMDGPUInstructionSelector(
|
2018-07-11 22:59:01 +02:00
|
|
|
const GCNSubtarget &STI, const AMDGPURegisterBankInfo &RBI,
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
const AMDGPUTargetMachine &TM)
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
: InstructionSelector(), TII(*STI.getInstrInfo()),
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
TRI(*STI.getRegisterInfo()), RBI(RBI), TM(TM),
|
|
|
|
STI(STI),
|
|
|
|
EnableLateStructurizeCFG(AMDGPUTargetMachine::EnableLateStructurizeCFG),
|
|
|
|
#define GET_GLOBALISEL_PREDICATES_INIT
|
|
|
|
#include "AMDGPUGenGlobalISel.inc"
|
|
|
|
#undef GET_GLOBALISEL_PREDICATES_INIT
|
|
|
|
#define GET_GLOBALISEL_TEMPORARIES_INIT
|
|
|
|
#include "AMDGPUGenGlobalISel.inc"
|
|
|
|
#undef GET_GLOBALISEL_TEMPORARIES_INIT
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
const char *AMDGPUInstructionSelector::getName() { return DEBUG_TYPE; }
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
2019-07-01 18:06:02 +02:00
|
|
|
static bool isSCC(Register Reg, const MachineRegisterInfo &MRI) {
|
2019-08-02 01:27:28 +02:00
|
|
|
if (Register::isPhysicalRegister(Reg))
|
2019-07-01 18:06:02 +02:00
|
|
|
return Reg == AMDGPU::SCC;
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
|
|
|
|
auto &RegClassOrBank = MRI.getRegClassOrRegBank(Reg);
|
|
|
|
const TargetRegisterClass *RC =
|
|
|
|
RegClassOrBank.dyn_cast<const TargetRegisterClass*>();
|
2019-07-01 17:23:04 +02:00
|
|
|
if (RC) {
|
2019-07-15 21:50:07 +02:00
|
|
|
// FIXME: This is ambiguous for wave32. This could be SCC or VCC, but the
|
|
|
|
// context of the register bank has been lost.
|
2019-07-01 17:23:04 +02:00
|
|
|
if (RC->getID() != AMDGPU::SReg_32_XM0RegClassID)
|
|
|
|
return false;
|
|
|
|
const LLT Ty = MRI.getType(Reg);
|
|
|
|
return Ty.isValid() && Ty.getSizeInBits() == 1;
|
|
|
|
}
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
|
|
|
|
const RegisterBank *RB = RegClassOrBank.get<const RegisterBank *>();
|
|
|
|
return RB->getID() == AMDGPU::SCCRegBankID;
|
|
|
|
}
|
|
|
|
|
2019-07-01 18:06:02 +02:00
|
|
|
bool AMDGPUInstructionSelector::isVCC(Register Reg,
|
|
|
|
const MachineRegisterInfo &MRI) const {
|
2019-08-02 01:27:28 +02:00
|
|
|
if (Register::isPhysicalRegister(Reg))
|
2019-07-01 18:06:02 +02:00
|
|
|
return Reg == TRI.getVCC();
|
2019-07-01 15:22:07 +02:00
|
|
|
|
|
|
|
auto &RegClassOrBank = MRI.getRegClassOrRegBank(Reg);
|
|
|
|
const TargetRegisterClass *RC =
|
|
|
|
RegClassOrBank.dyn_cast<const TargetRegisterClass*>();
|
|
|
|
if (RC) {
|
2019-07-15 21:44:07 +02:00
|
|
|
const LLT Ty = MRI.getType(Reg);
|
2019-07-01 18:06:02 +02:00
|
|
|
return RC->hasSuperClassEq(TRI.getBoolRC()) &&
|
2019-07-15 21:44:07 +02:00
|
|
|
Ty.isValid() && Ty.getSizeInBits() == 1;
|
2019-07-01 15:22:07 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
const RegisterBank *RB = RegClassOrBank.get<const RegisterBank *>();
|
|
|
|
return RB->getID() == AMDGPU::VCCRegBankID;
|
|
|
|
}
|
|
|
|
|
2018-05-10 23:20:10 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectCOPY(MachineInstr &I) const {
|
2019-07-15 21:44:07 +02:00
|
|
|
const DebugLoc &DL = I.getDebugLoc();
|
2018-05-10 23:20:10 +02:00
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
I.setDesc(TII.get(TargetOpcode::COPY));
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
|
|
|
|
const MachineOperand &Src = I.getOperand(1);
|
2019-07-15 21:44:07 +02:00
|
|
|
MachineOperand &Dst = I.getOperand(0);
|
|
|
|
Register DstReg = Dst.getReg();
|
|
|
|
Register SrcReg = Src.getReg();
|
|
|
|
|
|
|
|
if (isVCC(DstReg, MRI)) {
|
|
|
|
if (SrcReg == AMDGPU::SCC) {
|
|
|
|
const TargetRegisterClass *RC
|
|
|
|
= TRI.getConstrainedRegClassForOperand(Dst, MRI);
|
|
|
|
if (!RC)
|
|
|
|
return true;
|
|
|
|
return RBI.constrainGenericRegister(DstReg, *RC, MRI);
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
}
|
2019-07-15 21:44:07 +02:00
|
|
|
|
2019-07-15 21:46:48 +02:00
|
|
|
if (!isVCC(SrcReg, MRI)) {
|
|
|
|
// TODO: Should probably leave the copy and let copyPhysReg expand it.
|
|
|
|
if (!RBI.constrainGenericRegister(DstReg, *TRI.getBoolRC(), MRI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::V_CMP_NE_U32_e64), DstReg)
|
|
|
|
.addImm(0)
|
|
|
|
.addReg(SrcReg);
|
|
|
|
|
|
|
|
if (!MRI.getRegClassOrNull(SrcReg))
|
|
|
|
MRI.setRegClass(SrcReg, TRI.getConstrainedRegClassForOperand(Src, MRI));
|
|
|
|
I.eraseFromParent();
|
|
|
|
return true;
|
|
|
|
}
|
2019-07-15 21:48:36 +02:00
|
|
|
|
|
|
|
const TargetRegisterClass *RC =
|
|
|
|
TRI.getConstrainedRegClassForOperand(Dst, MRI);
|
|
|
|
if (RC && !RBI.constrainGenericRegister(DstReg, *RC, MRI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Don't constrain the source register to a class so the def instruction
|
|
|
|
// handles it (unless it's undef).
|
|
|
|
//
|
|
|
|
// FIXME: This is a hack. When selecting the def, we neeed to know
|
|
|
|
// specifically know that the result is VCCRegBank, and not just an SGPR
|
|
|
|
// with size 1. An SReg_32 with size 1 is ambiguous with wave32.
|
|
|
|
if (Src.isUndef()) {
|
|
|
|
const TargetRegisterClass *SrcRC =
|
|
|
|
TRI.getConstrainedRegClassForOperand(Src, MRI);
|
|
|
|
if (SrcRC && !RBI.constrainGenericRegister(SrcReg, *SrcRC, MRI))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
}
|
|
|
|
|
2018-05-10 23:20:10 +02:00
|
|
|
for (const MachineOperand &MO : I.operands()) {
|
2019-08-02 01:27:28 +02:00
|
|
|
if (Register::isPhysicalRegister(MO.getReg()))
|
2018-05-10 23:20:10 +02:00
|
|
|
continue;
|
|
|
|
|
|
|
|
const TargetRegisterClass *RC =
|
|
|
|
TRI.getConstrainedRegClassForOperand(MO, MRI);
|
|
|
|
if (!RC)
|
|
|
|
continue;
|
|
|
|
RBI.constrainGenericRegister(MO.getReg(), *RC, MRI);
|
|
|
|
}
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-07-01 18:32:47 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectPHI(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
|
|
|
|
const Register DefReg = I.getOperand(0).getReg();
|
|
|
|
const LLT DefTy = MRI.getType(DefReg);
|
|
|
|
|
|
|
|
// TODO: Verify this doesn't have insane operands (i.e. VGPR to SGPR copy)
|
|
|
|
|
|
|
|
const RegClassOrRegBank &RegClassOrBank =
|
|
|
|
MRI.getRegClassOrRegBank(DefReg);
|
|
|
|
|
|
|
|
const TargetRegisterClass *DefRC
|
|
|
|
= RegClassOrBank.dyn_cast<const TargetRegisterClass *>();
|
|
|
|
if (!DefRC) {
|
|
|
|
if (!DefTy.isValid()) {
|
|
|
|
LLVM_DEBUG(dbgs() << "PHI operand has no type, not a gvreg?\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
const RegisterBank &RB = *RegClassOrBank.get<const RegisterBank *>();
|
|
|
|
if (RB.getID() == AMDGPU::SCCRegBankID) {
|
|
|
|
LLVM_DEBUG(dbgs() << "illegal scc phi\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
DefRC = TRI.getRegClassForTypeOnBank(DefTy, RB, MRI);
|
|
|
|
if (!DefRC) {
|
|
|
|
LLVM_DEBUG(dbgs() << "PHI operand has unexpected size/bank\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
I.setDesc(TII.get(TargetOpcode::PHI));
|
|
|
|
return RBI.constrainGenericRegister(DefReg, *DefRC, MRI);
|
|
|
|
}
|
|
|
|
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
MachineOperand
|
|
|
|
AMDGPUInstructionSelector::getSubOperand64(MachineOperand &MO,
|
2019-07-01 18:34:48 +02:00
|
|
|
const TargetRegisterClass &SubRC,
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
unsigned SubIdx) const {
|
|
|
|
|
|
|
|
MachineInstr *MI = MO.getParent();
|
|
|
|
MachineBasicBlock *BB = MO.getParent()->getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
2019-07-01 18:34:48 +02:00
|
|
|
Register DstReg = MRI.createVirtualRegister(&SubRC);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
|
|
|
if (MO.isReg()) {
|
|
|
|
unsigned ComposedSubIdx = TRI.composeSubRegIndices(MO.getSubReg(), SubIdx);
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register Reg = MO.getReg();
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
BuildMI(*BB, MI, MI->getDebugLoc(), TII.get(AMDGPU::COPY), DstReg)
|
|
|
|
.addReg(Reg, 0, ComposedSubIdx);
|
|
|
|
|
|
|
|
return MachineOperand::CreateReg(DstReg, MO.isDef(), MO.isImplicit(),
|
|
|
|
MO.isKill(), MO.isDead(), MO.isUndef(),
|
|
|
|
MO.isEarlyClobber(), 0, MO.isDebug(),
|
|
|
|
MO.isInternalRead());
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(MO.isImm());
|
|
|
|
|
|
|
|
APInt Imm(64, MO.getImm());
|
|
|
|
|
|
|
|
switch (SubIdx) {
|
|
|
|
default:
|
|
|
|
llvm_unreachable("do not know to split immediate with this sub index.");
|
|
|
|
case AMDGPU::sub0:
|
|
|
|
return MachineOperand::CreateImm(Imm.getLoBits(32).getSExtValue());
|
|
|
|
case AMDGPU::sub1:
|
|
|
|
return MachineOperand::CreateImm(Imm.getHiBits(32).getSExtValue());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-13 23:05:14 +02:00
|
|
|
static int64_t getConstant(const MachineInstr *MI) {
|
|
|
|
return MI->getOperand(1).getCImm()->getSExtValue();
|
|
|
|
}
|
|
|
|
|
2019-07-15 21:50:07 +02:00
|
|
|
static unsigned getLogicalBitOpcode(unsigned Opc, bool Is64) {
|
|
|
|
switch (Opc) {
|
|
|
|
case AMDGPU::G_AND:
|
|
|
|
return Is64 ? AMDGPU::S_AND_B64 : AMDGPU::S_AND_B32;
|
|
|
|
case AMDGPU::G_OR:
|
|
|
|
return Is64 ? AMDGPU::S_OR_B64 : AMDGPU::S_OR_B32;
|
|
|
|
case AMDGPU::G_XOR:
|
|
|
|
return Is64 ? AMDGPU::S_XOR_B64 : AMDGPU::S_XOR_B32;
|
|
|
|
default:
|
|
|
|
llvm_unreachable("not a bit op");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool AMDGPUInstructionSelector::selectG_AND_OR_XOR(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
MachineOperand &Dst = I.getOperand(0);
|
|
|
|
MachineOperand &Src0 = I.getOperand(1);
|
|
|
|
MachineOperand &Src1 = I.getOperand(2);
|
|
|
|
Register DstReg = Dst.getReg();
|
|
|
|
unsigned Size = RBI.getSizeInBits(DstReg, MRI, TRI);
|
|
|
|
|
|
|
|
const RegisterBank *DstRB = RBI.getRegBank(DstReg, MRI, TRI);
|
|
|
|
if (DstRB->getID() == AMDGPU::VCCRegBankID) {
|
|
|
|
const TargetRegisterClass *RC = TRI.getBoolRC();
|
|
|
|
unsigned InstOpc = getLogicalBitOpcode(I.getOpcode(),
|
|
|
|
RC == &AMDGPU::SReg_64RegClass);
|
|
|
|
I.setDesc(TII.get(InstOpc));
|
|
|
|
|
|
|
|
// FIXME: Hack to avoid turning the register bank into a register class.
|
|
|
|
// The selector for G_ICMP relies on seeing the register bank for the result
|
|
|
|
// is VCC. In wave32 if we constrain the registers to SReg_32 here, it will
|
|
|
|
// be ambiguous whether it's a scalar or vector bool.
|
|
|
|
if (Src0.isUndef() && !MRI.getRegClassOrNull(Src0.getReg()))
|
|
|
|
MRI.setRegClass(Src0.getReg(), RC);
|
|
|
|
if (Src1.isUndef() && !MRI.getRegClassOrNull(Src1.getReg()))
|
|
|
|
MRI.setRegClass(Src1.getReg(), RC);
|
|
|
|
|
|
|
|
return RBI.constrainGenericRegister(DstReg, *RC, MRI);
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: Should this allow an SCC bank result, and produce a copy from SCC for
|
|
|
|
// the result?
|
|
|
|
if (DstRB->getID() == AMDGPU::SGPRRegBankID) {
|
|
|
|
unsigned InstOpc = getLogicalBitOpcode(I.getOpcode(), Size > 32);
|
|
|
|
I.setDesc(TII.get(InstOpc));
|
2019-07-16 16:28:30 +02:00
|
|
|
|
|
|
|
const TargetRegisterClass *RC
|
|
|
|
= TRI.getConstrainedRegClassForOperand(Dst, MRI);
|
|
|
|
if (!RC)
|
|
|
|
return false;
|
2019-07-15 21:50:07 +02:00
|
|
|
return RBI.constrainGenericRegister(DstReg, *RC, MRI) &&
|
|
|
|
RBI.constrainGenericRegister(Src0.getReg(), *RC, MRI) &&
|
|
|
|
RBI.constrainGenericRegister(Src1.getReg(), *RC, MRI);
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2019-07-09 16:05:11 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_ADD_SUB(MachineInstr &I) const {
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
2019-07-01 18:34:48 +02:00
|
|
|
Register DstReg = I.getOperand(0).getReg();
|
|
|
|
const DebugLoc &DL = I.getDebugLoc();
|
|
|
|
unsigned Size = RBI.getSizeInBits(DstReg, MRI, TRI);
|
|
|
|
const RegisterBank *DstRB = RBI.getRegBank(DstReg, MRI, TRI);
|
|
|
|
const bool IsSALU = DstRB->getID() == AMDGPU::SGPRRegBankID;
|
2019-07-09 16:05:11 +02:00
|
|
|
const bool Sub = I.getOpcode() == TargetOpcode::G_SUB;
|
2019-07-01 18:34:48 +02:00
|
|
|
|
|
|
|
if (Size == 32) {
|
|
|
|
if (IsSALU) {
|
2019-07-09 16:05:11 +02:00
|
|
|
const unsigned Opc = Sub ? AMDGPU::S_SUB_U32 : AMDGPU::S_ADD_U32;
|
2019-07-01 18:34:48 +02:00
|
|
|
MachineInstr *Add =
|
2019-07-09 16:05:11 +02:00
|
|
|
BuildMI(*BB, &I, DL, TII.get(Opc), DstReg)
|
2019-07-01 18:34:48 +02:00
|
|
|
.add(I.getOperand(1))
|
|
|
|
.add(I.getOperand(2));
|
|
|
|
I.eraseFromParent();
|
|
|
|
return constrainSelectedInstRegOperands(*Add, TII, TRI, RBI);
|
|
|
|
}
|
2017-01-31 16:24:11 +01:00
|
|
|
|
2019-07-01 18:34:48 +02:00
|
|
|
if (STI.hasAddNoCarry()) {
|
2019-07-09 16:05:11 +02:00
|
|
|
const unsigned Opc = Sub ? AMDGPU::V_SUB_U32_e64 : AMDGPU::V_ADD_U32_e64;
|
|
|
|
I.setDesc(TII.get(Opc));
|
2019-07-01 18:34:48 +02:00
|
|
|
I.addOperand(*MF, MachineOperand::CreateImm(0));
|
|
|
|
I.addOperand(*MF, MachineOperand::CreateReg(AMDGPU::EXEC, false, true));
|
|
|
|
return constrainSelectedInstRegOperands(I, TII, TRI, RBI);
|
|
|
|
}
|
2017-01-31 16:24:11 +01:00
|
|
|
|
2019-07-09 16:05:11 +02:00
|
|
|
const unsigned Opc = Sub ? AMDGPU::V_SUB_I32_e64 : AMDGPU::V_ADD_I32_e64;
|
|
|
|
|
2019-07-01 18:34:48 +02:00
|
|
|
Register UnusedCarry = MRI.createVirtualRegister(TRI.getWaveMaskRegClass());
|
|
|
|
MachineInstr *Add
|
2019-07-09 16:05:11 +02:00
|
|
|
= BuildMI(*BB, &I, DL, TII.get(Opc), DstReg)
|
2019-07-01 18:34:48 +02:00
|
|
|
.addDef(UnusedCarry, RegState::Dead)
|
|
|
|
.add(I.getOperand(1))
|
|
|
|
.add(I.getOperand(2))
|
|
|
|
.addImm(0);
|
|
|
|
I.eraseFromParent();
|
|
|
|
return constrainSelectedInstRegOperands(*Add, TII, TRI, RBI);
|
|
|
|
}
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
2019-07-09 16:05:11 +02:00
|
|
|
assert(!Sub && "illegal sub should not reach here");
|
|
|
|
|
2019-07-01 18:34:48 +02:00
|
|
|
const TargetRegisterClass &RC
|
|
|
|
= IsSALU ? AMDGPU::SReg_64_XEXECRegClass : AMDGPU::VReg_64RegClass;
|
|
|
|
const TargetRegisterClass &HalfRC
|
|
|
|
= IsSALU ? AMDGPU::SReg_32RegClass : AMDGPU::VGPR_32RegClass;
|
|
|
|
|
|
|
|
MachineOperand Lo1(getSubOperand64(I.getOperand(1), HalfRC, AMDGPU::sub0));
|
|
|
|
MachineOperand Lo2(getSubOperand64(I.getOperand(2), HalfRC, AMDGPU::sub0));
|
|
|
|
MachineOperand Hi1(getSubOperand64(I.getOperand(1), HalfRC, AMDGPU::sub1));
|
|
|
|
MachineOperand Hi2(getSubOperand64(I.getOperand(2), HalfRC, AMDGPU::sub1));
|
|
|
|
|
|
|
|
Register DstLo = MRI.createVirtualRegister(&HalfRC);
|
|
|
|
Register DstHi = MRI.createVirtualRegister(&HalfRC);
|
|
|
|
|
|
|
|
if (IsSALU) {
|
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::S_ADD_U32), DstLo)
|
|
|
|
.add(Lo1)
|
|
|
|
.add(Lo2);
|
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::S_ADDC_U32), DstHi)
|
|
|
|
.add(Hi1)
|
|
|
|
.add(Hi2);
|
|
|
|
} else {
|
|
|
|
const TargetRegisterClass *CarryRC = TRI.getWaveMaskRegClass();
|
|
|
|
Register CarryReg = MRI.createVirtualRegister(CarryRC);
|
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::V_ADD_I32_e64), DstLo)
|
|
|
|
.addDef(CarryReg)
|
|
|
|
.add(Lo1)
|
|
|
|
.add(Lo2)
|
|
|
|
.addImm(0);
|
2019-07-02 16:40:22 +02:00
|
|
|
MachineInstr *Addc = BuildMI(*BB, &I, DL, TII.get(AMDGPU::V_ADDC_U32_e64), DstHi)
|
2019-07-01 18:34:48 +02:00
|
|
|
.addDef(MRI.createVirtualRegister(CarryRC), RegState::Dead)
|
|
|
|
.add(Hi1)
|
|
|
|
.add(Hi2)
|
|
|
|
.addReg(CarryReg, RegState::Kill)
|
|
|
|
.addImm(0);
|
2019-07-02 16:40:22 +02:00
|
|
|
|
|
|
|
if (!constrainSelectedInstRegOperands(*Addc, TII, TRI, RBI))
|
|
|
|
return false;
|
2019-07-01 18:34:48 +02:00
|
|
|
}
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
2019-07-01 18:34:48 +02:00
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::REG_SEQUENCE), DstReg)
|
|
|
|
.addReg(DstLo)
|
|
|
|
.addImm(AMDGPU::sub0)
|
|
|
|
.addReg(DstHi)
|
|
|
|
.addImm(AMDGPU::sub1);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
2019-07-02 16:40:22 +02:00
|
|
|
|
|
|
|
if (!RBI.constrainGenericRegister(DstReg, RC, MRI))
|
2019-07-01 18:34:48 +02:00
|
|
|
return false;
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
|
|
|
I.eraseFromParent();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-03-01 00:37:48 +01:00
|
|
|
bool AMDGPUInstructionSelector::selectG_EXTRACT(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
assert(I.getOperand(2).getImm() % 32 == 0);
|
|
|
|
unsigned SubReg = TRI.getSubRegFromChannel(I.getOperand(2).getImm() / 32);
|
|
|
|
const DebugLoc &DL = I.getDebugLoc();
|
|
|
|
MachineInstr *Copy = BuildMI(*BB, &I, DL, TII.get(TargetOpcode::COPY),
|
|
|
|
I.getOperand(0).getReg())
|
|
|
|
.addReg(I.getOperand(1).getReg(), 0, SubReg);
|
|
|
|
|
|
|
|
for (const MachineOperand &MO : Copy->operands()) {
|
|
|
|
const TargetRegisterClass *RC =
|
|
|
|
TRI.getConstrainedRegClassForOperand(MO, MRI);
|
|
|
|
if (!RC)
|
|
|
|
continue;
|
|
|
|
RBI.constrainGenericRegister(MO.getReg(), *RC, MRI);
|
|
|
|
}
|
|
|
|
I.eraseFromParent();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-07-09 16:02:20 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_MERGE_VALUES(MachineInstr &MI) const {
|
|
|
|
MachineBasicBlock *BB = MI.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
Register DstReg = MI.getOperand(0).getReg();
|
|
|
|
LLT DstTy = MRI.getType(DstReg);
|
|
|
|
LLT SrcTy = MRI.getType(MI.getOperand(1).getReg());
|
|
|
|
|
|
|
|
const unsigned SrcSize = SrcTy.getSizeInBits();
|
2019-07-15 19:26:43 +02:00
|
|
|
if (SrcSize < 32)
|
|
|
|
return false;
|
|
|
|
|
2019-07-09 16:02:20 +02:00
|
|
|
const DebugLoc &DL = MI.getDebugLoc();
|
|
|
|
const RegisterBank *DstBank = RBI.getRegBank(DstReg, MRI, TRI);
|
|
|
|
const unsigned DstSize = DstTy.getSizeInBits();
|
|
|
|
const TargetRegisterClass *DstRC =
|
|
|
|
TRI.getRegClassForSizeOnBank(DstSize, *DstBank, MRI);
|
|
|
|
if (!DstRC)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
ArrayRef<int16_t> SubRegs = TRI.getRegSplitParts(DstRC, SrcSize / 8);
|
|
|
|
MachineInstrBuilder MIB =
|
|
|
|
BuildMI(*BB, &MI, DL, TII.get(TargetOpcode::REG_SEQUENCE), DstReg);
|
|
|
|
for (int I = 0, E = MI.getNumOperands() - 1; I != E; ++I) {
|
|
|
|
MachineOperand &Src = MI.getOperand(I + 1);
|
|
|
|
MIB.addReg(Src.getReg(), getUndefRegState(Src.isUndef()));
|
|
|
|
MIB.addImm(SubRegs[I]);
|
|
|
|
|
|
|
|
const TargetRegisterClass *SrcRC
|
|
|
|
= TRI.getConstrainedRegClassForOperand(Src, MRI);
|
|
|
|
if (SrcRC && !RBI.constrainGenericRegister(Src.getReg(), *SrcRC, MRI))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!RBI.constrainGenericRegister(DstReg, *DstRC, MRI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
MI.eraseFromParent();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-07-09 16:02:26 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_UNMERGE_VALUES(MachineInstr &MI) const {
|
|
|
|
MachineBasicBlock *BB = MI.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
const int NumDst = MI.getNumOperands() - 1;
|
|
|
|
|
|
|
|
MachineOperand &Src = MI.getOperand(NumDst);
|
|
|
|
|
|
|
|
Register SrcReg = Src.getReg();
|
|
|
|
Register DstReg0 = MI.getOperand(0).getReg();
|
|
|
|
LLT DstTy = MRI.getType(DstReg0);
|
|
|
|
LLT SrcTy = MRI.getType(SrcReg);
|
|
|
|
|
|
|
|
const unsigned DstSize = DstTy.getSizeInBits();
|
|
|
|
const unsigned SrcSize = SrcTy.getSizeInBits();
|
|
|
|
const DebugLoc &DL = MI.getDebugLoc();
|
|
|
|
const RegisterBank *SrcBank = RBI.getRegBank(SrcReg, MRI, TRI);
|
|
|
|
|
|
|
|
const TargetRegisterClass *SrcRC =
|
|
|
|
TRI.getRegClassForSizeOnBank(SrcSize, *SrcBank, MRI);
|
|
|
|
if (!SrcRC || !RBI.constrainGenericRegister(SrcReg, *SrcRC, MRI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
const unsigned SrcFlags = getUndefRegState(Src.isUndef());
|
|
|
|
|
|
|
|
// Note we could have mixed SGPR and VGPR destination banks for an SGPR
|
|
|
|
// source, and this relies on the fact that the same subregister indices are
|
|
|
|
// used for both.
|
|
|
|
ArrayRef<int16_t> SubRegs = TRI.getRegSplitParts(SrcRC, DstSize / 8);
|
|
|
|
for (int I = 0, E = NumDst; I != E; ++I) {
|
|
|
|
MachineOperand &Dst = MI.getOperand(I);
|
|
|
|
BuildMI(*BB, &MI, DL, TII.get(TargetOpcode::COPY), Dst.getReg())
|
|
|
|
.addReg(SrcReg, SrcFlags, SubRegs[I]);
|
|
|
|
|
|
|
|
const TargetRegisterClass *DstRC =
|
|
|
|
TRI.getConstrainedRegClassForOperand(Dst, MRI);
|
|
|
|
if (DstRC && !RBI.constrainGenericRegister(Dst.getReg(), *DstRC, MRI))
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
MI.eraseFromParent();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
bool AMDGPUInstructionSelector::selectG_GEP(MachineInstr &I) const {
|
2019-07-09 16:05:11 +02:00
|
|
|
return selectG_ADD_SUB(I);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
}
|
|
|
|
|
2018-06-22 01:38:20 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_IMPLICIT_DEF(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
const MachineOperand &MO = I.getOperand(0);
|
2019-06-24 18:24:03 +02:00
|
|
|
|
|
|
|
// FIXME: Interface for getConstrainedRegClassForOperand needs work. The
|
|
|
|
// regbank check here is to know why getConstrainedRegClassForOperand failed.
|
|
|
|
const TargetRegisterClass *RC = TRI.getConstrainedRegClassForOperand(MO, MRI);
|
|
|
|
if ((!RC && !MRI.getRegBankOrNull(MO.getReg())) ||
|
|
|
|
(RC && RBI.constrainGenericRegister(MO.getReg(), *RC, MRI))) {
|
|
|
|
I.setDesc(TII.get(TargetOpcode::IMPLICIT_DEF));
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
2018-06-22 01:38:20 +02:00
|
|
|
}
|
|
|
|
|
AMDGPU/GlobalISel: Implement select for G_INSERT
Re-commit r344310.
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D53116
llvm-svn: 355159
2019-03-01 01:50:26 +01:00
|
|
|
bool AMDGPUInstructionSelector::selectG_INSERT(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
unsigned SubReg = TRI.getSubRegFromChannel(I.getOperand(3).getImm() / 32);
|
|
|
|
DebugLoc DL = I.getDebugLoc();
|
|
|
|
MachineInstr *Ins = BuildMI(*BB, &I, DL, TII.get(TargetOpcode::INSERT_SUBREG))
|
|
|
|
.addDef(I.getOperand(0).getReg())
|
|
|
|
.addReg(I.getOperand(1).getReg())
|
|
|
|
.addReg(I.getOperand(2).getReg())
|
|
|
|
.addImm(SubReg);
|
|
|
|
|
|
|
|
for (const MachineOperand &MO : Ins->operands()) {
|
|
|
|
if (!MO.isReg())
|
|
|
|
continue;
|
2019-08-02 01:27:28 +02:00
|
|
|
if (Register::isPhysicalRegister(MO.getReg()))
|
AMDGPU/GlobalISel: Implement select for G_INSERT
Re-commit r344310.
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D53116
llvm-svn: 355159
2019-03-01 01:50:26 +01:00
|
|
|
continue;
|
|
|
|
|
|
|
|
const TargetRegisterClass *RC =
|
|
|
|
TRI.getConstrainedRegClassForOperand(MO, MRI);
|
|
|
|
if (!RC)
|
|
|
|
continue;
|
|
|
|
RBI.constrainGenericRegister(MO.getReg(), *RC, MRI);
|
|
|
|
}
|
|
|
|
I.eraseFromParent();
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-08-13 08:26:59 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_INTRINSIC(MachineInstr &I) const {
|
2019-06-17 19:01:27 +02:00
|
|
|
unsigned IntrinsicID = I.getOperand(I.getNumExplicitDefs()).getIntrinsicID();
|
2018-06-14 21:26:37 +02:00
|
|
|
switch (IntrinsicID) {
|
2019-07-15 20:25:24 +02:00
|
|
|
case Intrinsic::amdgcn_if_break: {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
|
|
|
|
// FIXME: Manually selecting to avoid dealiing with the SReg_1 trick
|
|
|
|
// SelectionDAG uses for wave32 vs wave64.
|
|
|
|
BuildMI(*BB, &I, I.getDebugLoc(), TII.get(AMDGPU::SI_IF_BREAK))
|
|
|
|
.add(I.getOperand(0))
|
|
|
|
.add(I.getOperand(2))
|
|
|
|
.add(I.getOperand(3));
|
|
|
|
|
|
|
|
Register DstReg = I.getOperand(0).getReg();
|
|
|
|
Register Src0Reg = I.getOperand(2).getReg();
|
|
|
|
Register Src1Reg = I.getOperand(3).getReg();
|
|
|
|
|
|
|
|
I.eraseFromParent();
|
|
|
|
|
|
|
|
for (Register Reg : { DstReg, Src0Reg, Src1Reg }) {
|
|
|
|
if (!MRI.getRegClassOrNull(Reg))
|
|
|
|
MRI.setRegClass(Reg, TRI.getWaveMaskRegClass());
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
2019-07-02 16:52:16 +02:00
|
|
|
default:
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectImpl(I, *CoverageInfo);
|
2018-06-14 21:26:37 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-07-01 15:34:26 +02:00
|
|
|
static int getV_CMPOpcode(CmpInst::Predicate P, unsigned Size) {
|
|
|
|
if (Size != 32 && Size != 64)
|
|
|
|
return -1;
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
switch (P) {
|
|
|
|
default:
|
|
|
|
llvm_unreachable("Unknown condition code!");
|
|
|
|
case CmpInst::ICMP_NE:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_NE_U32_e64 : AMDGPU::V_CMP_NE_U64_e64;
|
|
|
|
case CmpInst::ICMP_EQ:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_EQ_U32_e64 : AMDGPU::V_CMP_EQ_U64_e64;
|
|
|
|
case CmpInst::ICMP_SGT:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_GT_I32_e64 : AMDGPU::V_CMP_GT_I64_e64;
|
|
|
|
case CmpInst::ICMP_SGE:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_GE_I32_e64 : AMDGPU::V_CMP_GE_I64_e64;
|
|
|
|
case CmpInst::ICMP_SLT:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_LT_I32_e64 : AMDGPU::V_CMP_LT_I64_e64;
|
|
|
|
case CmpInst::ICMP_SLE:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_LE_I32_e64 : AMDGPU::V_CMP_LE_I64_e64;
|
|
|
|
case CmpInst::ICMP_UGT:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_GT_U32_e64 : AMDGPU::V_CMP_GT_U64_e64;
|
|
|
|
case CmpInst::ICMP_UGE:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_GE_U32_e64 : AMDGPU::V_CMP_GE_U64_e64;
|
|
|
|
case CmpInst::ICMP_ULT:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_LT_U32_e64 : AMDGPU::V_CMP_LT_U64_e64;
|
|
|
|
case CmpInst::ICMP_ULE:
|
|
|
|
return Size == 32 ? AMDGPU::V_CMP_LE_U32_e64 : AMDGPU::V_CMP_LE_U64_e64;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-07-01 15:34:26 +02:00
|
|
|
int AMDGPUInstructionSelector::getS_CMPOpcode(CmpInst::Predicate P,
|
|
|
|
unsigned Size) const {
|
|
|
|
if (Size == 64) {
|
|
|
|
if (!STI.hasScalarCompareEq64())
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
switch (P) {
|
|
|
|
case CmpInst::ICMP_NE:
|
|
|
|
return AMDGPU::S_CMP_LG_U64;
|
|
|
|
case CmpInst::ICMP_EQ:
|
|
|
|
return AMDGPU::S_CMP_EQ_U64;
|
|
|
|
default:
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (Size != 32)
|
|
|
|
return -1;
|
|
|
|
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
switch (P) {
|
|
|
|
case CmpInst::ICMP_NE:
|
|
|
|
return AMDGPU::S_CMP_LG_U32;
|
|
|
|
case CmpInst::ICMP_EQ:
|
|
|
|
return AMDGPU::S_CMP_EQ_U32;
|
|
|
|
case CmpInst::ICMP_SGT:
|
|
|
|
return AMDGPU::S_CMP_GT_I32;
|
|
|
|
case CmpInst::ICMP_SGE:
|
|
|
|
return AMDGPU::S_CMP_GE_I32;
|
|
|
|
case CmpInst::ICMP_SLT:
|
|
|
|
return AMDGPU::S_CMP_LT_I32;
|
|
|
|
case CmpInst::ICMP_SLE:
|
|
|
|
return AMDGPU::S_CMP_LE_I32;
|
|
|
|
case CmpInst::ICMP_UGT:
|
|
|
|
return AMDGPU::S_CMP_GT_U32;
|
|
|
|
case CmpInst::ICMP_UGE:
|
|
|
|
return AMDGPU::S_CMP_GE_U32;
|
|
|
|
case CmpInst::ICMP_ULT:
|
|
|
|
return AMDGPU::S_CMP_LT_U32;
|
|
|
|
case CmpInst::ICMP_ULE:
|
|
|
|
return AMDGPU::S_CMP_LE_U32;
|
2019-07-01 15:34:26 +02:00
|
|
|
default:
|
|
|
|
llvm_unreachable("Unknown condition code!");
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool AMDGPUInstructionSelector::selectG_ICMP(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
2019-07-15 21:39:31 +02:00
|
|
|
const DebugLoc &DL = I.getDebugLoc();
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register SrcReg = I.getOperand(2).getReg();
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
unsigned Size = RBI.getSizeInBits(SrcReg, MRI, TRI);
|
2019-07-01 15:34:26 +02:00
|
|
|
|
|
|
|
auto Pred = (CmpInst::Predicate)I.getOperand(1).getPredicate();
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register CCReg = I.getOperand(0).getReg();
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
if (isSCC(CCReg, MRI)) {
|
2019-07-01 15:34:26 +02:00
|
|
|
int Opcode = getS_CMPOpcode(Pred, Size);
|
|
|
|
if (Opcode == -1)
|
|
|
|
return false;
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
MachineInstr *ICmp = BuildMI(*BB, &I, DL, TII.get(Opcode))
|
|
|
|
.add(I.getOperand(2))
|
|
|
|
.add(I.getOperand(3));
|
2019-06-25 15:18:11 +02:00
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::COPY), CCReg)
|
|
|
|
.addReg(AMDGPU::SCC);
|
|
|
|
bool Ret =
|
|
|
|
constrainSelectedInstRegOperands(*ICmp, TII, TRI, RBI) &&
|
|
|
|
RBI.constrainGenericRegister(CCReg, AMDGPU::SReg_32RegClass, MRI);
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
I.eraseFromParent();
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
|
2019-07-01 15:34:26 +02:00
|
|
|
int Opcode = getV_CMPOpcode(Pred, Size);
|
|
|
|
if (Opcode == -1)
|
|
|
|
return false;
|
|
|
|
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
MachineInstr *ICmp = BuildMI(*BB, &I, DL, TII.get(Opcode),
|
|
|
|
I.getOperand(0).getReg())
|
|
|
|
.add(I.getOperand(2))
|
|
|
|
.add(I.getOperand(3));
|
|
|
|
RBI.constrainGenericRegister(ICmp->getOperand(0).getReg(),
|
2019-07-15 21:39:31 +02:00
|
|
|
*TRI.getBoolRC(), MRI);
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
bool Ret = constrainSelectedInstRegOperands(*ICmp, TII, TRI, RBI);
|
|
|
|
I.eraseFromParent();
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
|
2018-07-13 23:05:14 +02:00
|
|
|
static MachineInstr *
|
|
|
|
buildEXP(const TargetInstrInfo &TII, MachineInstr *Insert, unsigned Tgt,
|
|
|
|
unsigned Reg0, unsigned Reg1, unsigned Reg2, unsigned Reg3,
|
|
|
|
unsigned VM, bool Compr, unsigned Enabled, bool Done) {
|
|
|
|
const DebugLoc &DL = Insert->getDebugLoc();
|
|
|
|
MachineBasicBlock &BB = *Insert->getParent();
|
|
|
|
unsigned Opcode = Done ? AMDGPU::EXP_DONE : AMDGPU::EXP;
|
|
|
|
return BuildMI(BB, Insert, DL, TII.get(Opcode))
|
|
|
|
.addImm(Tgt)
|
|
|
|
.addReg(Reg0)
|
|
|
|
.addReg(Reg1)
|
|
|
|
.addReg(Reg2)
|
|
|
|
.addReg(Reg3)
|
|
|
|
.addImm(VM)
|
|
|
|
.addImm(Compr)
|
|
|
|
.addImm(Enabled);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool AMDGPUInstructionSelector::selectG_INTRINSIC_W_SIDE_EFFECTS(
|
2019-08-13 08:26:59 +02:00
|
|
|
MachineInstr &I) const {
|
2018-07-13 23:05:14 +02:00
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
|
|
|
|
unsigned IntrinsicID = I.getOperand(0).getIntrinsicID();
|
|
|
|
switch (IntrinsicID) {
|
|
|
|
case Intrinsic::amdgcn_exp: {
|
|
|
|
int64_t Tgt = getConstant(MRI.getVRegDef(I.getOperand(1).getReg()));
|
|
|
|
int64_t Enabled = getConstant(MRI.getVRegDef(I.getOperand(2).getReg()));
|
|
|
|
int64_t Done = getConstant(MRI.getVRegDef(I.getOperand(7).getReg()));
|
|
|
|
int64_t VM = getConstant(MRI.getVRegDef(I.getOperand(8).getReg()));
|
|
|
|
|
|
|
|
MachineInstr *Exp = buildEXP(TII, &I, Tgt, I.getOperand(3).getReg(),
|
|
|
|
I.getOperand(4).getReg(),
|
|
|
|
I.getOperand(5).getReg(),
|
|
|
|
I.getOperand(6).getReg(),
|
|
|
|
VM, false, Enabled, Done);
|
|
|
|
|
|
|
|
I.eraseFromParent();
|
|
|
|
return constrainSelectedInstRegOperands(*Exp, TII, TRI, RBI);
|
|
|
|
}
|
|
|
|
case Intrinsic::amdgcn_exp_compr: {
|
|
|
|
const DebugLoc &DL = I.getDebugLoc();
|
|
|
|
int64_t Tgt = getConstant(MRI.getVRegDef(I.getOperand(1).getReg()));
|
|
|
|
int64_t Enabled = getConstant(MRI.getVRegDef(I.getOperand(2).getReg()));
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register Reg0 = I.getOperand(3).getReg();
|
|
|
|
Register Reg1 = I.getOperand(4).getReg();
|
|
|
|
Register Undef = MRI.createVirtualRegister(&AMDGPU::VGPR_32RegClass);
|
2018-07-13 23:05:14 +02:00
|
|
|
int64_t Done = getConstant(MRI.getVRegDef(I.getOperand(5).getReg()));
|
|
|
|
int64_t VM = getConstant(MRI.getVRegDef(I.getOperand(6).getReg()));
|
|
|
|
|
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::IMPLICIT_DEF), Undef);
|
|
|
|
MachineInstr *Exp = buildEXP(TII, &I, Tgt, Reg0, Reg1, Undef, Undef, VM,
|
|
|
|
true, Enabled, Done);
|
|
|
|
|
|
|
|
I.eraseFromParent();
|
|
|
|
return constrainSelectedInstRegOperands(*Exp, TII, TRI, RBI);
|
|
|
|
}
|
2019-07-15 20:18:46 +02:00
|
|
|
case Intrinsic::amdgcn_end_cf: {
|
|
|
|
// FIXME: Manually selecting to avoid dealiing with the SReg_1 trick
|
|
|
|
// SelectionDAG uses for wave32 vs wave64.
|
|
|
|
BuildMI(*BB, &I, I.getDebugLoc(),
|
|
|
|
TII.get(AMDGPU::SI_END_CF))
|
|
|
|
.add(I.getOperand(1));
|
|
|
|
|
|
|
|
Register Reg = I.getOperand(1).getReg();
|
|
|
|
I.eraseFromParent();
|
|
|
|
|
|
|
|
if (!MRI.getRegClassOrNull(Reg))
|
|
|
|
MRI.setRegClass(Reg, TRI.getWaveMaskRegClass());
|
|
|
|
return true;
|
|
|
|
}
|
2019-07-02 16:52:16 +02:00
|
|
|
default:
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectImpl(I, *CoverageInfo);
|
2018-07-13 23:05:14 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_SELECT(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
const DebugLoc &DL = I.getDebugLoc();
|
|
|
|
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register DstReg = I.getOperand(0).getReg();
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
unsigned Size = RBI.getSizeInBits(DstReg, MRI, TRI);
|
2019-07-01 17:42:47 +02:00
|
|
|
assert(Size <= 32 || Size == 64);
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
const MachineOperand &CCOp = I.getOperand(1);
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register CCReg = CCOp.getReg();
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
if (isSCC(CCReg, MRI)) {
|
2019-07-01 17:42:47 +02:00
|
|
|
unsigned SelectOpcode = Size == 64 ? AMDGPU::S_CSELECT_B64 :
|
|
|
|
AMDGPU::S_CSELECT_B32;
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
MachineInstr *CopySCC = BuildMI(*BB, &I, DL, TII.get(AMDGPU::COPY), AMDGPU::SCC)
|
|
|
|
.addReg(CCReg);
|
|
|
|
|
|
|
|
// The generic constrainSelectedInstRegOperands doesn't work for the scc register
|
|
|
|
// bank, because it does not cover the register class that we used to represent
|
|
|
|
// for it. So we need to manually set the register class here.
|
|
|
|
if (!MRI.getRegClassOrNull(CCReg))
|
|
|
|
MRI.setRegClass(CCReg, TRI.getConstrainedRegClassForOperand(CCOp, MRI));
|
|
|
|
MachineInstr *Select = BuildMI(*BB, &I, DL, TII.get(SelectOpcode), DstReg)
|
|
|
|
.add(I.getOperand(2))
|
|
|
|
.add(I.getOperand(3));
|
|
|
|
|
|
|
|
bool Ret = constrainSelectedInstRegOperands(*Select, TII, TRI, RBI) |
|
|
|
|
constrainSelectedInstRegOperands(*CopySCC, TII, TRI, RBI);
|
|
|
|
I.eraseFromParent();
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
|
2019-07-01 17:42:47 +02:00
|
|
|
// Wide VGPR select should have been split in RegBankSelect.
|
|
|
|
if (Size > 32)
|
|
|
|
return false;
|
|
|
|
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
MachineInstr *Select =
|
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::V_CNDMASK_B32_e64), DstReg)
|
|
|
|
.addImm(0)
|
|
|
|
.add(I.getOperand(3))
|
|
|
|
.addImm(0)
|
|
|
|
.add(I.getOperand(2))
|
|
|
|
.add(I.getOperand(1));
|
|
|
|
|
|
|
|
bool Ret = constrainSelectedInstRegOperands(*Select, TII, TRI, RBI);
|
|
|
|
I.eraseFromParent();
|
|
|
|
return Ret;
|
|
|
|
}
|
|
|
|
|
2019-08-13 08:26:59 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_STORE(MachineInstr &I) const {
|
2019-08-01 05:52:40 +02:00
|
|
|
initM0(I);
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectImpl(I, *CoverageInfo);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
}
|
|
|
|
|
2019-06-24 20:02:18 +02:00
|
|
|
static int sizeToSubRegIndex(unsigned Size) {
|
|
|
|
switch (Size) {
|
|
|
|
case 32:
|
|
|
|
return AMDGPU::sub0;
|
|
|
|
case 64:
|
|
|
|
return AMDGPU::sub0_sub1;
|
|
|
|
case 96:
|
|
|
|
return AMDGPU::sub0_sub1_sub2;
|
|
|
|
case 128:
|
|
|
|
return AMDGPU::sub0_sub1_sub2_sub3;
|
|
|
|
case 256:
|
|
|
|
return AMDGPU::sub0_sub1_sub2_sub3_sub4_sub5_sub6_sub7;
|
|
|
|
default:
|
|
|
|
if (Size < 32)
|
|
|
|
return AMDGPU::sub0;
|
|
|
|
if (Size > 256)
|
|
|
|
return -1;
|
|
|
|
return sizeToSubRegIndex(PowerOf2Ceil(Size));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
bool AMDGPUInstructionSelector::selectG_TRUNC(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register DstReg = I.getOperand(0).getReg();
|
|
|
|
Register SrcReg = I.getOperand(1).getReg();
|
2019-06-24 20:02:18 +02:00
|
|
|
const LLT DstTy = MRI.getType(DstReg);
|
|
|
|
const LLT SrcTy = MRI.getType(SrcReg);
|
|
|
|
if (!DstTy.isScalar())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
const RegisterBank *DstRB = RBI.getRegBank(DstReg, MRI, TRI);
|
|
|
|
const RegisterBank *SrcRB = RBI.getRegBank(SrcReg, MRI, TRI);
|
|
|
|
if (SrcRB != DstRB)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
unsigned DstSize = DstTy.getSizeInBits();
|
|
|
|
unsigned SrcSize = SrcTy.getSizeInBits();
|
|
|
|
|
|
|
|
const TargetRegisterClass *SrcRC
|
|
|
|
= TRI.getRegClassForSizeOnBank(SrcSize, *SrcRB, MRI);
|
|
|
|
const TargetRegisterClass *DstRC
|
|
|
|
= TRI.getRegClassForSizeOnBank(DstSize, *DstRB, MRI);
|
|
|
|
|
|
|
|
if (SrcSize > 32) {
|
|
|
|
int SubRegIdx = sizeToSubRegIndex(DstSize);
|
|
|
|
if (SubRegIdx == -1)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
// Deal with weird cases where the class only partially supports the subreg
|
|
|
|
// index.
|
|
|
|
SrcRC = TRI.getSubClassWithSubReg(SrcRC, SubRegIdx);
|
|
|
|
if (!SrcRC)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
I.getOperand(1).setSubReg(SubRegIdx);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!RBI.constrainGenericRegister(SrcReg, *SrcRC, MRI) ||
|
|
|
|
!RBI.constrainGenericRegister(DstReg, *DstRC, MRI)) {
|
|
|
|
LLVM_DEBUG(dbgs() << "Failed to constrain G_TRUNC\n");
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
I.setDesc(TII.get(TargetOpcode::COPY));
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-07-01 15:22:06 +02:00
|
|
|
/// \returns true if a bitmask for \p Size bits will be an inline immediate.
|
|
|
|
static bool shouldUseAndMask(unsigned Size, unsigned &Mask) {
|
|
|
|
Mask = maskTrailingOnes<unsigned>(Size);
|
|
|
|
int SignedMask = static_cast<int>(Mask);
|
|
|
|
return SignedMask >= -16 && SignedMask <= 64;
|
|
|
|
}
|
|
|
|
|
2019-06-25 15:18:11 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_SZA_EXT(MachineInstr &I) const {
|
|
|
|
bool Signed = I.getOpcode() == AMDGPU::G_SEXT;
|
|
|
|
const DebugLoc &DL = I.getDebugLoc();
|
|
|
|
MachineBasicBlock &MBB = *I.getParent();
|
|
|
|
MachineFunction &MF = *MBB.getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF.getRegInfo();
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
const Register DstReg = I.getOperand(0).getReg();
|
|
|
|
const Register SrcReg = I.getOperand(1).getReg();
|
2019-06-25 15:18:11 +02:00
|
|
|
|
|
|
|
const LLT DstTy = MRI.getType(DstReg);
|
|
|
|
const LLT SrcTy = MRI.getType(SrcReg);
|
|
|
|
const LLT S1 = LLT::scalar(1);
|
|
|
|
const unsigned SrcSize = SrcTy.getSizeInBits();
|
|
|
|
const unsigned DstSize = DstTy.getSizeInBits();
|
|
|
|
if (!DstTy.isScalar())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
const RegisterBank *SrcBank = RBI.getRegBank(SrcReg, MRI, TRI);
|
|
|
|
|
|
|
|
if (SrcBank->getID() == AMDGPU::SCCRegBankID) {
|
|
|
|
if (SrcTy != S1 || DstSize > 64) // Invalid
|
|
|
|
return false;
|
|
|
|
|
|
|
|
unsigned Opcode =
|
|
|
|
DstSize > 32 ? AMDGPU::S_CSELECT_B64 : AMDGPU::S_CSELECT_B32;
|
|
|
|
const TargetRegisterClass *DstRC =
|
|
|
|
DstSize > 32 ? &AMDGPU::SReg_64RegClass : &AMDGPU::SReg_32RegClass;
|
|
|
|
|
|
|
|
// FIXME: Create an extra copy to avoid incorrectly constraining the result
|
|
|
|
// of the scc producer.
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register TmpReg = MRI.createVirtualRegister(&AMDGPU::SReg_32RegClass);
|
2019-06-25 15:18:11 +02:00
|
|
|
BuildMI(MBB, I, DL, TII.get(AMDGPU::COPY), TmpReg)
|
|
|
|
.addReg(SrcReg);
|
|
|
|
BuildMI(MBB, I, DL, TII.get(AMDGPU::COPY), AMDGPU::SCC)
|
|
|
|
.addReg(TmpReg);
|
|
|
|
|
|
|
|
// The instruction operands are backwards from what you would expect.
|
|
|
|
BuildMI(MBB, I, DL, TII.get(Opcode), DstReg)
|
|
|
|
.addImm(0)
|
|
|
|
.addImm(Signed ? -1 : 1);
|
2019-07-24 18:05:53 +02:00
|
|
|
I.eraseFromParent();
|
2019-06-25 15:18:11 +02:00
|
|
|
return RBI.constrainGenericRegister(DstReg, *DstRC, MRI);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (SrcBank->getID() == AMDGPU::VCCRegBankID && DstSize <= 32) {
|
|
|
|
if (SrcTy != S1) // Invalid
|
|
|
|
return false;
|
|
|
|
|
|
|
|
MachineInstr *ExtI =
|
|
|
|
BuildMI(MBB, I, DL, TII.get(AMDGPU::V_CNDMASK_B32_e64), DstReg)
|
|
|
|
.addImm(0) // src0_modifiers
|
|
|
|
.addImm(0) // src0
|
|
|
|
.addImm(0) // src1_modifiers
|
|
|
|
.addImm(Signed ? -1 : 1) // src1
|
|
|
|
.addUse(SrcReg);
|
2019-07-24 18:05:53 +02:00
|
|
|
I.eraseFromParent();
|
2019-06-25 15:18:11 +02:00
|
|
|
return constrainSelectedInstRegOperands(*ExtI, TII, TRI, RBI);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (I.getOpcode() == AMDGPU::G_ANYEXT)
|
|
|
|
return selectCOPY(I);
|
|
|
|
|
|
|
|
if (SrcBank->getID() == AMDGPU::VGPRRegBankID && DstSize <= 32) {
|
|
|
|
// 64-bit should have been split up in RegBankSelect
|
2019-07-01 15:22:06 +02:00
|
|
|
|
|
|
|
// Try to use an and with a mask if it will save code size.
|
|
|
|
unsigned Mask;
|
|
|
|
if (!Signed && shouldUseAndMask(SrcSize, Mask)) {
|
|
|
|
MachineInstr *ExtI =
|
|
|
|
BuildMI(MBB, I, DL, TII.get(AMDGPU::V_AND_B32_e32), DstReg)
|
|
|
|
.addImm(Mask)
|
|
|
|
.addReg(SrcReg);
|
2019-07-24 18:05:53 +02:00
|
|
|
I.eraseFromParent();
|
2019-07-01 15:22:06 +02:00
|
|
|
return constrainSelectedInstRegOperands(*ExtI, TII, TRI, RBI);
|
|
|
|
}
|
|
|
|
|
2019-06-25 15:18:11 +02:00
|
|
|
const unsigned BFE = Signed ? AMDGPU::V_BFE_I32 : AMDGPU::V_BFE_U32;
|
|
|
|
MachineInstr *ExtI =
|
|
|
|
BuildMI(MBB, I, DL, TII.get(BFE), DstReg)
|
|
|
|
.addReg(SrcReg)
|
|
|
|
.addImm(0) // Offset
|
|
|
|
.addImm(SrcSize); // Width
|
2019-07-24 18:05:53 +02:00
|
|
|
I.eraseFromParent();
|
2019-06-25 15:18:11 +02:00
|
|
|
return constrainSelectedInstRegOperands(*ExtI, TII, TRI, RBI);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (SrcBank->getID() == AMDGPU::SGPRRegBankID && DstSize <= 64) {
|
|
|
|
if (!RBI.constrainGenericRegister(SrcReg, AMDGPU::SReg_32RegClass, MRI))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (Signed && DstSize == 32 && (SrcSize == 8 || SrcSize == 16)) {
|
|
|
|
const unsigned SextOpc = SrcSize == 8 ?
|
|
|
|
AMDGPU::S_SEXT_I32_I8 : AMDGPU::S_SEXT_I32_I16;
|
|
|
|
BuildMI(MBB, I, DL, TII.get(SextOpc), DstReg)
|
|
|
|
.addReg(SrcReg);
|
2019-07-24 18:05:53 +02:00
|
|
|
I.eraseFromParent();
|
2019-06-25 15:18:11 +02:00
|
|
|
return RBI.constrainGenericRegister(DstReg, AMDGPU::SReg_32RegClass, MRI);
|
|
|
|
}
|
|
|
|
|
|
|
|
const unsigned BFE64 = Signed ? AMDGPU::S_BFE_I64 : AMDGPU::S_BFE_U64;
|
|
|
|
const unsigned BFE32 = Signed ? AMDGPU::S_BFE_I32 : AMDGPU::S_BFE_U32;
|
|
|
|
|
|
|
|
// Scalar BFE is encoded as S1[5:0] = offset, S1[22:16]= width.
|
|
|
|
if (DstSize > 32 && SrcSize <= 32) {
|
|
|
|
// We need a 64-bit register source, but the high bits don't matter.
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register ExtReg = MRI.createVirtualRegister(&AMDGPU::SReg_64RegClass);
|
|
|
|
Register UndefReg = MRI.createVirtualRegister(&AMDGPU::SReg_32RegClass);
|
2019-06-25 15:18:11 +02:00
|
|
|
BuildMI(MBB, I, DL, TII.get(AMDGPU::IMPLICIT_DEF), UndefReg);
|
|
|
|
BuildMI(MBB, I, DL, TII.get(AMDGPU::REG_SEQUENCE), ExtReg)
|
|
|
|
.addReg(SrcReg)
|
|
|
|
.addImm(AMDGPU::sub0)
|
|
|
|
.addReg(UndefReg)
|
|
|
|
.addImm(AMDGPU::sub1);
|
|
|
|
|
|
|
|
BuildMI(MBB, I, DL, TII.get(BFE64), DstReg)
|
|
|
|
.addReg(ExtReg)
|
|
|
|
.addImm(SrcSize << 16);
|
|
|
|
|
2019-07-24 18:05:53 +02:00
|
|
|
I.eraseFromParent();
|
2019-06-25 15:18:11 +02:00
|
|
|
return RBI.constrainGenericRegister(DstReg, AMDGPU::SReg_64RegClass, MRI);
|
|
|
|
}
|
|
|
|
|
2019-07-01 15:22:06 +02:00
|
|
|
unsigned Mask;
|
|
|
|
if (!Signed && shouldUseAndMask(SrcSize, Mask)) {
|
|
|
|
BuildMI(MBB, I, DL, TII.get(AMDGPU::S_AND_B32), DstReg)
|
|
|
|
.addReg(SrcReg)
|
|
|
|
.addImm(Mask);
|
|
|
|
} else {
|
|
|
|
BuildMI(MBB, I, DL, TII.get(BFE32), DstReg)
|
|
|
|
.addReg(SrcReg)
|
|
|
|
.addImm(SrcSize << 16);
|
|
|
|
}
|
|
|
|
|
2019-07-24 18:05:53 +02:00
|
|
|
I.eraseFromParent();
|
2019-06-25 15:18:11 +02:00
|
|
|
return RBI.constrainGenericRegister(DstReg, AMDGPU::SReg_32RegClass, MRI);
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
bool AMDGPUInstructionSelector::selectG_CONSTANT(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
2018-05-15 19:57:09 +02:00
|
|
|
MachineOperand &ImmOp = I.getOperand(1);
|
|
|
|
|
|
|
|
// The AMDGPU backend only supports Imm operands and not CImm or FPImm.
|
|
|
|
if (ImmOp.isFPImm()) {
|
|
|
|
const APInt &Imm = ImmOp.getFPImm()->getValueAPF().bitcastToAPInt();
|
|
|
|
ImmOp.ChangeToImmediate(Imm.getZExtValue());
|
|
|
|
} else if (ImmOp.isCImm()) {
|
|
|
|
ImmOp.ChangeToImmediate(ImmOp.getCImm()->getZExtValue());
|
|
|
|
}
|
|
|
|
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register DstReg = I.getOperand(0).getReg();
|
2018-05-15 19:57:09 +02:00
|
|
|
unsigned Size;
|
|
|
|
bool IsSgpr;
|
|
|
|
const RegisterBank *RB = MRI.getRegBankOrNull(I.getOperand(0).getReg());
|
|
|
|
if (RB) {
|
|
|
|
IsSgpr = RB->getID() == AMDGPU::SGPRRegBankID;
|
|
|
|
Size = MRI.getType(DstReg).getSizeInBits();
|
|
|
|
} else {
|
|
|
|
const TargetRegisterClass *RC = TRI.getRegClassForReg(MRI, DstReg);
|
|
|
|
IsSgpr = TRI.isSGPRClass(RC);
|
2018-05-21 19:49:31 +02:00
|
|
|
Size = TRI.getRegSizeInBits(*RC);
|
2018-05-15 19:57:09 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (Size != 32 && Size != 64)
|
|
|
|
return false;
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
2018-05-15 19:57:09 +02:00
|
|
|
unsigned Opcode = IsSgpr ? AMDGPU::S_MOV_B32 : AMDGPU::V_MOV_B32_e32;
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
if (Size == 32) {
|
2018-05-15 19:57:09 +02:00
|
|
|
I.setDesc(TII.get(Opcode));
|
|
|
|
I.addImplicitDefUseOperands(*MF);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
return constrainSelectedInstRegOperands(I, TII, TRI, RBI);
|
|
|
|
}
|
|
|
|
|
|
|
|
DebugLoc DL = I.getDebugLoc();
|
2018-05-15 19:57:09 +02:00
|
|
|
const TargetRegisterClass *RC = IsSgpr ? &AMDGPU::SReg_32_XM0RegClass :
|
|
|
|
&AMDGPU::VGPR_32RegClass;
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register LoReg = MRI.createVirtualRegister(RC);
|
|
|
|
Register HiReg = MRI.createVirtualRegister(RC);
|
2018-05-15 19:57:09 +02:00
|
|
|
const APInt &Imm = APInt(Size, I.getOperand(1).getImm());
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
2018-05-15 19:57:09 +02:00
|
|
|
BuildMI(*BB, &I, DL, TII.get(Opcode), LoReg)
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
.addImm(Imm.trunc(32).getZExtValue());
|
|
|
|
|
2018-05-15 19:57:09 +02:00
|
|
|
BuildMI(*BB, &I, DL, TII.get(Opcode), HiReg)
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
.addImm(Imm.ashr(32).getZExtValue());
|
|
|
|
|
2018-05-15 19:57:09 +02:00
|
|
|
const MachineInstr *RS =
|
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::REG_SEQUENCE), DstReg)
|
|
|
|
.addReg(LoReg)
|
|
|
|
.addImm(AMDGPU::sub0)
|
|
|
|
.addReg(HiReg)
|
|
|
|
.addImm(AMDGPU::sub1);
|
|
|
|
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
// We can't call constrainSelectedInstRegOperands here, because it doesn't
|
|
|
|
// work for target independent opcodes
|
|
|
|
I.eraseFromParent();
|
2018-05-15 19:57:09 +02:00
|
|
|
const TargetRegisterClass *DstRC =
|
|
|
|
TRI.getConstrainedRegClassForOperand(RS->getOperand(0), MRI);
|
|
|
|
if (!DstRC)
|
|
|
|
return true;
|
|
|
|
return RBI.constrainGenericRegister(DstReg, *DstRC, MRI);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
static bool isConstant(const MachineInstr &MI) {
|
|
|
|
return MI.getOpcode() == TargetOpcode::G_CONSTANT;
|
|
|
|
}
|
|
|
|
|
|
|
|
void AMDGPUInstructionSelector::getAddrModeInfo(const MachineInstr &Load,
|
|
|
|
const MachineRegisterInfo &MRI, SmallVectorImpl<GEPInfo> &AddrInfo) const {
|
|
|
|
|
|
|
|
const MachineInstr *PtrMI = MRI.getUniqueVRegDef(Load.getOperand(1).getReg());
|
|
|
|
|
|
|
|
assert(PtrMI);
|
|
|
|
|
|
|
|
if (PtrMI->getOpcode() != TargetOpcode::G_GEP)
|
|
|
|
return;
|
|
|
|
|
|
|
|
GEPInfo GEPInfo(*PtrMI);
|
|
|
|
|
|
|
|
for (unsigned i = 1, e = 3; i < e; ++i) {
|
|
|
|
const MachineOperand &GEPOp = PtrMI->getOperand(i);
|
|
|
|
const MachineInstr *OpDef = MRI.getUniqueVRegDef(GEPOp.getReg());
|
|
|
|
assert(OpDef);
|
|
|
|
if (isConstant(*OpDef)) {
|
|
|
|
// FIXME: Is it possible to have multiple Imm parts? Maybe if we
|
|
|
|
// are lacking other optimizations.
|
|
|
|
assert(GEPInfo.Imm == 0);
|
|
|
|
GEPInfo.Imm = OpDef->getOperand(1).getCImm()->getSExtValue();
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
const RegisterBank *OpBank = RBI.getRegBank(GEPOp.getReg(), MRI, TRI);
|
|
|
|
if (OpBank->getID() == AMDGPU::SGPRRegBankID)
|
|
|
|
GEPInfo.SgprParts.push_back(GEPOp.getReg());
|
|
|
|
else
|
|
|
|
GEPInfo.VgprParts.push_back(GEPOp.getReg());
|
|
|
|
}
|
|
|
|
|
|
|
|
AddrInfo.push_back(GEPInfo);
|
|
|
|
getAddrModeInfo(*PtrMI, MRI, AddrInfo);
|
|
|
|
}
|
|
|
|
|
AMDGPU/GlobalISel: Move SMRD selection logic to TableGen
Reviewers: arsenm
Reviewed By: arsenm
Subscribers: volkan, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D52922
llvm-svn: 354516
2019-02-20 22:02:37 +01:00
|
|
|
bool AMDGPUInstructionSelector::isInstrUniform(const MachineInstr &MI) const {
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
if (!MI.hasOneMemOperand())
|
|
|
|
return false;
|
|
|
|
|
|
|
|
const MachineMemOperand *MMO = *MI.memoperands_begin();
|
|
|
|
const Value *Ptr = MMO->getValue();
|
|
|
|
|
|
|
|
// UndefValue means this is a load of a kernel input. These are uniform.
|
|
|
|
// Sometimes LDS instructions have constant pointers.
|
|
|
|
// If Ptr is null, then that means this mem operand contains a
|
|
|
|
// PseudoSourceValue like GOT.
|
|
|
|
if (!Ptr || isa<UndefValue>(Ptr) || isa<Argument>(Ptr) ||
|
|
|
|
isa<Constant>(Ptr) || isa<GlobalValue>(Ptr))
|
|
|
|
return true;
|
|
|
|
|
2018-02-09 17:57:57 +01:00
|
|
|
if (MMO->getAddrSpace() == AMDGPUAS::CONSTANT_ADDRESS_32BIT)
|
|
|
|
return true;
|
|
|
|
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
const Instruction *I = dyn_cast<Instruction>(Ptr);
|
|
|
|
return I && I->getMetadata("amdgpu.uniform");
|
|
|
|
}
|
|
|
|
|
|
|
|
bool AMDGPUInstructionSelector::hasVgprParts(ArrayRef<GEPInfo> AddrInfo) const {
|
|
|
|
for (const GEPInfo &GEPInfo : AddrInfo) {
|
|
|
|
if (!GEPInfo.VgprParts.empty())
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2019-08-01 05:09:15 +02:00
|
|
|
void AMDGPUInstructionSelector::initM0(MachineInstr &I) const {
|
2019-08-01 02:53:38 +02:00
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
|
|
|
|
const LLT PtrTy = MRI.getType(I.getOperand(1).getReg());
|
|
|
|
unsigned AS = PtrTy.getAddressSpace();
|
|
|
|
if ((AS == AMDGPUAS::LOCAL_ADDRESS || AS == AMDGPUAS::REGION_ADDRESS) &&
|
|
|
|
STI.ldsRequiresM0Init()) {
|
|
|
|
// If DS instructions require M0 initializtion, insert it before selecting.
|
|
|
|
BuildMI(*BB, &I, I.getDebugLoc(), TII.get(AMDGPU::S_MOV_B32), AMDGPU::M0)
|
|
|
|
.addImm(-1);
|
|
|
|
}
|
2019-08-01 05:09:15 +02:00
|
|
|
}
|
2019-08-01 02:53:38 +02:00
|
|
|
|
2019-08-13 08:26:59 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_LOAD_ATOMICRMW(MachineInstr &I) const {
|
2019-08-01 05:09:15 +02:00
|
|
|
initM0(I);
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectImpl(I, *CoverageInfo);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
}
|
|
|
|
|
2019-07-01 17:39:27 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_BRCOND(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
MachineOperand &CondOp = I.getOperand(0);
|
|
|
|
Register CondReg = CondOp.getReg();
|
|
|
|
const DebugLoc &DL = I.getDebugLoc();
|
|
|
|
|
2019-07-01 18:06:02 +02:00
|
|
|
unsigned BrOpcode;
|
|
|
|
Register CondPhysReg;
|
|
|
|
const TargetRegisterClass *ConstrainRC;
|
|
|
|
|
|
|
|
// In SelectionDAG, we inspect the IR block for uniformity metadata to decide
|
|
|
|
// whether the branch is uniform when selecting the instruction. In
|
|
|
|
// GlobalISel, we should push that decision into RegBankSelect. Assume for now
|
|
|
|
// RegBankSelect knows what it's doing if the branch condition is scc, even
|
|
|
|
// though it currently does not.
|
2019-07-01 17:39:27 +02:00
|
|
|
if (isSCC(CondReg, MRI)) {
|
2019-07-01 18:06:02 +02:00
|
|
|
CondPhysReg = AMDGPU::SCC;
|
|
|
|
BrOpcode = AMDGPU::S_CBRANCH_SCC1;
|
|
|
|
ConstrainRC = &AMDGPU::SReg_32_XM0RegClass;
|
|
|
|
} else if (isVCC(CondReg, MRI)) {
|
|
|
|
// FIXME: Do we have to insert an and with exec here, like in SelectionDAG?
|
|
|
|
// We sort of know that a VCC producer based on the register bank, that ands
|
|
|
|
// inactive lanes with 0. What if there was a logical operation with vcc
|
|
|
|
// producers in different blocks/with different exec masks?
|
|
|
|
// FIXME: Should scc->vcc copies and with exec?
|
|
|
|
CondPhysReg = TRI.getVCC();
|
|
|
|
BrOpcode = AMDGPU::S_CBRANCH_VCCNZ;
|
|
|
|
ConstrainRC = TRI.getBoolRC();
|
|
|
|
} else
|
|
|
|
return false;
|
2019-07-01 17:39:27 +02:00
|
|
|
|
2019-07-01 18:06:02 +02:00
|
|
|
if (!MRI.getRegClassOrNull(CondReg))
|
|
|
|
MRI.setRegClass(CondReg, ConstrainRC);
|
2019-07-01 17:39:27 +02:00
|
|
|
|
2019-07-01 18:06:02 +02:00
|
|
|
BuildMI(*BB, &I, DL, TII.get(AMDGPU::COPY), CondPhysReg)
|
|
|
|
.addReg(CondReg);
|
|
|
|
BuildMI(*BB, &I, DL, TII.get(BrOpcode))
|
|
|
|
.addMBB(I.getOperand(1).getMBB());
|
|
|
|
|
|
|
|
I.eraseFromParent();
|
|
|
|
return true;
|
2019-07-01 17:39:27 +02:00
|
|
|
}
|
|
|
|
|
2019-07-01 17:48:18 +02:00
|
|
|
bool AMDGPUInstructionSelector::selectG_FRAME_INDEX(MachineInstr &I) const {
|
|
|
|
MachineBasicBlock *BB = I.getParent();
|
|
|
|
MachineFunction *MF = BB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
|
|
|
|
Register DstReg = I.getOperand(0).getReg();
|
|
|
|
const RegisterBank *DstRB = RBI.getRegBank(DstReg, MRI, TRI);
|
|
|
|
const bool IsVGPR = DstRB->getID() == AMDGPU::VGPRRegBankID;
|
|
|
|
I.setDesc(TII.get(IsVGPR ? AMDGPU::V_MOV_B32_e32 : AMDGPU::S_MOV_B32));
|
|
|
|
if (IsVGPR)
|
|
|
|
I.addOperand(*MF, MachineOperand::CreateReg(AMDGPU::EXEC, false, true));
|
|
|
|
|
|
|
|
return RBI.constrainGenericRegister(
|
|
|
|
DstReg, IsVGPR ? AMDGPU::VGPR_32RegClass : AMDGPU::SReg_32RegClass, MRI);
|
|
|
|
}
|
|
|
|
|
2019-08-13 08:26:59 +02:00
|
|
|
bool AMDGPUInstructionSelector::select(MachineInstr &I) {
|
2019-07-01 18:32:47 +02:00
|
|
|
if (I.isPHI())
|
|
|
|
return selectPHI(I);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
2018-06-22 02:44:29 +02:00
|
|
|
if (!isPreISelGenericOpcode(I.getOpcode())) {
|
|
|
|
if (I.isCopy())
|
|
|
|
return selectCOPY(I);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
return true;
|
2018-06-22 02:44:29 +02:00
|
|
|
}
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
|
|
|
|
switch (I.getOpcode()) {
|
2019-07-15 21:50:07 +02:00
|
|
|
case TargetOpcode::G_AND:
|
|
|
|
case TargetOpcode::G_OR:
|
|
|
|
case TargetOpcode::G_XOR:
|
|
|
|
if (selectG_AND_OR_XOR(I))
|
|
|
|
return true;
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectImpl(I, *CoverageInfo);
|
AMDGPU/GlobalISel: Implement select for 32-bit G_ADD
Reviewers: arsenm
Reviewed By: arsenm
Subscribers: hiraditya, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D58804
llvm-svn: 364797
2019-07-01 18:09:33 +02:00
|
|
|
case TargetOpcode::G_ADD:
|
2019-07-09 16:05:11 +02:00
|
|
|
case TargetOpcode::G_SUB:
|
|
|
|
if (selectG_ADD_SUB(I))
|
AMDGPU/GlobalISel: Implement select for 32-bit G_ADD
Reviewers: arsenm
Reviewed By: arsenm
Subscribers: hiraditya, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D58804
llvm-svn: 364797
2019-07-01 18:09:33 +02:00
|
|
|
return true;
|
|
|
|
LLVM_FALLTHROUGH;
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
default:
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectImpl(I, *CoverageInfo);
|
AMDGPU/GlobalISel: Add support for G_INTTOPTR
Summary: This is a no-op.
Reviewers: arsenm
Reviewed By: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D52916
llvm-svn: 343839
2018-10-05 06:34:09 +02:00
|
|
|
case TargetOpcode::G_INTTOPTR:
|
2018-05-10 23:20:10 +02:00
|
|
|
case TargetOpcode::G_BITCAST:
|
|
|
|
return selectCOPY(I);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
case TargetOpcode::G_CONSTANT:
|
2018-05-15 19:57:09 +02:00
|
|
|
case TargetOpcode::G_FCONSTANT:
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
return selectG_CONSTANT(I);
|
2019-03-01 00:37:48 +01:00
|
|
|
case TargetOpcode::G_EXTRACT:
|
|
|
|
return selectG_EXTRACT(I);
|
2019-07-09 16:02:20 +02:00
|
|
|
case TargetOpcode::G_MERGE_VALUES:
|
2019-07-15 19:26:43 +02:00
|
|
|
case TargetOpcode::G_BUILD_VECTOR:
|
2019-07-09 16:02:20 +02:00
|
|
|
case TargetOpcode::G_CONCAT_VECTORS:
|
|
|
|
return selectG_MERGE_VALUES(I);
|
2019-07-09 16:02:26 +02:00
|
|
|
case TargetOpcode::G_UNMERGE_VALUES:
|
|
|
|
return selectG_UNMERGE_VALUES(I);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
case TargetOpcode::G_GEP:
|
|
|
|
return selectG_GEP(I);
|
2018-06-22 01:38:20 +02:00
|
|
|
case TargetOpcode::G_IMPLICIT_DEF:
|
|
|
|
return selectG_IMPLICIT_DEF(I);
|
AMDGPU/GlobalISel: Implement select for G_INSERT
Re-commit r344310.
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D53116
llvm-svn: 355159
2019-03-01 01:50:26 +01:00
|
|
|
case TargetOpcode::G_INSERT:
|
|
|
|
return selectG_INSERT(I);
|
2018-06-14 21:26:37 +02:00
|
|
|
case TargetOpcode::G_INTRINSIC:
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectG_INTRINSIC(I);
|
2018-07-13 23:05:14 +02:00
|
|
|
case TargetOpcode::G_INTRINSIC_W_SIDE_EFFECTS:
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectG_INTRINSIC_W_SIDE_EFFECTS(I);
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
case TargetOpcode::G_ICMP:
|
2019-07-01 15:34:26 +02:00
|
|
|
if (selectG_ICMP(I))
|
|
|
|
return true;
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectImpl(I, *CoverageInfo);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
case TargetOpcode::G_LOAD:
|
2019-08-01 05:29:01 +02:00
|
|
|
case TargetOpcode::G_ATOMIC_CMPXCHG:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_XCHG:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_ADD:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_SUB:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_AND:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_OR:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_XOR:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_MIN:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_MAX:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_UMIN:
|
|
|
|
case TargetOpcode::G_ATOMICRMW_UMAX:
|
2019-08-01 05:33:15 +02:00
|
|
|
case TargetOpcode::G_ATOMICRMW_FADD:
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectG_LOAD_ATOMICRMW(I);
|
AMDGPU/GlobalISel: Implement select for G_ICMP and G_SELECT
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D60640
llvm-svn: 363576
2019-06-17 18:27:43 +02:00
|
|
|
case TargetOpcode::G_SELECT:
|
|
|
|
return selectG_SELECT(I);
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
case TargetOpcode::G_STORE:
|
2019-08-13 08:26:59 +02:00
|
|
|
return selectG_STORE(I);
|
2019-06-24 20:02:18 +02:00
|
|
|
case TargetOpcode::G_TRUNC:
|
|
|
|
return selectG_TRUNC(I);
|
2019-06-25 15:18:11 +02:00
|
|
|
case TargetOpcode::G_SEXT:
|
|
|
|
case TargetOpcode::G_ZEXT:
|
|
|
|
case TargetOpcode::G_ANYEXT:
|
2019-07-24 18:05:53 +02:00
|
|
|
return selectG_SZA_EXT(I);
|
2019-07-01 17:39:27 +02:00
|
|
|
case TargetOpcode::G_BRCOND:
|
|
|
|
return selectG_BRCOND(I);
|
2019-07-01 17:48:18 +02:00
|
|
|
case TargetOpcode::G_FRAME_INDEX:
|
|
|
|
return selectG_FRAME_INDEX(I);
|
2019-07-02 16:17:38 +02:00
|
|
|
case TargetOpcode::G_FENCE:
|
|
|
|
// FIXME: Tablegen importer doesn't handle the imm operands correctly, and
|
|
|
|
// is checking for G_CONSTANT
|
|
|
|
I.setDesc(TII.get(AMDGPU::ATOMIC_FENCE));
|
|
|
|
return true;
|
Re-commit AMDGPU/GlobalISel: Add support for simple shaders
Fix build when global-isel is disabled and fix a warning.
Summary: We can select constant/global G_LOAD, global G_STORE, and G_GEP.
Reviewers: qcolombet, MatzeB, t.p.northover, ab, arsenm
Subscribers: mehdi_amini, vkalintiris, kzhuravl, wdng, nhaehnle, mgorny, yaxunl, tony-tye, modocache, llvm-commits, dberris
Differential Revision: https://reviews.llvm.org/D26730
llvm-svn: 293551
2017-01-30 22:56:46 +01:00
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
|
2018-06-22 04:54:57 +02:00
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectVCSRC(MachineOperand &Root) const {
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.add(Root); }
|
|
|
|
}};
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2019-07-01 17:18:56 +02:00
|
|
|
std::pair<Register, unsigned>
|
|
|
|
AMDGPUInstructionSelector::selectVOP3ModsImpl(
|
|
|
|
Register Src, const MachineRegisterInfo &MRI) const {
|
|
|
|
unsigned Mods = 0;
|
|
|
|
MachineInstr *MI = MRI.getVRegDef(Src);
|
|
|
|
|
|
|
|
if (MI && MI->getOpcode() == AMDGPU::G_FNEG) {
|
|
|
|
Src = MI->getOperand(1).getReg();
|
|
|
|
Mods |= SISrcMods::NEG;
|
|
|
|
MI = MRI.getVRegDef(Src);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (MI && MI->getOpcode() == AMDGPU::G_FABS) {
|
|
|
|
Src = MI->getOperand(1).getReg();
|
|
|
|
Mods |= SISrcMods::ABS;
|
|
|
|
}
|
|
|
|
|
|
|
|
return std::make_pair(Src, Mods);
|
|
|
|
}
|
|
|
|
|
AMDGPU/GlobalISel: Enable TableGen'd instruction selector
Reviewers: arsenm, nhaehnle
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, mgorny, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D45994
llvm-svn: 332039
2018-05-10 22:53:06 +02:00
|
|
|
///
|
|
|
|
/// This will select either an SGPR or VGPR operand and will save us from
|
|
|
|
/// having to write an extra tablegen pattern.
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectVSRC0(MachineOperand &Root) const {
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.add(Root); }
|
|
|
|
}};
|
|
|
|
}
|
2018-05-11 07:44:16 +02:00
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectVOP3Mods0(MachineOperand &Root) const {
|
2019-07-01 17:18:56 +02:00
|
|
|
MachineRegisterInfo &MRI
|
|
|
|
= Root.getParent()->getParent()->getParent()->getRegInfo();
|
|
|
|
|
|
|
|
Register Src;
|
|
|
|
unsigned Mods;
|
|
|
|
std::tie(Src, Mods) = selectVOP3ModsImpl(Root.getReg(), MRI);
|
|
|
|
|
2018-05-11 07:44:16 +02:00
|
|
|
return {{
|
2019-07-01 17:18:56 +02:00
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(Src); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(Mods); }, // src0_mods
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); }, // clamp
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); } // omod
|
2018-05-11 07:44:16 +02:00
|
|
|
}};
|
|
|
|
}
|
2018-06-22 04:34:29 +02:00
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectVOP3OMods(MachineOperand &Root) const {
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.add(Root); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); }, // clamp
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); } // omod
|
|
|
|
}};
|
|
|
|
}
|
2018-06-14 00:30:47 +02:00
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectVOP3Mods(MachineOperand &Root) const {
|
2019-07-01 17:18:56 +02:00
|
|
|
MachineRegisterInfo &MRI
|
|
|
|
= Root.getParent()->getParent()->getParent()->getRegInfo();
|
|
|
|
|
|
|
|
Register Src;
|
|
|
|
unsigned Mods;
|
|
|
|
std::tie(Src, Mods) = selectVOP3ModsImpl(Root.getReg(), MRI);
|
|
|
|
|
2018-06-14 00:30:47 +02:00
|
|
|
return {{
|
2019-07-01 17:18:56 +02:00
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(Src); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(Mods); } // src_mods
|
2018-06-14 00:30:47 +02:00
|
|
|
}};
|
|
|
|
}
|
AMDGPU/GlobalISel: Move SMRD selection logic to TableGen
Reviewers: arsenm
Reviewed By: arsenm
Subscribers: volkan, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D52922
llvm-svn: 354516
2019-02-20 22:02:37 +01:00
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectSmrdImm(MachineOperand &Root) const {
|
|
|
|
MachineRegisterInfo &MRI =
|
|
|
|
Root.getParent()->getParent()->getParent()->getRegInfo();
|
|
|
|
|
|
|
|
SmallVector<GEPInfo, 4> AddrInfo;
|
|
|
|
getAddrModeInfo(*Root.getParent(), MRI, AddrInfo);
|
|
|
|
|
|
|
|
if (AddrInfo.empty() || AddrInfo[0].SgprParts.size() != 1)
|
|
|
|
return None;
|
|
|
|
|
|
|
|
const GEPInfo &GEPInfo = AddrInfo[0];
|
|
|
|
|
|
|
|
if (!AMDGPU::isLegalSMRDImmOffset(STI, GEPInfo.Imm))
|
|
|
|
return None;
|
|
|
|
|
|
|
|
unsigned PtrReg = GEPInfo.SgprParts[0];
|
|
|
|
int64_t EncodedImm = AMDGPU::getSMRDEncodedOffset(STI, GEPInfo.Imm);
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(PtrReg); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(EncodedImm); }
|
|
|
|
}};
|
|
|
|
}
|
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectSmrdImm32(MachineOperand &Root) const {
|
|
|
|
MachineRegisterInfo &MRI =
|
|
|
|
Root.getParent()->getParent()->getParent()->getRegInfo();
|
|
|
|
|
|
|
|
SmallVector<GEPInfo, 4> AddrInfo;
|
|
|
|
getAddrModeInfo(*Root.getParent(), MRI, AddrInfo);
|
|
|
|
|
|
|
|
if (AddrInfo.empty() || AddrInfo[0].SgprParts.size() != 1)
|
|
|
|
return None;
|
|
|
|
|
|
|
|
const GEPInfo &GEPInfo = AddrInfo[0];
|
|
|
|
unsigned PtrReg = GEPInfo.SgprParts[0];
|
|
|
|
int64_t EncodedImm = AMDGPU::getSMRDEncodedOffset(STI, GEPInfo.Imm);
|
|
|
|
if (!isUInt<32>(EncodedImm))
|
|
|
|
return None;
|
|
|
|
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(PtrReg); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(EncodedImm); }
|
|
|
|
}};
|
|
|
|
}
|
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectSmrdSgpr(MachineOperand &Root) const {
|
|
|
|
MachineInstr *MI = Root.getParent();
|
|
|
|
MachineBasicBlock *MBB = MI->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MBB->getParent()->getRegInfo();
|
|
|
|
|
|
|
|
SmallVector<GEPInfo, 4> AddrInfo;
|
|
|
|
getAddrModeInfo(*MI, MRI, AddrInfo);
|
|
|
|
|
|
|
|
// FIXME: We should shrink the GEP if the offset is known to be <= 32-bits,
|
|
|
|
// then we can select all ptr + 32-bit offsets not just immediate offsets.
|
|
|
|
if (AddrInfo.empty() || AddrInfo[0].SgprParts.size() != 1)
|
|
|
|
return None;
|
|
|
|
|
|
|
|
const GEPInfo &GEPInfo = AddrInfo[0];
|
|
|
|
if (!GEPInfo.Imm || !isUInt<32>(GEPInfo.Imm))
|
|
|
|
return None;
|
|
|
|
|
|
|
|
// If we make it this far we have a load with an 32-bit immediate offset.
|
|
|
|
// It is OK to select this using a sgpr offset, because we have already
|
|
|
|
// failed trying to select this load into one of the _IMM variants since
|
|
|
|
// the _IMM Patterns are considered before the _SGPR patterns.
|
|
|
|
unsigned PtrReg = GEPInfo.SgprParts[0];
|
Apply llvm-prefer-register-over-unsigned from clang-tidy to LLVM
Summary:
This clang-tidy check is looking for unsigned integer variables whose initializer
starts with an implicit cast from llvm::Register and changes the type of the
variable to llvm::Register (dropping the llvm:: where possible).
Partial reverts in:
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
X86FixupLEAs.cpp - Some functions return unsigned and arguably should be MCRegister
X86FrameLowering.cpp - Some functions return unsigned and arguably should be MCRegister
HexagonBitSimplify.cpp - Function takes BitTracker::RegisterRef which appears to be unsigned&
MachineVerifier.cpp - Ambiguous operator==() given MCRegister and const Register
PPCFastISel.cpp - No Register::operator-=()
PeepholeOptimizer.cpp - TargetInstrInfo::optimizeLoadInstr() takes an unsigned&
MachineTraceMetrics.cpp - MachineTraceMetrics lacks a suitable constructor
Manual fixups in:
ARMFastISel.cpp - ARMEmitLoad() now takes a Register& instead of unsigned&
HexagonSplitDouble.cpp - Ternary operator was ambiguous between unsigned/Register
HexagonConstExtenders.cpp - Has a local class named Register, used llvm::Register instead of Register.
PPCFastISel.cpp - PPCEmitLoad() now takes a Register& instead of unsigned&
Depends on D65919
Reviewers: arsenm, bogner, craig.topper, RKSimon
Reviewed By: arsenm
Subscribers: RKSimon, craig.topper, lenary, aemerson, wuzish, jholewinski, MatzeB, qcolombet, dschuff, jyknight, dylanmckay, sdardis, nemanjai, jvesely, wdng, nhaehnle, sbc100, jgravelle-google, kristof.beyls, hiraditya, aheejin, kbarton, fedor.sergeev, javed.absar, asb, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, jrtc27, MaskRay, zzheng, edward-jones, atanasyan, rogfer01, MartinMosbeck, brucehoult, the_o, tpr, PkmX, jocewei, jsji, Petar.Avramovic, asbirlea, Jim, s.egerton, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D65962
llvm-svn: 369041
2019-08-15 21:22:08 +02:00
|
|
|
Register OffsetReg = MRI.createVirtualRegister(&AMDGPU::SReg_32_XM0RegClass);
|
AMDGPU/GlobalISel: Move SMRD selection logic to TableGen
Reviewers: arsenm
Reviewed By: arsenm
Subscribers: volkan, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D52922
llvm-svn: 354516
2019-02-20 22:02:37 +01:00
|
|
|
BuildMI(*MBB, MI, MI->getDebugLoc(), TII.get(AMDGPU::S_MOV_B32), OffsetReg)
|
|
|
|
.addImm(GEPInfo.Imm);
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(PtrReg); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(OffsetReg); }
|
|
|
|
}};
|
|
|
|
}
|
2019-07-16 20:05:29 +02:00
|
|
|
|
2019-07-16 20:42:53 +02:00
|
|
|
template <bool Signed>
|
2019-07-16 20:05:29 +02:00
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectFlatOffsetImpl(MachineOperand &Root) const {
|
|
|
|
MachineInstr *MI = Root.getParent();
|
|
|
|
MachineBasicBlock *MBB = MI->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MBB->getParent()->getRegInfo();
|
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns Default = {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(Root.getReg()); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); }, // offset
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); } // slc
|
|
|
|
}};
|
|
|
|
|
|
|
|
if (!STI.hasFlatInstOffsets())
|
|
|
|
return Default;
|
|
|
|
|
|
|
|
const MachineInstr *OpDef = MRI.getVRegDef(Root.getReg());
|
|
|
|
if (!OpDef || OpDef->getOpcode() != AMDGPU::G_GEP)
|
|
|
|
return Default;
|
|
|
|
|
|
|
|
Optional<int64_t> Offset =
|
|
|
|
getConstantVRegVal(OpDef->getOperand(2).getReg(), MRI);
|
|
|
|
if (!Offset.hasValue())
|
|
|
|
return Default;
|
|
|
|
|
|
|
|
unsigned AddrSpace = (*MI->memoperands_begin())->getAddrSpace();
|
|
|
|
if (!TII.isLegalFLATOffset(Offset.getValue(), AddrSpace, Signed))
|
|
|
|
return Default;
|
|
|
|
|
|
|
|
Register BasePtr = OpDef->getOperand(1).getReg();
|
|
|
|
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(BasePtr); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(Offset.getValue()); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); } // slc
|
|
|
|
}};
|
|
|
|
}
|
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectFlatOffset(MachineOperand &Root) const {
|
|
|
|
return selectFlatOffsetImpl<false>(Root);
|
|
|
|
}
|
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectFlatOffsetSigned(MachineOperand &Root) const {
|
|
|
|
return selectFlatOffsetImpl<true>(Root);
|
|
|
|
}
|
2019-07-16 21:22:21 +02:00
|
|
|
|
|
|
|
// FIXME: Implement
|
|
|
|
static bool signBitIsZero(const MachineOperand &Op,
|
|
|
|
const MachineRegisterInfo &MRI) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool isStackPtrRelative(const MachinePointerInfo &PtrInfo) {
|
|
|
|
auto PSV = PtrInfo.V.dyn_cast<const PseudoSourceValue *>();
|
|
|
|
return PSV && PSV->isStack();
|
|
|
|
}
|
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectMUBUFScratchOffen(MachineOperand &Root) const {
|
|
|
|
MachineInstr *MI = Root.getParent();
|
|
|
|
MachineBasicBlock *MBB = MI->getParent();
|
|
|
|
MachineFunction *MF = MBB->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MF->getRegInfo();
|
|
|
|
const SIMachineFunctionInfo *Info = MF->getInfo<SIMachineFunctionInfo>();
|
|
|
|
|
|
|
|
int64_t Offset = 0;
|
|
|
|
if (mi_match(Root.getReg(), MRI, m_ICst(Offset))) {
|
|
|
|
Register HighBits = MRI.createVirtualRegister(&AMDGPU::VGPR_32RegClass);
|
|
|
|
|
|
|
|
// TODO: Should this be inside the render function? The iterator seems to
|
|
|
|
// move.
|
|
|
|
BuildMI(*MBB, MI, MI->getDebugLoc(), TII.get(AMDGPU::V_MOV_B32_e32),
|
|
|
|
HighBits)
|
|
|
|
.addImm(Offset & ~4095);
|
|
|
|
|
|
|
|
return {{[=](MachineInstrBuilder &MIB) { // rsrc
|
|
|
|
MIB.addReg(Info->getScratchRSrcReg());
|
|
|
|
},
|
|
|
|
[=](MachineInstrBuilder &MIB) { // vaddr
|
|
|
|
MIB.addReg(HighBits);
|
|
|
|
},
|
|
|
|
[=](MachineInstrBuilder &MIB) { // soffset
|
|
|
|
const MachineMemOperand *MMO = *MI->memoperands_begin();
|
|
|
|
const MachinePointerInfo &PtrInfo = MMO->getPointerInfo();
|
|
|
|
|
|
|
|
Register SOffsetReg = isStackPtrRelative(PtrInfo)
|
|
|
|
? Info->getStackPtrOffsetReg()
|
|
|
|
: Info->getScratchWaveOffsetReg();
|
|
|
|
MIB.addReg(SOffsetReg);
|
|
|
|
},
|
|
|
|
[=](MachineInstrBuilder &MIB) { // offset
|
|
|
|
MIB.addImm(Offset & 4095);
|
|
|
|
}}};
|
|
|
|
}
|
|
|
|
|
|
|
|
assert(Offset == 0);
|
|
|
|
|
|
|
|
// Try to fold a frame index directly into the MUBUF vaddr field, and any
|
|
|
|
// offsets.
|
|
|
|
Optional<int> FI;
|
|
|
|
Register VAddr = Root.getReg();
|
|
|
|
if (const MachineInstr *RootDef = MRI.getVRegDef(Root.getReg())) {
|
|
|
|
if (isBaseWithConstantOffset(Root, MRI)) {
|
|
|
|
const MachineOperand &LHS = RootDef->getOperand(1);
|
|
|
|
const MachineOperand &RHS = RootDef->getOperand(2);
|
|
|
|
const MachineInstr *LHSDef = MRI.getVRegDef(LHS.getReg());
|
|
|
|
const MachineInstr *RHSDef = MRI.getVRegDef(RHS.getReg());
|
|
|
|
if (LHSDef && RHSDef) {
|
|
|
|
int64_t PossibleOffset =
|
|
|
|
RHSDef->getOperand(1).getCImm()->getSExtValue();
|
|
|
|
if (SIInstrInfo::isLegalMUBUFImmOffset(PossibleOffset) &&
|
|
|
|
(!STI.privateMemoryResourceIsRangeChecked() ||
|
|
|
|
signBitIsZero(LHS, MRI))) {
|
|
|
|
if (LHSDef->getOpcode() == AMDGPU::G_FRAME_INDEX)
|
|
|
|
FI = LHSDef->getOperand(1).getIndex();
|
|
|
|
else
|
|
|
|
VAddr = LHS.getReg();
|
|
|
|
Offset = PossibleOffset;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else if (RootDef->getOpcode() == AMDGPU::G_FRAME_INDEX) {
|
|
|
|
FI = RootDef->getOperand(1).getIndex();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If we don't know this private access is a local stack object, it needs to
|
|
|
|
// be relative to the entry point's scratch wave offset register.
|
|
|
|
// TODO: Should split large offsets that don't fit like above.
|
|
|
|
// TODO: Don't use scratch wave offset just because the offset didn't fit.
|
|
|
|
Register SOffset = FI.hasValue() ? Info->getStackPtrOffsetReg()
|
|
|
|
: Info->getScratchWaveOffsetReg();
|
|
|
|
|
|
|
|
return {{[=](MachineInstrBuilder &MIB) { // rsrc
|
|
|
|
MIB.addReg(Info->getScratchRSrcReg());
|
|
|
|
},
|
|
|
|
[=](MachineInstrBuilder &MIB) { // vaddr
|
|
|
|
if (FI.hasValue())
|
|
|
|
MIB.addFrameIndex(FI.getValue());
|
|
|
|
else
|
|
|
|
MIB.addReg(VAddr);
|
|
|
|
},
|
|
|
|
[=](MachineInstrBuilder &MIB) { // soffset
|
|
|
|
MIB.addReg(SOffset);
|
|
|
|
},
|
|
|
|
[=](MachineInstrBuilder &MIB) { // offset
|
|
|
|
MIB.addImm(Offset);
|
|
|
|
}}};
|
|
|
|
}
|
|
|
|
|
2019-08-01 02:53:38 +02:00
|
|
|
bool AMDGPUInstructionSelector::isDSOffsetLegal(const MachineRegisterInfo &MRI,
|
|
|
|
const MachineOperand &Base,
|
|
|
|
int64_t Offset,
|
|
|
|
unsigned OffsetBits) const {
|
|
|
|
if ((OffsetBits == 16 && !isUInt<16>(Offset)) ||
|
|
|
|
(OffsetBits == 8 && !isUInt<8>(Offset)))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
if (STI.hasUsableDSOffset() || STI.unsafeDSOffsetFoldingEnabled())
|
|
|
|
return true;
|
|
|
|
|
|
|
|
// On Southern Islands instruction with a negative base value and an offset
|
|
|
|
// don't seem to work.
|
|
|
|
return signBitIsZero(Base, MRI);
|
|
|
|
}
|
|
|
|
|
2019-07-16 21:22:21 +02:00
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectMUBUFScratchOffset(
|
|
|
|
MachineOperand &Root) const {
|
|
|
|
MachineInstr *MI = Root.getParent();
|
|
|
|
MachineBasicBlock *MBB = MI->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MBB->getParent()->getRegInfo();
|
|
|
|
|
|
|
|
int64_t Offset = 0;
|
|
|
|
if (!mi_match(Root.getReg(), MRI, m_ICst(Offset)) ||
|
|
|
|
!SIInstrInfo::isLegalMUBUFImmOffset(Offset))
|
|
|
|
return {};
|
|
|
|
|
|
|
|
const MachineFunction *MF = MBB->getParent();
|
|
|
|
const SIMachineFunctionInfo *Info = MF->getInfo<SIMachineFunctionInfo>();
|
|
|
|
const MachineMemOperand *MMO = *MI->memoperands_begin();
|
|
|
|
const MachinePointerInfo &PtrInfo = MMO->getPointerInfo();
|
|
|
|
|
|
|
|
Register SOffsetReg = isStackPtrRelative(PtrInfo)
|
|
|
|
? Info->getStackPtrOffsetReg()
|
|
|
|
: Info->getScratchWaveOffsetReg();
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) {
|
|
|
|
MIB.addReg(Info->getScratchRSrcReg());
|
|
|
|
}, // rsrc
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addReg(SOffsetReg); }, // soffset
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(Offset); } // offset
|
|
|
|
}};
|
|
|
|
}
|
2019-08-01 02:53:38 +02:00
|
|
|
|
|
|
|
InstructionSelector::ComplexRendererFns
|
|
|
|
AMDGPUInstructionSelector::selectDS1Addr1Offset(MachineOperand &Root) const {
|
|
|
|
MachineInstr *MI = Root.getParent();
|
|
|
|
MachineBasicBlock *MBB = MI->getParent();
|
|
|
|
MachineRegisterInfo &MRI = MBB->getParent()->getRegInfo();
|
|
|
|
|
|
|
|
const MachineInstr *RootDef = MRI.getVRegDef(Root.getReg());
|
|
|
|
if (!RootDef) {
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.add(Root); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); }
|
|
|
|
}};
|
|
|
|
}
|
|
|
|
|
|
|
|
int64_t ConstAddr = 0;
|
|
|
|
if (isBaseWithConstantOffset(Root, MRI)) {
|
|
|
|
const MachineOperand &LHS = RootDef->getOperand(1);
|
|
|
|
const MachineOperand &RHS = RootDef->getOperand(2);
|
|
|
|
const MachineInstr *LHSDef = MRI.getVRegDef(LHS.getReg());
|
|
|
|
const MachineInstr *RHSDef = MRI.getVRegDef(RHS.getReg());
|
|
|
|
if (LHSDef && RHSDef) {
|
|
|
|
int64_t PossibleOffset =
|
|
|
|
RHSDef->getOperand(1).getCImm()->getSExtValue();
|
|
|
|
if (isDSOffsetLegal(MRI, LHS, PossibleOffset, 16)) {
|
|
|
|
// (add n0, c0)
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.add(LHS); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(PossibleOffset); }
|
|
|
|
}};
|
|
|
|
}
|
|
|
|
}
|
|
|
|
} else if (RootDef->getOpcode() == AMDGPU::G_SUB) {
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
} else if (mi_match(Root.getReg(), MRI, m_ICst(ConstAddr))) {
|
|
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
return {{
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.add(Root); },
|
|
|
|
[=](MachineInstrBuilder &MIB) { MIB.addImm(0); }
|
|
|
|
}};
|
|
|
|
}
|